From 5ade3000bd6040bf6878eafd6c77168552f73c47 Mon Sep 17 00:00:00 2001 From: Jason Ni Date: Thu, 14 Aug 2025 19:17:51 +0800 Subject: [PATCH] ggml: fix ggml_conv_1d_dw bug (ggml/1323) * ggml: fix ggml_conv_1d_dw bug * Fixed conv1d_dw weight tensor dimension. --- ggml/src/ggml.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ggml/src/ggml.c b/ggml/src/ggml.c index 549612131..a4417f1a1 100644 --- a/ggml/src/ggml.c +++ b/ggml/src/ggml.c @@ -4272,14 +4272,13 @@ struct ggml_tensor * ggml_conv_1d_dw( int s0, int p0, int d0) { - struct ggml_tensor * new_a = ggml_reshape_4d(ctx, a, a->ne[0], 1, a->ne[1], a->ne[2]); struct ggml_tensor * new_b = ggml_reshape_4d(ctx, b, b->ne[0], 1, b->ne[1], b->ne[2]); - struct ggml_tensor * im2col = ggml_im2col(ctx, new_a, new_b, s0, 0, p0, 0, d0, 0, false, GGML_TYPE_F16); + struct ggml_tensor * im2col = ggml_im2col(ctx, a, new_b, s0, 0, p0, 0, d0, 0, false, GGML_TYPE_F16); struct ggml_tensor * result = ggml_mul_mat(ctx, im2col, a); - result = ggml_reshape_3d(ctx, result, b->ne[0], b->ne[1], 1); + result = ggml_reshape_3d(ctx, result, result->ne[0], result->ne[2], 1); return result; }