a7528a5d2b
1) Inline EncodeFixed{32,64}(). They emit single machine instructions on 64-bit processors. 2) Remove size narrowing compiler warnings from DecodeFixed{32,64}(). 3) Add comments explaining the current state of optimizations in compilers we care about. 4) Change C-style includes, like <stdint.h>, to C++ style, like <cstdint>. 5) memcpy -> std::memcpy. The optimization comments are based on https://godbolt.org/z/RdIqS1. The missed optimization opportunities in clang have been reported as https://bugs.llvm.org/show_bug.cgi?id=41761 The change does not have significant impact on benchmarks. Results below. LevelDB: version 1.22 Date: Mon May 6 10:42:18 2019 CPU: 72 * Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz CPUCache: 25344 KB Keys: 16 bytes each Values: 100 bytes each (50 bytes after compression) Entries: 1000000 RawSize: 110.6 MB (estimated) FileSize: 62.9 MB (estimated) With change ------------------------------------------------ fillseq : 2.327 micros/op; 47.5 MB/s fillsync : 4185.526 micros/op; 0.0 MB/s (1000 ops) fillrandom : 3.662 micros/op; 30.2 MB/s overwrite : 4.261 micros/op; 26.0 MB/s readrandom : 4.239 micros/op; (1000000 of 1000000 found) readrandom : 3.649 micros/op; (1000000 of 1000000 found) readseq : 0.174 micros/op; 636.7 MB/s readreverse : 0.271 micros/op; 408.7 MB/s compact : 570495.000 micros/op; readrandom : 2.735 micros/op; (1000000 of 1000000 found) readseq : 0.118 micros/op; 937.3 MB/s readreverse : 0.190 micros/op; 583.7 MB/s fill100K : 860.164 micros/op; 110.9 MB/s (1000 ops) crc32c : 1.131 micros/op; 3455.2 MB/s (4K per op) snappycomp : 3.034 micros/op; 1287.5 MB/s (output: 55.1%) snappyuncomp : 0.544 micros/op; 7176.0 MB/s Baseline ------------------------------------------------ fillseq : 2.365 micros/op; 46.8 MB/s fillsync : 4240.165 micros/op; 0.0 MB/s (1000 ops) fillrandom : 3.244 micros/op; 34.1 MB/s overwrite : 4.153 micros/op; 26.6 MB/s readrandom : 4.698 micros/op; (1000000 of 1000000 found) readrandom : 4.065 micros/op; (1000000 of 1000000 found) readseq : 0.192 micros/op; 576.3 MB/s readreverse : 0.286 micros/op; 386.7 MB/s compact : 635979.000 micros/op; readrandom : 3.264 micros/op; (1000000 of 1000000 found) readseq : 0.169 micros/op; 652.8 MB/s readreverse : 0.213 micros/op; 519.5 MB/s fill100K : 1055.367 micros/op; 90.4 MB/s (1000 ops) crc32c : 1.353 micros/op; 2887.3 MB/s (4K per op) snappycomp : 3.036 micros/op; 1286.7 MB/s (output: 55.1%) snappyuncomp : 0.540 micros/op; 7238.6 MB/s PiperOrigin-RevId: 246856811
167 lines
4.2 KiB
C++
167 lines
4.2 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "util/coding.h"
|
|
|
|
namespace leveldb {
|
|
|
|
void PutFixed32(std::string* dst, uint32_t value) {
|
|
char buf[sizeof(value)];
|
|
EncodeFixed32(buf, value);
|
|
dst->append(buf, sizeof(buf));
|
|
}
|
|
|
|
void PutFixed64(std::string* dst, uint64_t value) {
|
|
char buf[sizeof(value)];
|
|
EncodeFixed64(buf, value);
|
|
dst->append(buf, sizeof(buf));
|
|
}
|
|
|
|
char* EncodeVarint32(char* dst, uint32_t v) {
|
|
// Operate on characters as unsigneds
|
|
unsigned char* ptr = reinterpret_cast<unsigned char*>(dst);
|
|
static const int B = 128;
|
|
if (v < (1 << 7)) {
|
|
*(ptr++) = v;
|
|
} else if (v < (1 << 14)) {
|
|
*(ptr++) = v | B;
|
|
*(ptr++) = v >> 7;
|
|
} else if (v < (1 << 21)) {
|
|
*(ptr++) = v | B;
|
|
*(ptr++) = (v >> 7) | B;
|
|
*(ptr++) = v >> 14;
|
|
} else if (v < (1 << 28)) {
|
|
*(ptr++) = v | B;
|
|
*(ptr++) = (v >> 7) | B;
|
|
*(ptr++) = (v >> 14) | B;
|
|
*(ptr++) = v >> 21;
|
|
} else {
|
|
*(ptr++) = v | B;
|
|
*(ptr++) = (v >> 7) | B;
|
|
*(ptr++) = (v >> 14) | B;
|
|
*(ptr++) = (v >> 21) | B;
|
|
*(ptr++) = v >> 28;
|
|
}
|
|
return reinterpret_cast<char*>(ptr);
|
|
}
|
|
|
|
void PutVarint32(std::string* dst, uint32_t v) {
|
|
char buf[5];
|
|
char* ptr = EncodeVarint32(buf, v);
|
|
dst->append(buf, ptr - buf);
|
|
}
|
|
|
|
char* EncodeVarint64(char* dst, uint64_t v) {
|
|
static const int B = 128;
|
|
unsigned char* ptr = reinterpret_cast<unsigned char*>(dst);
|
|
while (v >= B) {
|
|
*(ptr++) = v | B;
|
|
v >>= 7;
|
|
}
|
|
*(ptr++) = static_cast<unsigned char>(v);
|
|
return reinterpret_cast<char*>(ptr);
|
|
}
|
|
|
|
void PutVarint64(std::string* dst, uint64_t v) {
|
|
char buf[10];
|
|
char* ptr = EncodeVarint64(buf, v);
|
|
dst->append(buf, ptr - buf);
|
|
}
|
|
|
|
void PutLengthPrefixedSlice(std::string* dst, const Slice& value) {
|
|
PutVarint32(dst, value.size());
|
|
dst->append(value.data(), value.size());
|
|
}
|
|
|
|
int VarintLength(uint64_t v) {
|
|
int len = 1;
|
|
while (v >= 128) {
|
|
v >>= 7;
|
|
len++;
|
|
}
|
|
return len;
|
|
}
|
|
|
|
const char* GetVarint32PtrFallback(const char* p, const char* limit,
|
|
uint32_t* value) {
|
|
uint32_t result = 0;
|
|
for (uint32_t shift = 0; shift <= 28 && p < limit; shift += 7) {
|
|
uint32_t byte = *(reinterpret_cast<const unsigned char*>(p));
|
|
p++;
|
|
if (byte & 128) {
|
|
// More bytes are present
|
|
result |= ((byte & 127) << shift);
|
|
} else {
|
|
result |= (byte << shift);
|
|
*value = result;
|
|
return reinterpret_cast<const char*>(p);
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
bool GetVarint32(Slice* input, uint32_t* value) {
|
|
const char* p = input->data();
|
|
const char* limit = p + input->size();
|
|
const char* q = GetVarint32Ptr(p, limit, value);
|
|
if (q == nullptr) {
|
|
return false;
|
|
} else {
|
|
*input = Slice(q, limit - q);
|
|
return true;
|
|
}
|
|
}
|
|
|
|
const char* GetVarint64Ptr(const char* p, const char* limit, uint64_t* value) {
|
|
uint64_t result = 0;
|
|
for (uint32_t shift = 0; shift <= 63 && p < limit; shift += 7) {
|
|
uint64_t byte = *(reinterpret_cast<const unsigned char*>(p));
|
|
p++;
|
|
if (byte & 128) {
|
|
// More bytes are present
|
|
result |= ((byte & 127) << shift);
|
|
} else {
|
|
result |= (byte << shift);
|
|
*value = result;
|
|
return reinterpret_cast<const char*>(p);
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
bool GetVarint64(Slice* input, uint64_t* value) {
|
|
const char* p = input->data();
|
|
const char* limit = p + input->size();
|
|
const char* q = GetVarint64Ptr(p, limit, value);
|
|
if (q == nullptr) {
|
|
return false;
|
|
} else {
|
|
*input = Slice(q, limit - q);
|
|
return true;
|
|
}
|
|
}
|
|
|
|
const char* GetLengthPrefixedSlice(const char* p, const char* limit,
|
|
Slice* result) {
|
|
uint32_t len;
|
|
p = GetVarint32Ptr(p, limit, &len);
|
|
if (p == nullptr) return nullptr;
|
|
if (p + len > limit) return nullptr;
|
|
*result = Slice(p, len);
|
|
return p + len;
|
|
}
|
|
|
|
bool GetLengthPrefixedSlice(Slice* input, Slice* result) {
|
|
uint32_t len;
|
|
if (GetVarint32(input, &len) && input->size() >= len) {
|
|
*result = Slice(input->data(), len);
|
|
input->remove_prefix(len);
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
} // namespace leveldb
|