Eric Wang
42d00a80cc
rm redundant code: SetNextFile has already been called before in this function
2021-12-05 11:44:55 +08:00
Victor Costan
e426c83e88
Merge pull request #941 from pmmp:no-handle-inheritance
...
PiperOrigin-RevId: 412997201
2021-11-30 00:09:27 +00:00
Victor Costan
6124f47490
Merge pull request #951 from philix:no_pthread
...
PiperOrigin-RevId: 412965575
2021-11-29 21:45:09 +00:00
Felipe Oliveira Carvalho
dd6658754f
Remove <pthread.h> include and find_package() from build files
2021-11-28 20:59:14 +01:00
xiong-ang
d7da5d9d35
fix some trifling points
2021-10-22 18:00:57 +08:00
Dylan K. Taylor
68d14a723a
Prevent handle used for LOG from being inherited by subprocesses
...
I recently encountered a problem with this because Windows doesn't allow
files to be deleted when there's open handles to them.
Other files opened by leveldb are not affected because by and large they
are using CreateFileA, which does not allow inheritance when
lpSecurityAttributes is null (ref:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea )
However, fopen() _does_ allow inheritance, and it needs to be expressly
disabled.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160
2021-10-09 16:22:08 +01:00
leveldb Team
c5d5174a66
Get env_posix.cc building under Fuchsia.
...
PiperOrigin-RevId: 395824737
2021-09-12 14:12:56 +00:00
zzt
11aafab31f
Fix version_set.cc comments typo
...
Fix typo of comment of FindLargestKey function
2021-09-03 11:18:31 +08:00
Victor Costan
5783a79309
Switch CI to GitHub Actions.
...
PiperOrigin-RevId: 394542401
2021-09-02 21:33:50 +00:00
ehds
54340b4a10
Fix comments position
2021-08-08 22:24:37 +08:00
leveldb Team
8e62cc5124
Remove the /
prefix from the recovery_test test file to prevent a double /
.
...
PiperOrigin-RevId: 388341429
2021-08-03 01:12:08 +00:00
wineway
8949158f5d
fixed random access file exhaust random mmap file use wrong limit count
2021-07-01 20:52:01 +08:00
Victor Costan
5d94ad4d95
Update Travis CI config.
...
Xcode (drives macOS image) : 12.2 => 12.5
Clang : 10 => 12
GCC : 10 => 11
PiperOrigin-RevId: 375582717
2021-05-25 01:40:12 +00:00
Victor Costan
c7a0fa28a4
Merge pull request #906 from pwnall/third-party-bump
...
Roll third-party dependencies.
2021-05-24 16:13:58 -07:00
Sanjay Ghemawat
13e3c4efc6
Fix compactions that could end up breaking a run of the same user
...
key across multiple files.
As reported in Github issue #339 , it is incorrect to split the
same user key across multiple compacted files since it causes
tombstones/newer-versions to be dropped, thereby exposing obsolete
data. There was a fix for #339 , but it ended up not fully fixing
the problem. (It checked for boundary problems in the first level
being compacted, but not the second). This problem was revealed
by Github issue 887.
We now adjust boundaries to avoid splitting user keys in both the
first level and the second level.
PiperOrigin-RevId: 374921082
2021-05-20 19:13:04 +00:00
Victor Costan
f6fe2ec561
Roll third-party dependencies.
2021-05-17 19:32:29 -07:00
LazyWolfLin
3806fbc23c
Small fix.
...
Use function instead of original expression.
2021-05-11 22:56:37 +08:00
ehds
dbf24d9a0c
Make table cache non-copyable
2021-05-08 13:48:39 +08:00
mwish
1ca4f5b466
[Init] initial commit
2021-05-02 14:16:51 +08:00
Raynol Menezes
f6d094e994
Update log_reader.h
2021-04-16 13:00:59 +05:30
mayingchun
e2ad7dad54
delete an unnecessary forward declaration
2021-04-05 13:58:20 +08:00
Jayice
9e8500518f
fix typo in port_example.h
2021-03-28 16:38:37 +08:00
Victor Costan
f57513a1d6
Merge pull request #881 from firebase:apple-toolchain-fixes
...
PiperOrigin-RevId: 360972284
2021-03-04 20:35:18 +00:00
Paul Beusterien
24bcf7f7ce
Don't include C++ headers in extern C
2021-03-03 17:53:26 -08:00
Chris Mumford
99b3c03b32
Change version to 1.23.
...
PiperOrigin-RevId: 359111035
2021-02-23 12:54:37 -08:00
Chris Mumford
37aaf2fccd
Fix fprintf format string.
...
Using %zu for size_t instead of %ld.
PiperOrigin-RevId: 357976882
2021-02-17 10:25:15 -08:00
Chris Mumford
2a47801868
Use partial path to benchmark/benchmark.h.
...
Using the partial path offers more flexibility to projects which
may checkout google/benchmark to a different location.
PiperOrigin-RevId: 357819911
2021-02-16 16:51:09 -08:00
Victor Costan
4a919ea4f7
IWYU fixes in db/c.cc.
...
Fixes https://github.com/google/leveldb/issues/872
PiperOrigin-RevId: 353657701
2021-01-25 17:18:22 +00:00
Victor Costan
1998c0ef15
Fix build errors.
...
PiperOrigin-RevId: 351442409
2021-01-12 21:58:19 +00:00
leveldb Team
8f1861462b
Sync MANIFEST before closing in db_impl when creating a new DB.
...
Add logging with debugging information when failing to load a version set.
PiperOrigin-RevId: 351432332
2021-01-12 21:58:08 +00:00
leveldb Team
8cce47e450
Optimize leveldb block seeks to utilize the current iterator location.
...
This is beneficial when iterators are reused and seeks are not random
but increasing. It is additionally beneficial with larger block sizes and keys with common prefixes.
Add a benchmark "seekordered" to db_bench that reuses iterators across
increasing seeks. Add support to the benchmark to count comparisons made and to support common key prefix length. Change benchmark random seeds to be reproducible for entire benchmark suite executions but unique for threads in different benchmarks runs. This changes a benchmark suite of readrandom,seekrandom from having a 100% found ratio as previously it had the same seed used for fillrandom.
./db_bench --benchmarks=fillrandom,compact,seekordered --block_size=262144 --comparisons=1 --key_prefix=100
without this change (though with benchmark changes):
seekrandom : 55.309 micros/op; (631820 of 1000000 found)
Comparisons: 27001049
seekordered : 1.732 micros/op; (631882 of 1000000 found)
Comparisons: 26998402
with this change:
seekrandom : 55.866 micros/op; (631820 of 1000000 found)
Comparisons: 26952143
seekordered : 1.686 micros/op; (631882 of 1000000 found)
Comparisons: 25549369
For ordered seeking, this is a reduction of 5% comparisons and a 3% speedup. For random seeking (with single use iterators) the comparisons and speed are less than 1% and likely noise.
PiperOrigin-RevId: 351149832
2021-01-11 15:41:38 +00:00
Victor Costan
fdc8f72895
Merge pull request #862 from rex4539:https
...
PiperOrigin-RevId: 349711809
2021-01-01 09:32:07 +00:00
Dimitris Apostolou
532be85306
Fix insecure links
2020-12-19 20:07:38 +02:00
Victor Costan
6721eda0b4
Update Travis CI config.
...
PiperOrigin-RevId: 347391876
2020-12-14 08:37:35 -08:00
Victor Costan
295ce1336f
Merge pull request #855 from cmumford/submodule-fix
...
Fixup for adding the third_party/benchmark submodule.
2020-11-30 16:37:05 -08:00
Chris Mumford
c3b52f7db6
Fixup for adding the third_party/benchmark submodule.
2020-11-30 16:26:16 -08:00
Chris Mumford
28df52115d
Merge pull request #853 from cmumford:benchmark
...
PiperOrigin-RevId: 344909677
2020-11-30 16:16:39 -08:00
Chris Mumford
2dcbd4a2c5
Merge pull request #854 from cmumford:printf-fix
...
PiperOrigin-RevId: 344871226
2020-11-30 16:16:25 -08:00
Chris Mumford
b754fdca72
Fixed fprintf of 64-bit value.
2020-11-30 10:48:17 -08:00
Chris Mumford
37d36c92f8
Added google/benchmark submodule.
2020-11-30 10:47:15 -08:00
Sanjay Ghemawat
2802398c94
Fix bug in filter policy documentation example.
...
PiperOrigin-RevId: 344817715
2020-11-30 09:11:08 -08:00
leveldb Team
99ab4730d6
Use external benchmark API header
...
PiperOrigin-RevId: 339310928
2020-11-30 09:10:59 -08:00
leveldb Team
ed781070b4
Internal test cleanup
...
PiperOrigin-RevId: 339287832
2020-11-30 09:10:46 -08:00
leveldb Team
b7d3023269
Internal cleanup migrating StatusOr.
...
PiperOrigin-RevId: 329720018
2020-10-07 21:15:26 +00:00
Chris Mumford
1454924aac
Merge pull request #822 from jl0x61:bugFix
...
PiperOrigin-RevId: 321372819
2020-07-15 09:20:04 -07:00
jl0x61
1754c12c54
update index.md
...
remove return value of GetApproximateSizes in index.md
2020-07-14 19:32:03 +08:00
Victor Costan
c46e79c760
Merge pull request #819 from wzk784533:master
...
PiperOrigin-RevId: 321000544
2020-07-13 19:14:04 +00:00
wzk784533
28602d3625
avoid unnecessary memory copy
2020-07-11 13:44:11 +08:00
Victor Costan
5bd5f0f67a
Merge pull request #798 from lntotk:master
...
PiperOrigin-RevId: 309738404
2020-05-04 22:47:40 +00:00
Victor Costan
23b6337f69
Fix Travis CI build.
...
PiperOrigin-RevId: 309138195
2020-04-30 01:21:01 +00:00