fix: updating release draft status (#316 )

chore(deps): bump actions/setup-node in the github-actions group (#597 )
Bumps the github-actions group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 4.2.0 to 4.3.0 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](1d0ff469b7...cdca7365b2) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-10 11:05:20 -04:00 · 2025-04-10 10:58:31 -04:00 · 2025-04-10 10:58:19 -04:00 · 2025-04-10 10:56:56 -04:00 · 2025-04-10 10:56:01 -04:00 · 2025-04-08 10:06:39 -04:00
19 changed files with 2150 additions and 4646 deletions
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@ -1,14 +1,33 @@
 version: 2
 updates:
- package-ecosystem: npm
-  directory: "/"
-  schedule:
-    interval: weekly
-  ignore:
-  - dependency-name: node-fetch
-    versions:
-    - ">=3.0.0"
- package-ecosystem: github-actions
-  directory: "/"
-  schedule:
-    interval: weekly
+  - package-ecosystem: npm
+    directory: "/"
+    schedule:
+      interval: weekly
+    groups:
+      npm:
+        patterns:
+          - "*"
+    ignore:
+      - dependency-name: node-fetch
+        versions:
+          - ">=3.0.0"
+      # ignore mime and @types/mime per https://github.com/softprops/action-gh-release/pull/475
+      - dependency-name: mime
+        versions:
+          - ">=4.0.0"
+      - dependency-name: "@types/mime"
+        versions:
+          - ">=4.0.0"
+    commit-message:
+      prefix: "chore(deps)"
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: weekly
+    groups:
+      github-actions:
+        patterns:
+          - "*"
+    commit-message:
+      prefix: "chore(deps)"
--- a/.github/release.yml
+++ b/.github/release.yml
@ -0,0 +1,22 @@
+changelog:
+  exclude:
+    labels:
+      - ignore-for-release
+      - github-actions
+    authors:
+      - octocat
+      - renovate[bot]
+  categories:
+    - title: Breaking Changes 🛠
+      labels:
+        - breaking-change
+    - title: Exciting New Features 🎉
+      labels:
+        - enhancement
+        - feature
+    - title: Bug fixes 🐛
+      labels:
+        - bug
+    - title: Other Changes 🔄
+      labels:
+        - "*"
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@ -1,14 +1,20 @@
-name: Main
+name: main

-on: [pull_request, push]
+on:
+  push:
+  pull_request:

 jobs:
  build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
    steps:
-      # https://github.com/actions/checkout
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+
+      - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
+        with:
+          node-version-file: ".tool-versions"
+          cache: "npm"
+
      - name: Install
        run: npm ci
      - name: Build
--- a/.nvmrc
+++ b/.nvmrc
@ -1 +0,0 @@
-20.11.1
--- a/.tool-versions
+++ b/.tool-versions
@ -0,0 +1 @@
+nodejs 20.15.1
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -1,3 +1,88 @@
+## 2.2.1
+
+## What's Changed
+
+### Bug fixes 🐛
+
+* fix: big file uploads by @xen0n in https://github.com/softprops/action-gh-release/pull/562
+
+### Other Changes 🔄
+* chore(deps): bump @types/node from 22.10.1 to 22.10.2 by @dependabot in https://github.com/softprops/action-gh-release/pull/559
+* chore(deps): bump @types/node from 22.10.2 to 22.10.5 by @dependabot in https://github.com/softprops/action-gh-release/pull/569
+* chore: update error and warning messages for not matching files in files field by @ytimocin in https://github.com/softprops/action-gh-release/pull/568
+
+## 2.2.0
+
+## What's Changed
+
+### Exciting New Features 🎉
+
+* feat: read the release assets asynchronously by @xen0n in https://github.com/softprops/action-gh-release/pull/552
+
+### Bug fixes 🐛
+
+* fix(docs): clarify the default for tag_name by @alexeagle in https://github.com/softprops/action-gh-release/pull/544
+
+### Other Changes 🔄
+
+* chore(deps): bump typescript from 5.6.3 to 5.7.2 by @dependabot in https://github.com/softprops/action-gh-release/pull/548
+* chore(deps): bump @types/node from 22.9.0 to 22.9.4 by @dependabot in https://github.com/softprops/action-gh-release/pull/547
+* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 by @dependabot in https://github.com/softprops/action-gh-release/pull/545
+* chore(deps): bump @vercel/ncc from 0.38.2 to 0.38.3 by @dependabot in https://github.com/softprops/action-gh-release/pull/543
+* chore(deps): bump prettier from 3.3.3 to 3.4.1 by @dependabot in https://github.com/softprops/action-gh-release/pull/550
+* chore(deps): bump @types/node from 22.9.4 to 22.10.1 by @dependabot in https://github.com/softprops/action-gh-release/pull/551
+* chore(deps): bump prettier from 3.4.1 to 3.4.2 by @dependabot in https://github.com/softprops/action-gh-release/pull/554
+
+## 2.1.0
+
+## What's Changed
+
+### Exciting New Features 🎉
+* feat: add support for release assets with multiple spaces within the name by @dukhine in https://github.com/softprops/action-gh-release/pull/518
+* feat: preserve upload order by @richarddd in https://github.com/softprops/action-gh-release/pull/500
+
+### Other Changes 🔄
+* chore(deps): bump @types/node from 22.8.2 to 22.8.7 by @dependabot in https://github.com/softprops/action-gh-release/pull/539
+
+## 2.0.9
+
+- maintenance release with updated dependencies
+
+## 2.0.8
+
+### Other Changes 🔄
+* chore(deps): bump prettier from 2.8.0 to 3.3.3 by @dependabot in https://github.com/softprops/action-gh-release/pull/480
+* chore(deps): bump @types/node from 20.14.9 to 20.14.11 by @dependabot in https://github.com/softprops/action-gh-release/pull/483
+* chore(deps): bump @octokit/plugin-throttling from 9.3.0 to 9.3.1 by @dependabot in https://github.com/softprops/action-gh-release/pull/484
+* chore(deps): bump glob from 10.4.2 to 11.0.0 by @dependabot in https://github.com/softprops/action-gh-release/pull/477
+* refactor: write jest config in ts by @chenrui333 in https://github.com/softprops/action-gh-release/pull/485
+* chore(deps): bump @actions/github from 5.1.1 to 6.0.0 by @dependabot in https://github.com/softprops/action-gh-release/pull/470
+
+## 2.0.7
+
+### Bug fixes 🐛
+
+* Fix missing update release body by @FirelightFlagboy in https://github.com/softprops/action-gh-release/pull/365
+
+### Other Changes 🔄
+
+* Bump @octokit/plugin-retry from 4.0.3 to 7.1.1 by @dependabot in https://github.com/softprops/action-gh-release/pull/443
+* Bump typescript from 4.9.5 to 5.5.2 by @dependabot in https://github.com/softprops/action-gh-release/pull/467
+* Bump @types/node from 20.14.6 to 20.14.8 by @dependabot in https://github.com/softprops/action-gh-release/pull/469
+* Bump @types/node from 20.14.8 to 20.14.9 by @dependabot in https://github.com/softprops/action-gh-release/pull/473
+* Bump typescript from 5.5.2 to 5.5.3 by @dependabot in https://github.com/softprops/action-gh-release/pull/472
+* Bump ts-jest from 29.1.5 to 29.2.2 by @dependabot in https://github.com/softprops/action-gh-release/pull/479
+* docs: document that existing releases are updated by @jvanbruegge in https://github.com/softprops/action-gh-release/pull/474
+
+## 2.0.6
+
+- maintenance release with updated dependencies
+
+## 2.0.5
+
+- Factor in file names with spaces when upserting files [#446](https://github.com/softprops/action-gh-release/pull/446) via [@MystiPanda](https://github.com/MystiPanda)
+- Improvements to error handling [#449](https://github.com/softprops/action-gh-release/pull/449) via [@till](https://github.com/till)
+
 ## 2.0.4

 - Minor follow up to [#417](https://github.com/softprops/action-gh-release/pull/417). [#425](https://github.com/softprops/action-gh-release/pull/425)
--- a/README.md
+++ b/README.md
@ -21,6 +21,16 @@

 <br />

+- [🤸 Usage](#-usage)
+  - [🚥 Limit releases to pushes to tags](#-limit-releases-to-pushes-to-tags)
+  - [⬆️ Uploading release assets](#️-uploading-release-assets)
+  - [📝 External release notes](#-external-release-notes)
+  - [💅 Customizing](#-customizing)
+    - [inputs](#inputs)
+    - [outputs](#outputs)
+    - [environment variables](#environment-variables)
+  - [Permissions](#permissions)
+
 ## 🤸 Usage

 ### 🚥 Limit releases to pushes to tags
@ -44,7 +54,7 @@ jobs:
        uses: actions/checkout@v4
      - name: Release
        uses: softprops/action-gh-release@v2
-        if: startsWith(github.ref, 'refs/tags/')
+        if: github.ref_type == 'tag'
 ```

 You can also use push config tag filter
@ -75,6 +85,7 @@ GitHub release and all are optional.
 A common case for GitHub releases is to upload your binary after its been validated and packaged.
 Use the `with.files` input to declare a newline-delimited list of glob expressions matching the files
 you wish to upload to GitHub releases. If you'd like you can just list the files by name directly.
+If a tag already has a GitHub release, the existing release will be updated with the release assets.

 Below is an example of uploading a single asset named `Release.txt`

@ -95,7 +106,7 @@ jobs:
        run: cat Release.txt
      - name: Release
        uses: softprops/action-gh-release@v2
-        if: startsWith(github.ref, 'refs/tags/')
+        if: github.ref_type == 'tag'
        with:
          files: Release.txt
 ```
@ -119,7 +130,7 @@ jobs:
        run: cat Release.txt
      - name: Release
        uses: softprops/action-gh-release@v2
-        if: startsWith(github.ref, 'refs/tags/')
+        if: github.ref_type == 'tag'
        with:
          files: |
            Release.txt
@ -151,14 +162,13 @@ jobs:
        run: echo "# Good things have arrived" > ${{ github.workspace }}-CHANGELOG.txt
      - name: Release
        uses: softprops/action-gh-release@v2
-        if: startsWith(github.ref, 'refs/tags/')
+        if: github.ref_type == 'tag'
        with:
          body_path: ${{ github.workspace }}-CHANGELOG.txt
+          repository: my_gh_org/my_gh_repo
          # note you'll typically need to create a personal access token
          # with permissions to create releases in the other repo
          token: ${{ secrets.CUSTOM_GITHUB_TOKEN }}
-        env:
-          GITHUB_REPOSITORY: my_gh_org/my_gh_repo
 ```

 ### 💅 Customizing
@ -173,9 +183,10 @@ The following are optional as `step.with` keys
 | `body_path`                | String  | Path to load text communicating notable changes in this release                                                                                                                                                                                                                                                                                                                                                                                 |
 | `draft`                    | Boolean | Indicator of whether or not this release is a draft                                                                                                                                                                                                                                                                                                                                                                                             |
 | `prerelease`               | Boolean | Indicator of whether or not is a prerelease                                                                                                                                                                                                                                                                                                                                                                                                     |
+| `preserve_order`           | Boolean | Indicator of whether order of files should be preserved when uploading assets                                                                                                                                                                                                                                                                                                                                                                   |
 | `files`                    | String  | Newline-delimited globs of paths to assets to upload for release                                                                                                                                                                                                                                                                                                                                                                                |
 | `name`                     | String  | Name of the release. defaults to tag name                                                                                                                                                                                                                                                                                                                                                                                                       |
-| `tag_name`                 | String  | Name of a tag. defaults to `github.ref`                                                                                                                                                                                                                                                                                                                                                                                                         |
+| `tag_name`                 | String  | Name of a tag. defaults to `github.ref_name`                                                                                                                                                                                                                                                                                                                                                                                                         |
 | `fail_on_unmatched_files`  | Boolean | Indicator of whether to fail if any of the `files` globs match nothing                                                                                                                                                                                                                                                                                                                                                                          |
 | `repository`               | String  | Name of a target repository in `<owner>/<repo>` format. Defaults to GITHUB_REPOSITORY env variable                                                                                                                                                                                                                                                                                                                                              |
 | `target_commitish`         | String  | Commitish value that determines where the Git tag is created from. Can be any branch or commit SHA. Defaults to repository default branch.                                                                                                                                                                                                                                                                                                      |
--- a/tests/github.test.ts
+++ b/tests/github.test.ts
@ -1,6 +1,5 @@
-//import * as assert from "assert";
-//const assert = require('assert');
 import * as assert from "assert";
+import { text } from "stream/consumers";
 import { mimeOrDefault, asset } from "../src/github";

 describe("github", () => {
@ -15,11 +14,10 @@ describe("github", () => {

  describe("asset", () => {
    it("derives asset info from a path", async () => {
-      const { name, mime, size, data } = asset("tests/data/foo/bar.txt");
+      const { name, mime, size } = asset("tests/data/foo/bar.txt");
      assert.equal(name, "bar.txt");
      assert.equal(mime, "text/plain");
      assert.equal(size, 10);
-      assert.equal(data.toString(), "release me");
    });
  });
 });
--- a/tests/util.test.ts
+++ b/tests/util.test.ts
@ -6,6 +6,7 @@ import {
  parseInputFiles,
  unmatchedPatterns,
  uploadUrl,
+  alignAssetName,
 } from "../src/util";
 import * as assert from "assert";

@ -14,9 +15,9 @@ describe("util", () => {
    it("strips template", () => {
      assert.equal(
        uploadUrl(
-          "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets{?name,label}"
+          "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets{?name,label}",
        ),
-        "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets"
+        "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets",
      );
    });
  });
@ -30,7 +31,7 @@ describe("util", () => {
    it("parses newline and comma-delimited (and then some)", () => {
      assert.deepStrictEqual(
        parseInputFiles("foo,bar\nbaz,boom,\n\ndoom,loom "),
-        ["foo", "bar", "baz", "boom", "doom", "loom"]
+        ["foo", "bar", "baz", "boom", "doom", "loom"],
      );
    });
  });
@ -46,6 +47,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: false,
          input_prerelease: false,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -53,7 +55,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        })
+        }),
      );
    });
    it("uses input body path", () => {
@ -67,6 +69,7 @@ describe("util", () => {
          input_body_path: "__tests__/release.txt",
          input_draft: false,
          input_prerelease: false,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -74,7 +77,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        })
+        }),
      );
    });
    it("defaults to body path when both body and body path are provided", () => {
@ -88,6 +91,7 @@ describe("util", () => {
          input_body_path: "__tests__/release.txt",
          input_draft: false,
          input_prerelease: false,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -95,7 +99,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        })
+        }),
      );
    });
  });
@ -121,6 +125,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: undefined,
          input_prerelease: undefined,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -129,7 +134,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });

@ -148,6 +153,7 @@ describe("util", () => {
          input_draft: undefined,
          input_prerelease: undefined,
          input_files: [],
+          input_preserve_order: undefined,
          input_name: undefined,
          input_tag_name: undefined,
          input_fail_on_unmatched_files: false,
@ -155,7 +161,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });
    it("supports discussion category names", () => {
@ -173,6 +179,7 @@ describe("util", () => {
          input_draft: undefined,
          input_prerelease: undefined,
          input_files: [],
+          input_preserve_order: undefined,
          input_name: undefined,
          input_tag_name: undefined,
          input_fail_on_unmatched_files: false,
@ -180,7 +187,7 @@ describe("util", () => {
          input_discussion_category_name: "releases",
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });

@ -198,6 +205,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: undefined,
          input_prerelease: undefined,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -206,7 +214,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: true,
          input_make_latest: undefined,
-        }
+        },
      );
    });

@ -215,6 +223,7 @@ describe("util", () => {
        parseConfig({
          INPUT_DRAFT: "false",
          INPUT_PRERELEASE: "true",
+          INPUT_PRESERVE_ORDER: "true",
          GITHUB_TOKEN: "env-token",
          INPUT_TOKEN: "input-token",
        }),
@ -227,6 +236,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: false,
          input_prerelease: true,
+          input_preserve_order: true,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -235,7 +245,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });
    it("uses input token as the source of GITHUB_TOKEN by default", () => {
@ -254,6 +264,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: false,
          input_prerelease: true,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -262,7 +273,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });
    it("parses basic config with draft and prerelease", () => {
@ -280,6 +291,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: false,
          input_prerelease: true,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -288,7 +300,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });
    it("parses basic config where make_latest is passed", () => {
@ -305,6 +317,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: undefined,
          input_prerelease: undefined,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -313,7 +326,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: "false",
-        }
+        },
      );
    });
    it("parses basic config with append_body", () => {
@ -330,6 +343,7 @@ describe("util", () => {
          input_body_path: undefined,
          input_draft: undefined,
          input_prerelease: undefined,
+          input_preserve_order: undefined,
          input_files: [],
          input_name: undefined,
          input_tag_name: undefined,
@ -338,7 +352,7 @@ describe("util", () => {
          input_discussion_category_name: undefined,
          input_generate_release_notes: false,
          input_make_latest: undefined,
-        }
+        },
      );
    });
  });
@ -355,7 +369,7 @@ describe("util", () => {
    it("resolves files given a set of paths", async () => {
      assert.deepStrictEqual(
        paths(["tests/data/**/*", "tests/data/does/not/exist/*"]),
-        ["tests/data/foo/bar.txt"]
+        ["tests/data/foo/bar.txt"],
      );
    });
  });
@ -364,8 +378,24 @@ describe("util", () => {
    it("returns the patterns that don't match any files", async () => {
      assert.deepStrictEqual(
        unmatchedPatterns(["tests/data/**/*", "tests/data/does/not/exist/*"]),
-        ["tests/data/does/not/exist/*"]
+        ["tests/data/does/not/exist/*"],
      );
    });
  });
+
+  describe("replaceSpacesWithDots", () => {
+    it("replaces all spaces with dots", () => {
+      expect(alignAssetName("John Doe.bla")).toBe("John.Doe.bla");
+    });
+
+    it("handles names with multiple spaces", () => {
+      expect(alignAssetName("John William Doe.bla")).toBe(
+        "John.William.Doe.bla",
+      );
+    });
+
+    it("returns the same string if there are no spaces", () => {
+      expect(alignAssetName("JohnDoe")).toBe("JohnDoe");
+    });
+  });
 });
--- a/action.yml
+++ b/action.yml
@ -13,7 +13,7 @@ inputs:
    description: "Gives the release a custom name. Defaults to tag name"
    required: false
  tag_name:
-    description: "Gives a tag name. Defaults to github.GITHUB_REF"
+    description: "Gives a tag name. Defaults to github.ref_name"
    required: false
  draft:
    description: "Creates a draft release. Defaults to false"
@ -21,6 +21,9 @@ inputs:
  prerelease:
    description: "Identify the release as a prerelease. Defaults to false"
    required: false
+  preserve_order:
+    description: "Preserver the order of the artifacts when uploading"
+    required: false
  files:
    description: "Newline-delimited list of path globs for asset files to upload"
    required: false
@ -50,7 +53,7 @@ inputs:
    description: "Specifies whether this release should be set as the latest release for the repository. Drafts and prereleases cannot be set as latest. Can be `true`, `false`, or `legacy`. Uses GitHub api default if not provided"
    required: false
 env:
-  "GITHUB_TOKEN": "As provided by Github Actions"
+  GITHUB_TOKEN: "As provided by Github Actions"
 outputs:
  url:
    description: "URL to the Release HTML Page"
--- a/dist/index.js
+++ b/dist/index.js
--- a/jest.config.js
+++ b/jest.config.js
@ -1,11 +0,0 @@
-module.exports = {
-  clearMocks: true,
-  moduleFileExtensions: ['js', 'ts'],
-  testEnvironment: 'node',
-  testMatch: ['**/*.test.ts'],
-  testRunner: 'jest-circus/runner',
-  transform: {
-    '^.+\\.ts$': 'ts-jest'
-  },
-  verbose: true
-}
--- a/jest.config.ts
+++ b/jest.config.ts
@ -0,0 +1,16 @@
+import type { JestConfigWithTsJest } from 'ts-jest';
+
+const config: JestConfigWithTsJest = {
+  preset: 'ts-jest/presets/default-esm',
+  clearMocks: true,
+  moduleFileExtensions: ['js', 'ts'],
+  testEnvironment: 'node',
+  testMatch: ['**/*.test.ts'],
+  testRunner: 'jest-circus/runner',
+  transform: {
+    '^.+\\.ts$': 'ts-jest',
+  },
+  verbose: true,
+};
+
+export default config;
--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@ -1,11 +1,12 @@
 {
  "name": "action-gh-release",
-  "version": "2.0.3",
+  "version": "2.2.1",
  "private": true,
  "description": "GitHub Action for creating GitHub Releases",
  "main": "lib/main.js",
  "scripts": {
    "build": "ncc build src/main.ts --minify",
+    "build-debug": "ncc build src/main.ts --v8-cache --source-map",
    "test": "jest",
    "fmt": "prettier --write \"src/**/*.ts\" \"__tests__/**/*.ts\"",
    "fmtcheck": "prettier --check \"src/**/*.ts\" \"__tests__/**/*.ts\"",
@ -20,24 +21,25 @@
  ],
  "author": "softprops",
  "dependencies": {
-    "@actions/core": "^1.10.0",
-    "@actions/github": "^5.1.1",
-    "@octokit/plugin-retry": "^4.0.3",
-    "@octokit/plugin-throttling": "^4.3.2",
-    "glob": "^8.0.3",
+    "@actions/core": "^1.11.1",
+    "@actions/github": "^6.0.0",
+    "@octokit/plugin-retry": "^7.2.0",
+    "@octokit/plugin-throttling": "^9.6.1",
+    "glob": "^11.0.1",
    "mime": "^3.0.0"
  },
  "devDependencies": {
-    "@types/glob": "^8.0.0",
-    "@types/jest": "^29.2.3",
+    "@types/glob": "^8.1.0",
+    "@types/jest": "^29.5.14",
    "@types/mime": "^3.0.1",
-    "@types/node": "^18.11.9",
-    "@vercel/ncc": "^0.34.0",
+    "@types/node": "^22.14.0",
+    "@vercel/ncc": "^0.38.3",
    "jest": "^29.3.1",
    "jest-circus": "^29.3.1",
-    "prettier": "2.8.0",
-    "ts-jest": "^29.0.3",
-    "typescript": "^4.9.3",
+    "prettier": "3.5.3",
+    "ts-jest": "^29.3.1",
+    "ts-node": "^10.9.2",
+    "typescript": "^5.8.3",
    "typescript-formatter": "^7.2.2"
  }
 }
--- a/src/github.ts
+++ b/src/github.ts
@ -1,6 +1,7 @@
 import { GitHub } from "@actions/github/lib/utils";
-import { Config, isTag, releaseBody } from "./util";
-import { statSync, readFileSync } from "fs";
+import { Config, isTag, releaseBody, alignAssetName } from "./util";
+import { statSync } from "fs";
+import { open } from "fs/promises";
 import { getType } from "mime";
 import { basename } from "path";

@ -10,7 +11,6 @@ export interface ReleaseAsset {
  name: string;
  mime: string;
  size: number;
-  data: Buffer;
 }

 export interface Release {
@ -44,7 +44,7 @@ export interface Releaser {
    target_commitish: string | undefined;
    discussion_category_name: string | undefined;
    generate_release_notes: boolean | undefined;
-    make_latest: string | undefined;
+    make_latest: "true" | "false" | "legacy" | undefined;
  }): Promise<{ data: Release }>;

  updateRelease(params: {
@ -59,7 +59,7 @@ export interface Releaser {
    prerelease: boolean | undefined;
    discussion_category_name: string | undefined;
    generate_release_notes: boolean | undefined;
-    make_latest: string | undefined;
+    make_latest: "true" | "false" | "legacy" | undefined;
  }): Promise<{ data: Release }>;

  allReleases(params: {
@ -93,8 +93,15 @@ export class GitHubReleaser implements Releaser {
    target_commitish: string | undefined;
    discussion_category_name: string | undefined;
    generate_release_notes: boolean | undefined;
-    make_latest: string | undefined;
+    make_latest: "true" | "false" | "legacy" | undefined;
  }): Promise<{ data: Release }> {
+    if (
+      typeof params.make_latest === "string" &&
+      !["true", "false", "legacy"].includes(params.make_latest)
+    ) {
+      params.make_latest = undefined;
+    }
+
    return this.github.rest.repos.createRelease(params);
  }

@ -110,8 +117,15 @@ export class GitHubReleaser implements Releaser {
    prerelease: boolean | undefined;
    discussion_category_name: string | undefined;
    generate_release_notes: boolean | undefined;
-    make_latest: string | undefined;
+    make_latest: "true" | "false" | "legacy" | undefined;
  }): Promise<{ data: Release }> {
+    if (
+      typeof params.make_latest === "string" &&
+      !["true", "false", "legacy"].includes(params.make_latest)
+    ) {
+      params.make_latest = undefined;
+    }
+
    return this.github.rest.repos.updateRelease(params);
  }

@ -121,7 +135,7 @@ export class GitHubReleaser implements Releaser {
  }): AsyncIterableIterator<{ data: Release[] }> {
    const updatedParams = { per_page: 100, ...params };
    return this.github.paginate.iterator(
-      this.github.rest.repos.listReleases.endpoint.merge(updatedParams)
+      this.github.rest.repos.listReleases.endpoint.merge(updatedParams),
    );
  }
 }
@ -131,7 +145,6 @@ export const asset = (path: string): ReleaseAsset => {
    name: basename(path),
    mime: mimeOrDefault(path),
    size: statSync(path).size,
-    data: readFileSync(path),
  };
 };

@ -144,12 +157,15 @@ export const upload = async (
  github: GitHub,
  url: string,
  path: string,
-  currentAssets: Array<{ id: number; name: string }>
+  currentAssets: Array<{ id: number; name: string }>,
 ): Promise<any> => {
  const [owner, repo] = config.github_repository.split("/");
-  const { name, size, mime, data: body } = asset(path);
+  const { name, mime, size } = asset(path);
  const currentAsset = currentAssets.find(
-    ({ name: currentName }) => currentName == name
+    // note: GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods. The "List release assets" endpoint lists the renamed filenames.
+    // due to this renaming we need to be mindful when we compare the file name we're uploading with a name github may already have rewritten for logical comparison
+    // see https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset
+    ({ name: currentName }) => currentName == alignAssetName(name),
  );
  if (currentAsset) {
    console.log(`♻️ Deleting previously uploaded asset ${name}...`);
@ -162,31 +178,37 @@ export const upload = async (
  console.log(`⬆️ Uploading ${name}...`);
  const endpoint = new URL(url);
  endpoint.searchParams.append("name", name);
-  const resp = await github.request({
-    method: "POST",
-    url: endpoint.toString(),
-    headers: {
-      "content-length": `${size}`,
-      "content-type": mime,
-      authorization: `token ${config.github_token}`,
-    },
-    data: body,
-  });
-  const json = resp.data;
-  if (resp.status !== 201) {
-    throw new Error(
-      `Failed to upload release asset ${name}. received status code ${
-        resp.status
-      }\n${json.message}\n${JSON.stringify(json.errors)}`
-    );
+  const fh = await open(path);
+  try {
+    const resp = await github.request({
+      method: "POST",
+      url: endpoint.toString(),
+      headers: {
+        "content-length": `${size}`,
+        "content-type": mime,
+        authorization: `token ${config.github_token}`,
+      },
+      data: fh.readableWebStream({ type: "bytes" }),
+    });
+    const json = resp.data;
+    if (resp.status !== 201) {
+      throw new Error(
+        `Failed to upload release asset ${name}. received status code ${
+          resp.status
+        }\n${json.message}\n${JSON.stringify(json.errors)}`,
+      );
+    }
+    console.log(`✅ Uploaded ${name}`);
+    return json;
+  } finally {
+    await fh.close();
  }
-  return json;
 };

 export const release = async (
  config: Config,
  releaser: Releaser,
-  maxRetries: number = 3
+  maxRetries: number = 3,
 ): Promise<Release> => {
  if (maxRetries <= 0) {
    console.log(`❌ Too many retries. Aborting...`);
@ -203,47 +225,58 @@ export const release = async (
  const discussion_category_name = config.input_discussion_category_name;
  const generate_release_notes = config.input_generate_release_notes;
  try {
-    // you can't get a an existing draft by tag
+    // you can't get an existing draft by tag
    // so we must find one in the list of all releases
-    if (config.input_draft) {
-      for await (const response of releaser.allReleases({
-        owner,
-        repo,
-      })) {
-        let release = response.data.find((release) => release.tag_name === tag);
-        if (release) {
-          return release;
-        }
-      }
-    }
-    let existingRelease = await releaser.getReleaseByTag({
+    let _release: Release | undefined = undefined;
+    for await (const response of releaser.allReleases({
      owner,
      repo,
-      tag,
-    });
+    })) {
+      _release = response.data.find((release) => release.tag_name === tag);
+      if (_release !== undefined) {
+        break;
+      }
+    }
+    if (_release === undefined) {
+      return await createRelease(
+        tag,
+        config,
+        releaser,
+        owner,
+        repo,
+        discussion_category_name,
+        generate_release_notes,
+        maxRetries,
+      );
+    }

-    const release_id = existingRelease.data.id;
+    let existingRelease: Release = _release!;
+    console.log(
+      `Found release ${existingRelease.name} (with id=${existingRelease.id})`,
+    );
+
+    const release_id = existingRelease.id;
    let target_commitish: string;
    if (
      config.input_target_commitish &&
-      config.input_target_commitish !== existingRelease.data.target_commitish
+      config.input_target_commitish !== existingRelease.target_commitish
    ) {
      console.log(
-        `Updating commit from "${existingRelease.data.target_commitish}" to "${config.input_target_commitish}"`
+        `Updating commit from "${existingRelease.target_commitish}" to "${config.input_target_commitish}"`,
      );
      target_commitish = config.input_target_commitish;
    } else {
-      target_commitish = existingRelease.data.target_commitish;
+      target_commitish = existingRelease.target_commitish;
    }

    const tag_name = tag;
-    const name = config.input_name || existingRelease.data.name || tag;
+    const name = config.input_name || existingRelease.name || tag;
    // revisit: support a new body-concat-strategy input for accumulating
    // body parts as a release gets updated. some users will likely want this while
    // others won't previously this was duplicating content for most which
    // no one wants
    const workflowBody = releaseBody(config) || "";
-    const existingReleaseBody = existingRelease.data.body || "";
+    const existingReleaseBody = existingRelease.body || "";
    let body: string;
    if (config.input_append_body && workflowBody && existingReleaseBody) {
      body = existingReleaseBody + "\n" + workflowBody;
@ -254,11 +287,11 @@ export const release = async (
    const draft =
      config.input_draft !== undefined
        ? config.input_draft
-        : existingRelease.data.draft;
+        : existingRelease.draft;
    const prerelease =
      config.input_prerelease !== undefined
        ? config.input_prerelease
-        : existingRelease.data.prerelease;
+        : existingRelease.prerelease;

    const make_latest = config.input_make_latest;

@ -278,52 +311,87 @@ export const release = async (
    });
    return release.data;
  } catch (error) {
-    if (error.status === 404) {
-      const tag_name = tag;
-      const name = config.input_name || tag;
-      const body = releaseBody(config);
-      const draft = config.input_draft;
-      const prerelease = config.input_prerelease;
-      const target_commitish = config.input_target_commitish;
-      const make_latest = config.input_make_latest;
-      let commitMessage: string = "";
-      if (target_commitish) {
-        commitMessage = ` using commit "${target_commitish}"`;
-      }
+    if (error.status !== 404) {
      console.log(
-        `👩‍🏭 Creating new GitHub release for tag ${tag_name}${commitMessage}...`
-      );
-      try {
-        let release = await releaser.createRelease({
-          owner,
-          repo,
-          tag_name,
-          name,
-          body,
-          draft,
-          prerelease,
-          target_commitish,
-          discussion_category_name,
-          generate_release_notes,
-          make_latest,
-        });
-        return release.data;
-      } catch (error) {
-        // presume a race with competing metrix runs
-        console.log(
-          `⚠️ GitHub release failed with status: ${
-            error.status
-          }\n${JSON.stringify(error.response.data.errors)}\nretrying... (${
-            maxRetries - 1
-          } retries remaining)`
-        );
-        return release(config, releaser, maxRetries - 1);
-      }
-    } else {
-      console.log(
-        `⚠️ Unexpected error fetching GitHub release for tag ${config.github_ref}: ${error}`
+        `⚠️ Unexpected error fetching GitHub release for tag ${config.github_ref}: ${error}`,
      );
      throw error;
    }
+
+    return await createRelease(
+      tag,
+      config,
+      releaser,
+      owner,
+      repo,
+      discussion_category_name,
+      generate_release_notes,
+      maxRetries,
+    );
  }
 };
+
+async function createRelease(
+  tag: string,
+  config: Config,
+  releaser: Releaser,
+  owner: string,
+  repo: string,
+  discussion_category_name: string | undefined,
+  generate_release_notes: boolean | undefined,
+  maxRetries: number,
+) {
+  const tag_name = tag;
+  const name = config.input_name || tag;
+  const body = releaseBody(config);
+  const draft = config.input_draft;
+  const prerelease = config.input_prerelease;
+  const target_commitish = config.input_target_commitish;
+  const make_latest = config.input_make_latest;
+  let commitMessage: string = "";
+  if (target_commitish) {
+    commitMessage = ` using commit "${target_commitish}"`;
+  }
+  console.log(
+    `👩‍🏭 Creating new GitHub release for tag ${tag_name}${commitMessage}...`,
+  );
+  try {
+    let release = await releaser.createRelease({
+      owner,
+      repo,
+      tag_name,
+      name,
+      body,
+      draft,
+      prerelease,
+      target_commitish,
+      discussion_category_name,
+      generate_release_notes,
+      make_latest,
+    });
+    return release.data;
+  } catch (error) {
+    // presume a race with competing matrix runs
+    console.log(`⚠️ GitHub release failed with status: ${error.status}`);
+    console.log(`${JSON.stringify(error.response.data)}`);
+
+    switch (error.status) {
+      case 403:
+        console.log(
+          "Skip retry — your GitHub token/PAT does not have the required permission to create a release",
+        );
+        throw error;
+
+      case 404:
+        console.log("Skip retry - discussion category mismatch");
+        throw error;
+
+      case 422:
+        console.log("Skip retry - validation failed");
+        throw error;
+    }
+
+    console.log(`retrying... (${maxRetries - 1} retries remaining)`);
+    return release(config, releaser, maxRetries - 1);
+  }
+}
--- a/src/main.ts
+++ b/src/main.ts
@ -8,7 +8,6 @@ import {
 import { release, upload, GitHubReleaser } from "./github";
 import { getOctokit } from "@actions/github";
 import { setFailed, setOutput } from "@actions/core";
-import { GitHub, getOctokitOptions } from "@actions/github/lib/utils";

 import { env } from "process";

@ -46,7 +45,7 @@ async function run() {
      throttle: {
        onRateLimit: (retryAfter, options) => {
          console.warn(
-            `Request quota exhausted for request ${options.method} ${options.url}`
+            `Request quota exhausted for request ${options.method} ${options.url}`,
          );
          if (options.request.retryCount === 0) {
            // only retries once
@ -57,7 +56,7 @@ async function run() {
        onAbuseLimit: (retryAfter, options) => {
          // does not retry, only logs a warning
          console.warn(
-            `Abuse detected for request ${options.method} ${options.url}`
+            `Abuse detected for request ${options.method} ${options.url}`,
          );
        },
      },
@ -68,27 +67,38 @@ async function run() {
      const files = paths(config.input_files);
      if (files.length == 0) {
        if (config.input_fail_on_unmatched_files) {
-          throw new Error(`⚠️ ${config.input_files} not include valid file.`);
+          throw new Error(
+            `⚠️ ${config.input_files} does not include a valid file.`,
+          );
        } else {
-          console.warn(`🤔 ${config.input_files} not include valid file.`);
+          console.warn(
+            `🤔 ${config.input_files} does not include a valid file.`,
+          );
        }
      }
      const currentAssets = rel.assets;
-      const assets = await Promise.all(
-        files.map(async (path) => {
-          const json = await upload(
-            config,
-            gh,
-            uploadUrl(rel.upload_url),
-            path,
-            currentAssets
-          );
-          delete json.uploader;
-          return json;
-        })
-      ).catch((error) => {
-        throw error;
-      });
+
+      const uploadFile = async (path) => {
+        const json = await upload(
+          config,
+          gh,
+          uploadUrl(rel.upload_url),
+          path,
+          currentAssets,
+        );
+        delete json.uploader;
+        return json;
+      };
+
+      let assets;
+      if (!config.input_preserve_order) {
+        assets = await Promise.all(files.map(uploadFile));
+      } else {
+        assets = [];
+        for (const path of files) {
+          assets.push(await uploadFile(path));
+        }
+      }
      setOutput("assets", assets);
    }
    console.log(`🎉 Release ready at ${rel.html_url}`);
--- a/src/util.ts
+++ b/src/util.ts
@ -13,13 +13,14 @@ export interface Config {
  input_body_path?: string;
  input_files?: string[];
  input_draft?: boolean;
+  input_preserve_order?: boolean;
  input_prerelease?: boolean;
  input_fail_on_unmatched_files?: boolean;
  input_target_commitish?: string;
  input_discussion_category_name?: string;
  input_generate_release_notes?: boolean;
  input_append_body?: boolean;
-  input_make_latest: string | undefined;
+  input_make_latest: "true" | "false" | "legacy" | undefined;
 }

 export const uploadUrl = (url: string): string => {
@ -47,7 +48,7 @@ export const parseInputFiles = (files: string): string[] => {
        .concat(line.split(","))
        .filter((pat) => pat)
        .map((pat) => pat.trim()),
-    []
+    [],
  );
 };

@ -62,6 +63,9 @@ export const parseConfig = (env: Env): Config => {
    input_body_path: env.INPUT_BODY_PATH,
    input_files: parseInputFiles(env.INPUT_FILES || ""),
    input_draft: env.INPUT_DRAFT ? env.INPUT_DRAFT === "true" : undefined,
+    input_preserve_order: env.INPUT_PRESERVE_ORDER
+      ? env.INPUT_PRESERVE_ORDER == "true"
+      : undefined,
    input_prerelease: env.INPUT_PRERELEASE
      ? env.INPUT_PRERELEASE == "true"
      : undefined,
@ -71,16 +75,23 @@ export const parseConfig = (env: Env): Config => {
      env.INPUT_DISCUSSION_CATEGORY_NAME || undefined,
    input_generate_release_notes: env.INPUT_GENERATE_RELEASE_NOTES == "true",
    input_append_body: env.INPUT_APPEND_BODY == "true",
-    input_make_latest: env.INPUT_MAKE_LATEST
-      ? env.INPUT_MAKE_LATEST
-      : undefined,
+    input_make_latest: parseMakeLatest(env.INPUT_MAKE_LATEST),
  };
 };

+const parseMakeLatest = (
+  value: string | undefined,
+): "true" | "false" | "legacy" | undefined => {
+  if (value === "true" || value === "false" || value === "legacy") {
+    return value;
+  }
+  return undefined;
+};
+
 export const paths = (patterns: string[]): string[] => {
  return patterns.reduce((acc: string[], pattern: string): string[] => {
    return acc.concat(
-      glob.sync(pattern).filter((path) => statSync(path).isFile())
+      glob.sync(pattern).filter((path) => statSync(path).isFile()),
    );
  }, []);
 };
@ -90,7 +101,7 @@ export const unmatchedPatterns = (patterns: string[]): string[] => {
    return acc.concat(
      glob.sync(pattern).filter((path) => statSync(path).isFile()).length == 0
        ? [pattern]
-        : []
+        : [],
    );
  }, []);
 };
@ -98,3 +109,7 @@ export const unmatchedPatterns = (patterns: string[]): string[] => {
 export const isTag = (ref: string): boolean => {
  return ref.startsWith("refs/tags/");
 };
+
+export const alignAssetName = (assetName: string): string => {
+  return assetName.replace(/ /g, ".");
+};
--- a/tsconfig.json
+++ b/tsconfig.json
@ -60,5 +60,5 @@
    // "experimentalDecorators": true,        /* Enables experimental support for ES7 decorators. */
    // "emitDecoratorMetadata": true,         /* Enables experimental support for emitting type metadata for decorators. */
  },
-  "exclude": ["node_modules", "**/*.test.ts"]
-}
+  "exclude": ["node_modules", "**/*.test.ts", "jest.config.ts"]
+}