bump version and add changelog notes

CHANGELOG.md

@@ -1,3 +1,19 @@
+## 0.1.13
+
+- fix issue with multiple runs concatenating release bodies [#145](https://github.com/softprops/action-gh-release/pull/145)
+
+## 0.1.12
+
+- fix bug leading to empty strings subsituted for inputs users don't provide breaking api calls [#144](https://github.com/softprops/action-gh-release/pull/144)
+
+## 0.1.11
+
+- better error message on release create failed [#143](https://github.com/softprops/action-gh-release/pull/143)
+
+## 0.1.10
+
+- fixed error message formatting for file uploads
+
 ## 0.1.9
 
 - add support for linking release to GitHub discussion [#136](https://github.com/softprops/action-gh-release/pull/136)

__tests__/util.test.ts

@@ -11,7 +11,7 @@ import * as assert from "assert";
 
 describe("util", () => {
   describe("uploadUrl", () => {
-    it("stripts template", () => {
+    it("strips template", () => {
       assert.equal(
         uploadUrl(
           "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets{?name,label}"
@@ -95,21 +95,33 @@ describe("util", () => {
   });
   describe("parseConfig", () => {
     it("parses basic config", () => {
-      assert.deepStrictEqual(parseConfig({}), {
+      assert.deepStrictEqual(
-        github_ref: "",
+        parseConfig({
-        github_repository: "",
+          // note: inputs declared in actions.yml, even when declared not required,
-        github_token: "",
+          // are still provided by the actions runtime env as empty strings instead of
-        input_body: undefined,
+          // the normal absent env value one would expect. this breaks things
-        input_body_path: undefined,
+          // as an empty string !== undefined in terms of what we pass to the api
-        input_draft: undefined,
+          // so we cover that in a test case here to ensure undefined values are actually
-        input_prerelease: undefined,
+          // resolved as undefined and not empty strings
-        input_files: [],
+          INPUT_TARGET_COMMITISH: "",
-        input_name: undefined,
+          INPUT_DISCUSSION_CATEGORY_NAME: ""
-        input_tag_name: undefined,
+        }),
-        input_fail_on_unmatched_files: false,
+        {
-        input_target_commitish: undefined,
+          github_ref: "",
-        input_discussion_category_name: undefined
+          github_repository: "",
-      });
+          github_token: "",
+          input_body: undefined,
+          input_body_path: undefined,
+          input_draft: undefined,
+          input_prerelease: undefined,
+          input_files: [],
+          input_name: undefined,
+          input_tag_name: undefined,
+          input_fail_on_unmatched_files: false,
+          input_target_commitish: undefined,
+          input_discussion_category_name: undefined
+        }
+      );
     });
 
     it("parses basic config with commitish", () => {

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "action-gh-release",
-  "version": "0.1.8",
+  "version": "0.1.13",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "action-gh-release",
-  "version": "0.1.9",
+  "version": "0.1.13",
   "private": true,
   "description": "GitHub Action for creating GitHub Releases",
   "main": "lib/main.js",

src/github.ts

@@ -167,7 +167,9 @@ export const upload = async (
   const json = await resp.json();
   if (resp.status !== 201) {
     throw new Error(
-      "Failed to upload release asset ${name}. recieved status code ${resp.status}\n${json.message}\n${json.errors}"
+      `Failed to upload release asset ${name}. recieved status code ${
+        resp.status
+      }\n${json.message}\n${JSON.stringify(json.errors)}`
     );
   }
   return json;
@@ -227,12 +229,11 @@ export const release = async (
 
     const tag_name = tag;
     const name = config.input_name || existingRelease.data.name || tag;
-
+    // revisit: support a new body-concat-strategy input for accumulating
-    let body: string = "";
+    // body parts as a release gets updated. some users will likely want this while
-    if (existingRelease.data.body) body += existingRelease.data.body;
+    // others won't previously this was duplicating content for most which
-    let workflowBody = releaseBody(config);
+    // no one wants
-    if (existingRelease.data.body && workflowBody) body += "\n";
+    let body = releaseBody(config) || existingRelease.data.body || "";
-    if (workflowBody) body += workflowBody;
 
     const draft =
       config.input_draft !== undefined
@@ -289,7 +290,9 @@ export const release = async (
         console.log(
           `⚠️ GitHub release failed with status: ${
             error.status
-          }, retrying... (${maxRetries - 1} retries remaining)`
+          }\n${JSON.stringify(
+            error.response.data.errors
+          )}\nretrying... (${maxRetries - 1} retries remaining)`
         );
         return release(config, releaser, maxRetries - 1);
       }

src/util.ts

@@ -63,8 +63,9 @@ export const parseConfig = (env: Env): Config => {
       ? env.INPUT_PRERELEASE == "true"
       : undefined,
     input_fail_on_unmatched_files: env.INPUT_FAIL_ON_UNMATCHED_FILES == "true",
-    input_target_commitish: env.INPUT_TARGET_COMMITISH,
+    input_target_commitish: env.INPUT_TARGET_COMMITISH || undefined,
-    input_discussion_category_name: env.INPUT_DISCUSSION_CATEGORY_NAME
+    input_discussion_category_name:
+      env.INPUT_DISCUSSION_CATEGORY_NAME || undefined
   };
 };