error is of unknown structure

CHANGELOG.md

@@ -1,19 +1,3 @@
-## 0.1.14
-
-- provides an new workflow input option `generate_release_notes` which when set to true will automatically generate release notes for you based on GitHub activity [#179](https://github.com/softprops/action-gh-release/pull/179). Please see the [GitHub docs for this feature](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes) for more information
-
-## 0.1.13
-
-- fix issue with multiple runs concatenating release bodies [#145](https://github.com/softprops/action-gh-release/pull/145)
-
-## 0.1.12
-
-- fix bug leading to empty strings subsituted for inputs users don't provide breaking api calls [#144](https://github.com/softprops/action-gh-release/pull/144)
-
-## 0.1.11
-
-- better error message on release create failed [#143](https://github.com/softprops/action-gh-release/pull/143)
-
 ## 0.1.10
 
 - fixed error message formatting for file uploads

README.md

@@ -166,7 +166,7 @@ jobs:
 The following are optional as `step.with` keys
 
 | Name                       | Type    | Description                                                                                                                                                                                                                                                                                                                                                                                 |
-| -------------------------- | ------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| -------------------------- | ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `body`                     | String  | Text communicating notable changes in this release                                                                                                                                                                                                                                                                                                                                          |
 | `body_path`                | String  | Path to load text communicating notable changes in this release                                                                                                                                                                                                                                                                                                                             |
 | `draft`                    | Boolean | Indicator of whether or not this release is a draft                                                                                                                                                                                                                                                                                                                                         |
@@ -179,7 +179,6 @@ The following are optional as `step.with` keys
 | `target_commitish`         | String  | Commitish value that determines where the Git tag is created from. Can be any branch or commit SHA.                                                                                                                                                                                                                                                                                         |
 | `token`                    | String  | Secret GitHub Personal Access Token. Defaults to `${{ github.token }}`                                                                                                                                                                                                                                                                                                                      |
 | `discussion_category_name` | String  | If specified, a discussion of the specified category is created and linked to the release. The value must be a category that already exists in the repository. For more information, see ["Managing categories for discussions in your repository."](https://docs.github.com/en/discussions/managing-discussions-for-your-community/managing-categories-for-discussions-in-your-repository) |
-| `generate_release_notes`   | Boolean | Whether to automatically generate the name and body for this release. If name is specified, the specified name will be used; otherwise, a name will be automatically generated. If body is specified, the body will be pre-pended to the automatically generated notes. See the [GitHub docs for this feature](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes) for more information |
 
 💡 When providing a `body` and `body_path` at the same time, `body_path` will be
 attempted first, then falling back on `body` if the path can not be read from.
@@ -209,15 +208,4 @@ The following `step.env` keys are allowed as a fallback but deprecated in favor
 
 > **⚠️ Note:** This action was previously implemented as a Docker container, limiting its use to GitHub Actions Linux virtual environments only. With recent releases, we now support cross platform usage. You'll need to remove the `docker://` prefix in these versions
 
-### Permissions
-
-This Action requires the following permissions on the GitHub integration token:
-
-```yaml
-permissions:
-  contents: write
-```
-
-[GitHub token permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) can be set for an individual job, workflow, or for Actions as a whole.
-
 Doug Tangren (softprops) 2019

__tests__/util.test.ts

@@ -11,7 +11,7 @@ import * as assert from "assert";
 
 describe("util", () => {
   describe("uploadUrl", () => {
-    it("strips template", () => {
+    it("stripts template", () => {
       assert.equal(
         uploadUrl(
           "https://uploads.github.com/repos/octocat/Hello-World/releases/1/assets{?name,label}"
@@ -50,8 +50,7 @@ describe("util", () => {
           input_name: undefined,
           input_tag_name: undefined,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         })
       );
     });
@@ -70,8 +69,7 @@ describe("util", () => {
           input_name: undefined,
           input_tag_name: undefined,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         })
       );
     });
@@ -90,26 +88,14 @@ describe("util", () => {
           input_name: undefined,
           input_tag_name: undefined,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         })
       );
     });
   });
   describe("parseConfig", () => {
     it("parses basic config", () => {
-      assert.deepStrictEqual(
-        parseConfig({
-          // note: inputs declared in actions.yml, even when declared not required,
-          // are still provided by the actions runtime env as empty strings instead of
-          // the normal absent env value one would expect. this breaks things
-          // as an empty string !== undefined in terms of what we pass to the api
-          // so we cover that in a test case here to ensure undefined values are actually
-          // resolved as undefined and not empty strings
-          INPUT_TARGET_COMMITISH: "",
-          INPUT_DISCUSSION_CATEGORY_NAME: ""
-        }),
-        {
+      assert.deepStrictEqual(parseConfig({}), {
         github_ref: "",
         github_repository: "",
         github_token: "",
@@ -122,10 +108,8 @@ describe("util", () => {
         input_tag_name: undefined,
         input_fail_on_unmatched_files: false,
         input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
-        }
-      );
+        input_discussion_category_name: undefined
+      });
     });
 
     it("parses basic config with commitish", () => {
@@ -146,8 +130,7 @@ describe("util", () => {
           input_tag_name: undefined,
           input_fail_on_unmatched_files: false,
           input_target_commitish: "affa18ef97bc9db20076945705aba8c516139abd",
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         }
       );
     });
@@ -169,36 +152,10 @@ describe("util", () => {
           input_tag_name: undefined,
           input_fail_on_unmatched_files: false,
           input_target_commitish: undefined,
-          input_discussion_category_name: "releases",
-          input_generate_release_notes: false
+          input_discussion_category_name: "releases"
         }
       );
     });
-
-    it("supports generating release notes", () => {
-      assert.deepStrictEqual(
-        parseConfig({
-          INPUT_GENERATE_RELEASE_NOTES: "true"
-        }),
-        {
-          github_ref: "",
-          github_repository: "",
-          github_token: "",
-          input_body: undefined,
-          input_body_path: undefined,
-          input_draft: undefined,
-          input_prerelease: undefined,
-          input_files: [],
-          input_name: undefined,
-          input_tag_name: undefined,
-          input_fail_on_unmatched_files: false,
-          input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: true
-        }
-      );
-    });
-
     it("prefers GITHUB_TOKEN over token input for backwards compatibility", () => {
       assert.deepStrictEqual(
         parseConfig({
@@ -220,8 +177,7 @@ describe("util", () => {
           input_tag_name: undefined,
           input_fail_on_unmatched_files: false,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         }
       );
     });
@@ -245,8 +201,7 @@ describe("util", () => {
           input_tag_name: undefined,
           input_fail_on_unmatched_files: false,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         }
       );
     });
@@ -269,8 +224,7 @@ describe("util", () => {
           input_tag_name: undefined,
           input_fail_on_unmatched_files: false,
           input_target_commitish: undefined,
-          input_discussion_category_name: undefined,
-          input_generate_release_notes: false
+          input_discussion_category_name: undefined
         }
       );
     });

action.yml

@@ -40,9 +40,6 @@ inputs:
   discussion_category_name:
     description: "If specified, a discussion of the specified category is created and linked to the release. The value must be a category that already exists in the repository. If there is already a discussion linked to the release, this parameter is ignored."
     required: false
-  generate_release_notes:
-    description: "Whether to automatically generate the name and body for this release. If name is specified, the specified name will be used; otherwise, a name will be automatically generated. If body is specified, the body will be pre-pended to the automatically generated notes."
-    required: false
 env:
   "GITHUB_TOKEN": "As provided by Github Actions"
 outputs:

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "action-gh-release",
-  "version": "0.1.14",
+  "version": "0.1.8",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "action-gh-release",
-  "version": "0.1.14",
+  "version": "0.1.10",
   "private": true,
   "description": "GitHub Action for creating GitHub Releases",
   "main": "lib/main.js",

src/github.ts

@@ -44,7 +44,6 @@ export interface Releaser {
     prerelease: boolean | undefined;
     target_commitish: string | undefined;
     discussion_category_name: string | undefined;
-    generate_release_notes: boolean | undefined;
   }): Promise<{ data: Release }>;
 
   updateRelease(params: {
@@ -58,7 +57,6 @@ export interface Releaser {
     draft: boolean | undefined;
     prerelease: boolean | undefined;
     discussion_category_name: string | undefined;
-    generate_release_notes: boolean | undefined;
   }): Promise<{ data: Release }>;
 
   allReleases(params: {
@@ -91,7 +89,6 @@ export class GitHubReleaser implements Releaser {
     prerelease: boolean | undefined;
     target_commitish: string | undefined;
     discussion_category_name: string | undefined;
-    generate_release_notes: boolean | undefined;
   }): Promise<{ data: Release }> {
     return this.github.rest.repos.createRelease(params);
   }
@@ -107,7 +104,6 @@ export class GitHubReleaser implements Releaser {
     draft: boolean | undefined;
     prerelease: boolean | undefined;
     discussion_category_name: string | undefined;
-    generate_release_notes: boolean | undefined;
   }): Promise<{ data: Release }> {
     return this.github.rest.repos.updateRelease(params);
   }
@@ -171,7 +167,7 @@ export const upload = async (
   const json = await resp.json();
   if (resp.status !== 201) {
     throw new Error(
-      `Failed to upload release asset ${name}. received status code ${
+      `Failed to upload release asset ${name}. recieved status code ${
         resp.status
       }\n${json.message}\n${JSON.stringify(json.errors)}`
     );
@@ -197,7 +193,6 @@ export const release = async (
       : "");
 
   const discussion_category_name = config.input_discussion_category_name;
-  const generate_release_notes = config.input_generate_release_notes;
   try {
     // you can't get a an existing draft by tag
     // so we must find one in the list of all releases
@@ -234,11 +229,12 @@ export const release = async (
 
     const tag_name = tag;
     const name = config.input_name || existingRelease.data.name || tag;
-    // revisit: support a new body-concat-strategy input for accumulating
-    // body parts as a release gets updated. some users will likely want this while
-    // others won't previously this was duplicating content for most which
-    // no one wants
-    let body = releaseBody(config) || existingRelease.data.body || "";
+
+    let body: string = "";
+    if (existingRelease.data.body) body += existingRelease.data.body;
+    let workflowBody = releaseBody(config);
+    if (existingRelease.data.body && workflowBody) body += "\n";
+    if (workflowBody) body += workflowBody;
 
     const draft =
       config.input_draft !== undefined
@@ -259,8 +255,7 @@ export const release = async (
       body,
       draft,
       prerelease,
-      discussion_category_name,
-      generate_release_notes
+      discussion_category_name
     });
     return release.data;
   } catch (error) {
@@ -276,7 +271,7 @@ export const release = async (
         commitMessage = ` using commit "${target_commitish}"`;
       }
       console.log(
-        `👩‍🏭 Creating new GitHub release for tag ${tag_name}${commitMessage}...`
+        `👩‍🏭 Creating new GitHub release in ${owner}/${repo} for tag ${tag_name}${commitMessage}...`
       );
       try {
         let release = await releaser.createRelease({
@@ -288,8 +283,7 @@ export const release = async (
           draft,
           prerelease,
           target_commitish,
-          discussion_category_name,
-          generate_release_notes
+          discussion_category_name
         });
         return release.data;
       } catch (error) {

src/util.ts

@@ -17,7 +17,6 @@ export interface Config {
   input_fail_on_unmatched_files?: boolean;
   input_target_commitish?: string;
   input_discussion_category_name?: string;
-  input_generate_release_notes?: boolean;
 }
 
 export const uploadUrl = (url: string): string => {
@@ -64,10 +63,8 @@ export const parseConfig = (env: Env): Config => {
       ? env.INPUT_PRERELEASE == "true"
       : undefined,
     input_fail_on_unmatched_files: env.INPUT_FAIL_ON_UNMATCHED_FILES == "true",
-    input_target_commitish: env.INPUT_TARGET_COMMITISH || undefined,
-    input_discussion_category_name:
-      env.INPUT_DISCUSSION_CATEGORY_NAME || undefined,
-    input_generate_release_notes: env.INPUT_GENERATE_RELEASE_NOTES == "true"
+    input_target_commitish: env.INPUT_TARGET_COMMITISH,
+    input_discussion_category_name: env.INPUT_DISCUSSION_CATEGORY_NAME
   };
 };