document impl detail

This commit is contained in:
softprops 2024-05-06 09:44:36 -04:00
parent 72e945e627
commit 3989e4b325

View File

@ -149,6 +149,9 @@ export const upload = async (
const [owner, repo] = config.github_repository.split("/"); const [owner, repo] = config.github_repository.split("/");
const { name, size, mime, data: body } = asset(path); const { name, size, mime, data: body } = asset(path);
const currentAsset = currentAssets.find( const currentAsset = currentAssets.find(
// note: GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods. The "List release assets" endpoint lists the renamed filenames.
// due to this renaming we need to be mindful when we compare the file name we're uploading with a name github may already have rewritten for logical comparison
// see https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset
({ name: currentName }) => currentName == name.replace(" ", ".") ({ name: currentName }) => currentName == name.replace(" ", ".")
); );
if (currentAsset) { if (currentAsset) {