google/googletest
0
0
Fork 0
mirror of https://github.com/google/googletest.git synced 2025-11-10 06:55:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

gmock-actions: improve comments and tests for the implicit cast in Return.

Browse Source 
Commit a070cbd91c added an implicit cast to this path but didn't leave a very
clear explanation for why it was desirable, a clear example, or even test
coverage. Add a better comment and a test that fails when the implicit cast is
removed.

PiperOrigin-RevId: 444871311
Change-Id: I127982fa8d5bce9b6d1b68177c12dc0709449164
This commit is contained in:
Aaron Jacobs
2022-04-27 08:48:35 -07:00
committed by Copybara-Service
parent c144d78f82
commit 830fb56728
2 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
googlemock/include/gmock/gmock-actions.h
View File

@@ -935,15 +935,16 @@ class ReturnAction {
typedef typename Function<F>::Result Result;
typedef typename Function<F>::ArgumentTuple ArgumentTuple;
// The implicit cast is necessary when Result has more than one
// single-argument constructor (e.g. Result is std::vector<int>) and R
// has a type conversion operator template. In that case, value_(value)
// won't compile as the compiler doesn't known which constructor of
// Result to call. ImplicitCast_ forces the compiler to convert R to
// Result without considering explicit constructors, thus resolving the
// ambiguity. value_ is then initialized using its copy constructor.
explicit Impl(const std::shared_ptr<R>& value)
: value_before_cast_(*value),
// Make an implicit conversion to Result before initializing the
// Result object we store, avoiding calling any explicit constructor
// of Result from R.
//
// This simulates the language rules: a function with return type
// Result that does `return R()` requires R to be implicitly
// convertible to Result, and uses that path for the conversion, even
// if Result has an explicit constructor from R.
value_(ImplicitCast_<Result>(value_before_cast_)) {}
Result Perform(const ArgumentTuple&) override { return value_; }