1721ce7afd
Address minor review comments
2026-03-03 11:05:37 +00:00
40aec383a1
Move more SARIF helpers to sarif module
2026-03-01 14:22:49 +00:00
2c9bc45d46
Abstract over FeatureEnablement implementations with initFeatures
2026-02-15 15:40:21 +00:00
6bd84b6a82
Rename to "unhandled"
2026-01-23 10:34:45 +00:00
229e0cd749
Add catch-all error reporting for errors that slip through run
2026-01-22 13:14:53 +00:00
14bd76753f
Add reminder to minimise code outside try/catch
2026-01-22 11:31:17 +00:00
7c72e12ecb
Expand try-catch to cover more of Actions
2026-01-22 10:46:05 +00:00
f0452d5366
Consistently use "post-processing"
2025-10-24 10:20:25 +01:00
6f0fcbeea7
Rename uploadSarif
2025-10-22 19:09:39 +01:00
596de7f1bc
Move UploadKind check into uploadSarif
2025-10-22 19:00:29 +01:00
1b09eb4ccc
Address review
2025-10-07 17:17:06 +02:00
00a6e13cbf
Tweak SARIF skipping logs
2025-10-06 17:03:29 +02:00
25c8db918a
Revert "Specify reason for skipping SARIF upload in logs"
...
This reverts commit 680b07003d
2025-10-06 16:59:45 +02:00
680b07003d
Specify reason for skipping SARIF upload in logs
2025-10-06 15:39:29 +02:00
e0b9da7b0a
Introduce CODEQL_ACTION_SKIP_SARIF_UPLOAD
...
This triggers a subset of the behavior of `CODEQL_ACTION_TEST_MODE`,
specifically just skipping the SARIF upload step. This is required for
our internal testing where we want the SARIF file (via
`CODEQL_ACTION_DUMP_SARIF_DIR`) but don't want to actually upload it,
but we don't want the rest of the behaviour of `CODEQL_ACTION_TEST_MODE`
that is specific for `codeql-action` own CI checks.
2025-10-06 14:38:32 +02:00
5fd2cfe1ef
Fail if no SARIF files were uploaded
2025-09-29 09:04:44 +01:00
9f452fad0f
Move core upload-sarif logic to upload-sarif module
...
Note that this also fixes the format of the `sarif-ids` outputs to match what is documented
2025-09-29 08:57:52 +01:00
5fc9e66105
Move findAndUpload to a new module
2025-09-29 08:44:44 +01:00
0b7fc56648
Fix upload-sarif not uploading non-.sarif files
2025-09-26 17:47:59 +01:00
7bea0e2e12
Fix outdated comment
2025-09-19 16:17:33 +01:00
d378195403
Add new sarif-ids output to upload-sarif action
...
Unlike `sarif-id` which is for the single Code Scanning SARIF id, `sarif-ids` contains stringified JSON object with details of all SARIF ids.
2025-09-19 16:17:31 +01:00
a2ce099060
Use findAndUpload for Code Scanning
2025-09-18 16:29:25 +01:00
696b467654
Handle single file case in findAndUpload
2025-09-18 16:29:23 +01:00
c8e017d3e7
Move isDirectory check into findAndUpload
2025-09-18 16:28:39 +01:00
a6161a8092
Call lstatSync on sarifPath earlier and check that the path exists then
2025-09-18 14:13:17 +01:00
35454d39b2
Refactor CQ SARIF upload in upload-sarif into a function
2025-09-18 14:13:14 +01:00
01627081ff
Rename UploadTarget to AnalysisConfig
2025-09-04 11:39:18 +01:00
ca7dd4ad38
Move UploadTarget definitions to analyses.ts
2025-09-04 11:38:53 +01:00
72770345eb
Fix legacy SARIF categories for CQ in default setup
2025-08-06 10:14:36 +01:00
7b3d150883
Use findSarifFilesInDir in upload-sarif to avoid error when there are no quality.sarif files
2025-06-27 12:08:40 +01:00
ad6046ff97
Avoid default arguments with historical values
2025-06-26 13:51:08 +01:00
9ec0bb9605
Fix incorrect getSarifFilePaths call in upload-sarif action
2025-06-26 12:22:08 +01:00
2c76207fa4
Upload .quality.sarif files to CQ service in upload-sarif action
2025-06-25 13:43:39 +01:00
676a422916
review-comments: nest validateSariFileSchema into try-catch block to better discriminate error thrown
2025-04-02 19:06:31 +01:00
498c7f37e8
review-comments: unwrap error in upload-sarif-action and re-classify as ConfigurationError if in known error category
2025-04-02 15:20:03 +01:00
efd29bef22
refactor: revert getActionsStatus taking an extra argument
2025-04-02 15:13:00 +01:00
b53826d56d
review-comments: remove syntax-error handling for SARIF from upload-lib
2025-04-01 15:10:16 +01:00
55ee663d5f
review-comments: refactor getActionsStatus to accept an extra parameter designating if the analysis is third-party
2025-04-01 14:58:59 +01:00
f88459c0a3
Use getRepositoryNwo()
2025-03-26 10:18:40 -07:00
9bc4ee10c7
review-comments: add more descriptive comments to various persist/restoreState callsites.
...
Co-authored-by: Henry Mercer <henrymercer@github.com >
Co-authored-by: Fotis Koutoulakis <nlightnfotis@github.com >
2024-10-21 15:43:09 +01:00
6026274108
Persist inputs between the upload action and its post step.
2024-10-21 10:45:46 +01:00
dd7307d603
Refactoring: Simplify retrieving error message
2024-09-16 22:38:35 +02:00
202b3b97bf
Stop checking disk usage for MacOS ARM with SIP disabled ( #2434 )
...
* Stop checking disk usage for MacOS ARM with SIP disabled
On MacOS ARM machines where SIP is disabled, after the build tracer is initialized in the `init` Action, we receive warnings when we run send status reports due to the `df` binary. This change will make it so that we no longer run `df` for those machines.
2024-08-20 16:04:03 -07:00
9679491cab
Avoid reloading features when uploading SARIF
2024-07-01 14:34:11 +02:00
6c2a71ced3
Remove redundant layer from upload files functions
2024-07-01 14:31:44 +02:00
2f54d9fcfa
Enable no console rule
2024-06-13 19:47:29 +01:00
7df281f2fe
Gracefully continue if createStatusReportBase throws ( #2225 )
...
Previously, we weren't catching any possible exceptions in `createStatusReportBase` and runs would fail if any of the telemetry sub-items threw exceptions. As telemetry should not block the analysis, we continue here even if the status report throws.
2024-04-04 15:26:14 -07:00
c0917251d4
Refactoring: Convert ActionName to enum
2024-02-29 11:29:32 +00:00
e12a8cc5eb
Use isFirstPartyAnalysis for a stronger check
2024-02-29 11:20:42 +00:00
888ab31e3e
Mark third-party SARIF limits errors as configuration errors
2024-02-28 19:41:43 +00:00
Michael B. Gale
Henry Mercer
Paolo Tranquilli
Fotis Koutoulakis (@NlightNFotis)
Chuan-kai Lin
Chris Gavin
Angela P Wen