Henry Mercer
675af55c60
Run some unit tests in parallel
2026-03-04 12:40:22 +01:00
Michael B. Gale
f59338d600
Remove isCCR
2026-02-24 10:33:23 +00:00
Michael B. Gale
7af50a43c1
Restore test improvements from previous PR
2026-02-15 15:57:02 +00:00
Michael B. Gale
377300bcda
Add mockCCR helper to testing-utils
2026-02-15 15:40:23 +00:00
Michael B. Gale
ee8360df59
Move FF test utils out of main file
2026-02-15 15:40:23 +00:00
Michael B. Gale
9dcfdf2c9c
Return OfflineFeatures for CCR
2026-02-15 15:40:22 +00:00
Michael B. Gale
2c9bc45d46
Abstract over FeatureEnablement implementations with initFeatures
2026-02-15 15:40:21 +00:00
Michael B. Gale
ea1a400e13
Revert "Merge pull request #3476 from github/henrymercer/retry-auth-errors"
...
This reverts commit 9658e23e5b , reversing
changes made to 2d6b98c7cf .
2026-02-15 15:39:04 +00:00
Henry Mercer
05bca54402
Apply suggestion from @Copilot
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2026-02-12 17:37:10 +00:00
Henry Mercer
876cecb383
Avoid requesting features in CCR
2026-02-12 16:53:19 +00:00
Henry Mercer
855c0888b6
Improve test for throwing when no CodeQL provided
2026-01-05 16:38:04 +00:00
Henry Mercer
35d39dfdb3
Introduce type error when CodeQL is needed
2026-01-05 16:22:40 +00:00
Henry Mercer
1fc7d3785d
Rename GHE_DOTCOM to GHEC_DR
...
This more closely reflects the published naming https://docs.github.com/en/enterprise-cloud@latest/admin/data-residency/about-github-enterprise-cloud-with-data-residency
2025-12-10 17:41:19 +00:00
Henry Mercer
7a55ffeaf1
Determine CodeQL version from feature flags on GHEC-DR
2025-12-10 17:35:27 +00:00
Chuan-kai Lin
709cf22a66
Limit Code Scanning API to 25 features per request
2025-07-16 07:07:44 -07:00
Chuan-kai Lin
3eaefb4deb
Replicate "too many feature flags" error in test
2025-07-16 07:06:52 -07:00
Chuan-kai Lin
b37e7e2c5d
Move initializeFeatures() to testing-utils
...
This change eliminates the need for setup-codeql.test to import from
feature-flags.test, which makes the former run all tests defined in the
latter.
2025-07-11 09:54:40 -07:00
Fotis Koutoulakis (@NlightNFotis)
5445a29a97
tests: instead of false, use old feature flag with default value of false
2024-11-12 17:59:47 +00:00
Fotis Koutoulakis
fddb49dc77
test: update wording of text description
...
Co-authored-by: Henry Mercer <henrymercer@github.com >
2024-10-25 17:20:47 +01:00
Fotis Koutoulakis (@NlightNFotis)
65117851a6
test: add test ensuring we don't bail against proxima stamps when requesting feature flags
2024-10-25 17:04:54 +01:00
Henry Mercer
d591d172c8
Fix name of Python stdlib extraction feature flag
2024-10-17 11:25:52 +01:00
Henry Mercer
48c11ed2ba
Remove supporting code for CodeQL 2.13.0 through 2.13.4
2024-08-05 19:28:35 +01:00
Henry Mercer
8a9ecdff2e
Remove tests that require us to have at least one feature with a toolsVersion
...
If no features have a `toolsVersion` property, we'll never hit those code paths, so it isn't that important to test them.
Having a synthetic feature is an option but might create user confusion.
2024-06-26 19:46:03 +01:00
Henry Mercer
cf4c3b4434
Remove "_enabled" suffix from non-legacy features
2024-05-09 12:38:10 +01:00
Henry Mercer
829376a618
Allow feature flags to specify tool feature requirements
2024-04-12 16:15:12 +01:00
Henry Mercer
415881f4cf
Remove code specific to GitHub AE
2024-01-08 13:28:39 +00:00
Henry Mercer
fa98ec0c7a
Remove CliConfigFileEnabled feature flag
2024-01-04 14:39:36 +00:00
Michael B. Gale
a402be8739
Fix linter error
2023-10-04 11:43:14 +01:00
Henry Mercer
ebbadee09e
Remove ML-powered queries
2023-10-02 17:20:50 +01:00
Angela P Wen
b16296be30
Auto-fix linting errors
2023-07-25 10:34:21 +02:00
Henry Mercer
27d3b2f857
Fix scaling reserved RAM feature flag naming
2023-07-18 13:41:05 +01:00
Henry Mercer
a41df3ae10
Add unit test for unsupported default version feature flags
2023-07-07 15:15:57 +01:00
Henry Mercer
50f2cc19ee
Remove now redundant variant property
...
Previously, this was useful for discriminating between different
`CodeQLDefaultVersion` instances. However now all instances return a
tag name.
2023-07-07 15:15:57 +01:00
Henry Mercer
bec18d1625
Remove fallback logic for mapping default CLI version to GitHub Release
...
The default version feature flags will now always point to a CLI version
with a semantically versioned bundle, so we can find the GitHub
Release directly from the CLI version.
2023-07-07 15:15:57 +01:00
Henry Mercer
6418c5d819
Skip an API call when downloading a CodeQL version with a semver bundle
...
Previously, we made an API call to look up the CLI version to release
mapping when the default CLI version was requested on Dotcom and that
CLI wasn't in the toolcache.
Now we compute the tag name directly for semver bundles.
2023-07-07 10:58:57 +01:00
Henry Mercer
53f80edaf6
Merge branch 'main' into henrymercer/diagnostics-code-scanning-config
2023-03-09 18:47:43 +00:00
Henry Mercer
485cc11a24
Rename featureEnablement to features
...
This is more succinct and removes a few line breaks
2023-03-09 16:46:51 +00:00
Andrew Eisenberg
0c27d0da4a
Add default values to feature flags
...
This changes adds default values to feature flags. These default values
will be used whenever the full set of feature flags are not available
(for example on GHES or if the flag request fails).
The goal is to enable cli config parsing on GHES without removing the
feature flag on dotcom.
2023-03-07 16:24:55 -08:00
Angela P Wen
24ca6b0400
Send tools telemetry to init status report ( #1497 )
...
Co-authored-by: Henry Mercer <henry.mercer@me.com >
2023-01-25 11:09:18 -08:00
Henry Mercer
5d931ea2a2
Fall back to the default.json CLI version if feature flags misconfigured
2023-01-23 20:00:44 +00:00
Henry Mercer
a89ad76881
Expand note about defaults.json compatibility
...
In the future we might convert the file to JSON with comments, or add
this note to a JSON schema.
2023-01-12 15:46:12 +00:00
Henry Mercer
a6dff04fe1
Ignore default version flags with invalid version numbers
2023-01-11 19:06:49 +00:00
Henry Mercer
cdb90196f2
Support determining Dotcom CLI version from feature flags
2023-01-11 18:40:47 +00:00
Andrew Eisenberg
4ee97e5e55
Add extra test ensuring env var overrides cached feature flag
2022-11-21 14:30:36 -08:00
Andrew Eisenberg
c29fca48a1
Cache feature flags on disk
...
This will allow feature flags to be shared across steps in the same job,
avoiding an error we saw earlier where the init action had the flag
enabled, but the analyze step had it disabled.
This uses the runner's temp folder to cache the flags file, which will
stick around until the job completes.
2022-11-21 11:14:38 -08:00
Henry Mercer
9df773d1a3
Remove unneeded apiDetails input to getApiClient
2022-11-14 19:55:30 +00:00
Henry Mercer
b498c79130
Remove concept of Actions / runner mode
2022-11-14 16:37:48 +00:00
Henry Mercer
43c3ed9c28
More feature flag renaming
2022-10-11 11:52:55 -07:00
Andrew Eisenberg
701cea34ba
More renaming
2022-10-11 10:39:40 -07:00
Andrew Eisenberg
6c869f8b03
Fix typos
2022-10-07 16:27:25 -07:00