Commit Graph

180 Commits

Author SHA1 Message Date
Angela P Wen 954566eac2 Unset DYLD_INSERT_BINARIES when unneeded
Previously, the tracer environment variables were set for the
current process, and for future steps, in the init action. In
certain scenarios (such as on MacOS ARM runners with System
Integrity Protection disabled), these environment variables are
not unset by the system. In particular, the `DYLD_INSERT_BINARIES`
variable interferes with later system calls.

This change unsets the `DYLD_INSERT_BINARIES` variable for the
current process in init. It also unsets the variables either at the
beginning of autobuild, or analyze, if autobuild has not run.
2024-08-14 17:28:40 -07:00
Henry Mercer 264cbe20c6 Merge branch 'main' into henrymercer/enable-direct-tracing 2024-07-09 13:20:32 +01:00
Henry Mercer 0669d181f5 Merge branch 'main' into henrymercer/enable-direct-tracing 2024-07-08 10:32:33 +01:00
Henry Mercer a98055bc5b Merge branch 'main' into henrymercer/simplify-actions-only 2024-07-08 10:31:04 +01:00
Henry Mercer 8dba596f10 Tidy up telemetry call 2024-07-02 14:59:50 +02:00
Henry Mercer 7e6aa4d65a Propagate configuration errors from running queries 2024-07-02 14:53:43 +02:00
Henry Mercer 9679491cab Avoid reloading features when uploading SARIF 2024-07-01 14:34:11 +02:00
Henry Mercer 6c2a71ced3 Remove redundant layer from upload files functions 2024-07-01 14:31:44 +02:00
Henry Mercer a52b209ec8 Enable direct tracing the autobuild build mode by default 2024-06-26 19:38:13 +01:00
Henry Mercer 6ccd5631d8 Put TRAP cache cleanup behind a feature flag 2024-05-23 16:27:50 +01:00
Henry Mercer 4f2b1826e9 Add telemetry for TRAP cache cleanup 2024-05-23 16:27:50 +01:00
Henry Mercer 0b4214972e Invoke cleanup in analyze Action 2024-05-23 16:27:50 +01:00
Henry Mercer cbe29f55df Run autobuild script via direct tracing when feature enabled 2024-04-12 17:07:08 +01:00
Henry Mercer 3d49faaabb Use extraction via build mode in autobuild Action when available 2024-04-12 17:07:08 +01:00
Henry Mercer e37d0f3e7c Use direct tracing when autobuild build mode specified
Behind a flag, for now
2024-04-12 17:06:35 +01:00
Rasmus Wriedt Larsen 4e8e3439dd Merge branch 'main' into RasmusWL/remove-python-dep-inst 2024-04-08 10:25:42 +02:00
Angela P Wen 7df281f2fe Gracefully continue if createStatusReportBase throws (#2225)
Previously, we weren't catching any possible exceptions in `createStatusReportBase` and runs would fail if any of the telemetry sub-items threw exceptions. As telemetry should not block the analysis, we continue here even if the status report throws.
2024-04-04 15:26:14 -07:00
Rasmus Wriedt Larsen 6ab7733abd build 2024-04-04 17:15:39 +02:00
Henry Mercer 2307ff547f Add languages and build_mode to init success status report 2024-02-29 12:18:19 +00:00
Henry Mercer c0917251d4 Refactoring: Convert ActionName to enum 2024-02-29 11:29:32 +00:00
Henry Mercer 888ab31e3e Mark third-party SARIF limits errors as configuration errors 2024-02-28 19:41:43 +00:00
Angela P Wen 1a6bac42d0 Rename considerInvalidRequestConfigError to isThirdPartyUpload
This describes what we are trying to do more accurately.
2024-02-28 15:22:39 +00:00
Henry Mercer 60465730fb Add event name to status report 2024-02-26 19:36:37 +00:00
Henry Mercer 28b564f8c6 Add languages to the status report for all jobs 2024-02-26 19:03:28 +00:00
Josh Soref 5a6da1d85d Treat status reports as non-critical
Change `sendStatusReport` to `void`
2024-02-12 13:56:10 -05:00
Angela P Wen 1515e2bb20 Refactor configuration errors (#2105)
Refactor the existing classes of configuration errors into their own file; consolidate the place we check for configuration errors into `codeql.ts`, where the actual command invocations happen.

Also, rename the `UserError` type to `ConfigurationError` to standardize on a single term.
2024-02-08 17:20:03 +00:00
Henry Mercer 0fe34bd39a Extract language appropriately in analyze step when build mode specified 2024-02-07 13:19:29 +00:00
nickfyson f72cffc780 add v2 deprecation warning 2024-01-18 20:51:16 +00:00
Angela P Wen f65ecd09c7 Only delete SARIF in PR check if not running on a fork (#2084) 2024-01-16 16:07:58 -08:00
Michael B. Gale 632d58cb60 Update Go path documentation in analyze Action 2023-10-13 10:14:22 +01:00
Michael B. Gale 4eccc6dac4 Suppress Go workaround warning if autobuilder ran 2023-10-06 15:11:31 +01:00
Michael B. Gale 235bdca565 Use markdownMessage 2023-10-05 14:27:34 +01:00
Michael B. Gale 94f3e9b563 Apply suggestions from code review
Co-authored-by: Henry Mercer <henry.mercer@me.com>
2023-10-05 14:27:09 +01:00
Michael B. Gale a144bf5d7f Store diagnostics in language-specific database 2023-10-05 13:39:58 +01:00
Michael B. Gale eb71a60380 Emit diagnostic when Go was changed after init 2023-10-05 12:52:06 +01:00
Michael B. Gale 41a13ec084 Fix comment in analyse Action 2023-10-04 19:53:23 +01:00
Michael B. Gale 604448043e Add which go output in warning 2023-10-04 19:45:08 +01:00
Michael B. Gale 4611ff9b23 Cross-check Go binary in analyze Action 2023-10-04 19:45:04 +01:00
Henry Mercer ebbadee09e Remove ML-powered queries 2023-10-02 17:20:50 +01:00
Henry Mercer 379f89dc53 Log cgroup RAM limits 2023-09-18 13:05:29 +01:00
Henry Mercer a7c12a5225 Address PR comments 2023-09-07 20:44:15 +01:00
Henry Mercer 7218de5369 Merge branch 'main' into henrymercer/user-errors-for-upload-sarif 2023-09-07 19:40:15 +01:00
Henry Mercer 583a1019cc Mark invalid SARIF errors as user errors in the upload-sarif Action 2023-09-06 18:14:30 +01:00
Henry Mercer 10389f671b Remove scaling reserved RAM feature flag 2023-09-05 14:30:56 +02:00
Angela P Wen 07d42ec34e Improve logging for Go autobuild when invoked in analyze step (#1862) 2023-08-31 11:39:07 +00:00
Henry Mercer 7dcb3e5276 Include runner disk info in status report 2023-08-07 16:27:56 +01:00
Henry Mercer c6d284324b Pull out a dedicated status report file 2023-08-07 16:13:59 +01:00
Josh Soref 8ab72a0f47 Add output for analyze action output path 2023-07-25 16:03:16 -04:00
Henry Mercer 2637069a45 Resolve dependency cycles between actions-util and workflow 2023-07-19 17:21:33 +01:00
Henry Mercer 0bc4788cf7 Resolve dependency cycle between api-client and actions-util 2023-07-19 17:01:05 +01:00