Commit Graph

201 Commits

Author SHA1 Message Date
Fotis Koutoulakis (@NlightNFotis) 676a422916 review-comments: nest validateSariFileSchema into try-catch block to better discriminate error thrown 2025-04-02 19:06:31 +01:00
Fotis Koutoulakis (@NlightNFotis) b53826d56d review-comments: remove syntax-error handling for SARIF from upload-lib 2025-04-01 15:10:16 +01:00
Fotis Koutoulakis (@NlightNFotis) 01f1a1f2c9 Merge branch 'main' into NlightNFotis/reclassify_upload_sarif_issues 2025-03-31 16:29:02 +01:00
Fotis Koutoulakis (@NlightNFotis) 72a2b1295e feat: classify some observed SARIF errors as InvalidSarifUploadError 2025-03-31 12:17:23 +01:00
Chuan-kai Lin 534bc63d5e Rename diff-filtering-utils.ts to diff-informed-analysis-utils.ts 2025-03-27 10:27:23 -07:00
Chuan-kai Lin f88459c0a3 Use getRepositoryNwo() 2025-03-26 10:18:40 -07:00
Chuan-kai Lin dae1626680 Filter alerts by pr-diff-range JSON file 2025-02-19 06:26:11 -08:00
Chuan-kai Lin b0cd76b9fb Move Git functions to git-utils.ts 2024-12-10 08:44:11 -08:00
github-actions[bot] 44e03577b2 Rebuild 2024-12-03 18:39:38 +00:00
Fotis Koutoulakis (@NlightNFotis) 5445a29a97 tests: instead of false, use old feature flag with default value of false 2024-11-12 17:59:47 +00:00
Henry Mercer 33f2dc57a4 Enable zstd bundles on GHES and remove feature flag 2024-11-01 15:24:51 +00:00
Chuan-kai Lin d64cca4b60 Rename determineMergeBaseCommitOid()
The name suggests that the function computes the merge base, which for
Git means specifically the best common ancestors between multiple
commits or branches (see `git merge-base`).

But what the function actually does is to calculate the HEAD commit of
the PR base branch, as derived from the PR merge commit that the action
analyzes. So even though the function has to do with "merge" and "base",
using the term "merge base" is still misleading at best.

This commit renames the function to determineBaseBranchHeadCommitOid(),
which more clearly indicates what the function does.
2024-10-03 08:43:36 -07:00
Henry Mercer ac3fca3e9f Use zstd bundle by default when feature flag enabled 2024-09-23 22:39:46 +01:00
Remco Vermeulen a1a585f2ab Merge branch 'main' into rvermeulen/uri-errors-as-warnings 2024-09-17 14:09:52 -07:00
Remco Vermeulen 642bbfc83a Turn invalid helpUri attribute into a warning 2024-09-16 20:22:13 -07:00
Henry Mercer dd7307d603 Refactoring: Simplify retrieving error message 2024-09-16 22:38:35 +02:00
Henry Mercer ecb9ccfcb1 Fix new linter errors 2024-08-05 19:22:26 +01:00
Henry Mercer a0041ad76c Keep analysis_name field consistent 2024-07-08 10:30:24 +01:00
Henry Mercer 9679491cab Avoid reloading features when uploading SARIF 2024-07-01 14:34:11 +02:00
Henry Mercer 6c2a71ced3 Remove redundant layer from upload files functions 2024-07-01 14:31:44 +02:00
Henry Mercer 1ea11ca775 Enable no-unsafe-return rule 2024-06-13 19:52:39 +01:00
Henry Mercer e7d04fdb41 Enable unsafe call rule 2024-06-13 19:38:06 +01:00
Koen Vlaswinkel 931fabe1ef Remove feature flag for combine SARIF files deprecation warning 2024-05-14 11:00:12 +02:00
Henry Mercer b1c3187939 Add more invalid SARIF processing errors 2024-05-08 13:36:10 +01:00
Marco Gario 65297ef0b0 Update link to deprecation changelog 2024-05-06 20:39:22 +02:00
Koen Vlaswinkel b20bf5914d Remove CLI SARIF merge feature flag 2024-05-03 15:14:12 +02:00
Koen Vlaswinkel 5d274be858 Update CodeQL deprecation message 2024-05-02 14:02:42 +02:00
Koen Vlaswinkel 3a471a06fa Update comment 2024-05-02 14:01:44 +02:00
Koen Vlaswinkel 725ed4139d Add tests for shouldShowCombineSarifFilesDeprecationWarning 2024-05-02 10:20:11 +02:00
Koen Vlaswinkel 1de9b371a1 Clarify name of function 2024-05-02 10:01:11 +02:00
Koen Vlaswinkel 757fcd3d21 Remove unnecessary optional chaining 2024-05-02 10:00:29 +02:00
Koen Vlaswinkel 40f70f96b1 Extract more information message 2024-05-02 09:59:52 +02:00
Koen Vlaswinkel b3225af51b Mention GHES 3.18 as removal version on GHES 2024-04-26 14:38:20 +02:00
Koen Vlaswinkel 905f9b0083 Only show deprecation warning on GHES 3.14+ 2024-04-26 14:38:06 +02:00
Koen Vlaswinkel 80394dcc32 Hide deprecation warning if feature flag is not set 2024-04-26 14:37:27 +02:00
Koen Vlaswinkel a5e49d1544 Extract check for combine SARIF files deprecation warning 2024-04-26 14:36:54 +02:00
Koen Vlaswinkel 24acd7711e Set correct changelog URL 2024-04-26 14:23:51 +02:00
Koen Vlaswinkel 8b0dfa84c7 Add deprecation warning for merging SARIF files with non-unique categories 2024-04-26 14:22:30 +02:00
Koen Vlaswinkel 5d73b1bd71 Remove incorrect log message 2024-04-17 10:20:46 +02:00
Henry Mercer e006461bad Mark some upload-sarif errors as always configuration errors 2024-04-15 15:52:19 +01:00
Henry Mercer fa75c144b4 Capture rate limit and ref not existing config errors 2024-04-12 18:25:10 +01:00
nickfyson c037115ddf clarify logging in response to pr review comments 2024-04-03 21:19:06 +01:00
Nick Fyson 2cc8bbd0e0 Apply suggestions from code review
Co-authored-by: Henry Mercer <henrymercer@github.com>
2024-04-03 20:42:48 +01:00
nickfyson 6514cbb626 improve logging coverage when uploaing sarif files 2024-04-03 15:45:28 +01:00
Koen Vlaswinkel 016720d81f Refactor areAllRunsProducedByCodeQL to use Array.every 2024-03-26 11:09:44 +01:00
Koen Vlaswinkel 3c4b8bc120 Change log levels 2024-03-25 10:15:37 +01:00
Koen Vlaswinkel a0a63a2dd4 Do not try merging a single SARIF file 2024-03-25 10:15:16 +01:00
Koen Vlaswinkel 3bd271cec3 Introduce areAllRunsProducedByCodeQL function 2024-03-25 10:14:59 +01:00
Koen Vlaswinkel 6ac57535de Use options object instead of boolean for mergeResults 2024-03-25 10:13:15 +01:00
Koen Vlaswinkel e20c273295 Use supportsFeature check for merging SARIF files 2024-03-22 14:15:42 +01:00