Commit Graph

3226 Commits

Author SHA1 Message Date
Michael B. Gale 0874cf9f8b Change FFs not supported log message 2026-02-15 15:51:06 +00:00
Michael B. Gale bc76ceafaf Add test to check that OfflineFeatures doesn't use the API client 2026-02-15 15:40:23 +00:00
Michael B. Gale 377300bcda Add mockCCR helper to testing-utils 2026-02-15 15:40:23 +00:00
Michael B. Gale ee8360df59 Move FF test utils out of main file 2026-02-15 15:40:23 +00:00
Michael B. Gale 9dcfdf2c9c Return OfflineFeatures for CCR 2026-02-15 15:40:22 +00:00
Michael B. Gale 2c9bc45d46 Abstract over FeatureEnablement implementations with initFeatures 2026-02-15 15:40:21 +00:00
Michael B. Gale 368f322a09 Add OfflineFeatures class 2026-02-15 15:40:20 +00:00
Michael B. Gale 5283c3ba5a Move getDefaultCliVersion out of GitHubFeatureFlags
It doesn't need to be in there since it doesn't depend on the API itself and call `getDefaultCliVersionFromFlags` directly
2026-02-15 15:40:19 +00:00
Michael B. Gale ea1a400e13 Revert "Merge pull request #3476 from github/henrymercer/retry-auth-errors"
This reverts commit 9658e23e5b, reversing
changes made to 2d6b98c7cf.
2026-02-15 15:39:04 +00:00
Henry Mercer 05bca54402 Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-12 17:37:10 +00:00
Henry Mercer 876cecb383 Avoid requesting features in CCR 2026-02-12 16:53:19 +00:00
Henry Mercer 43b46a19be Retry API authentication errors since these can be transient 2026-02-12 16:19:04 +00:00
Michael B. Gale efb92e2714 Skip checks for non-URLs for now 2026-02-11 18:02:24 +00:00
Michael B. Gale 2b5b614c85 Add timeout event handler 2026-02-11 17:50:44 +00:00
Michael B. Gale 555ee17b0b Remove unused logger in NetworkReachabilityBackend 2026-02-11 17:46:33 +00:00
Michael B. Gale e114998dda Add test for missing type 2026-02-11 17:15:45 +00:00
Michael B. Gale bd36637537 Require validated Credential for credentialToStr 2026-02-11 17:13:01 +00:00
Michael B. Gale 4d0bec12bf Rename types 2026-02-11 17:10:39 +00:00
Michael B. Gale 0387f55b70 Fix outdated comment 2026-02-11 16:49:07 +00:00
Michael B. Gale 27b3b6586d Remove unnecessary test assertions 2026-02-11 16:47:57 +00:00
Michael B. Gale c4b0f60beb Remove superfluous error handling details 2026-02-10 17:15:03 +00:00
Michael B. Gale 51357000d2 Add a 5s timeout to requests 2026-02-10 17:09:49 +00:00
Michael B. Gale 4d44b570d2 Type that registries must have either an url or a host 2026-02-10 17:05:44 +00:00
Michael B. Gale 700fc11b44 Add missing else 2026-02-10 16:21:07 +00:00
Michael B. Gale 9f2f6d0d2e Remove superflous log message 2026-02-10 16:13:23 +00:00
Michael B. Gale 01ee641f14 Test connections to registries, if FF is enabled 2026-02-10 15:37:45 +00:00
Michael B. Gale c7eff3f0b1 Add StartProxyConnectionChecks feature 2026-02-10 14:57:16 +00:00
Michael B. Gale c4717c9c74 Add ProxyInfo type and return from startProxy 2026-02-10 14:56:24 +00:00
Michael B. Gale 70eae154c6 Break up Credential type into two interfaces 2026-02-09 17:36:08 +00:00
Michael B. Gale 93302bc63a Move Credential type 2026-02-09 17:32:48 +00:00
Michael B. Gale d2901f5537 Make FFs available in start-proxy action 2026-02-06 10:43:36 +00:00
github-actions[bot] 3d0331896c Update default bundle to codeql-bundle-v2.24.1 2026-02-05 15:16:22 +00:00
Michael B. Gale 7deb0a15d3 Merge pull request #3444 from github/mbg/start-proxy/error-types
Report some types of errors in `start-proxy` status reports
2026-02-04 19:12:25 +00:00
Michael B. Gale 57a47f44df Improve credentialToStr tests 2026-02-02 18:13:23 +00:00
Michael B. Gale 076d055bee Improve sendFailedStatusReport tests 2026-02-02 18:09:44 +00:00
Henry Mercer 6d4cd5d744 Add "Requires authentication" to wrapApiConfigurationError 2026-02-02 18:02:11 +00:00
Michael B. Gale 42fb267c1c Don't store error message in StartProxyError errors 2026-02-02 17:26:37 +00:00
Michael B. Gale 832a783bd4 Address minor review comments 2026-02-02 17:13:43 +00:00
Michael B. Gale beb9f533db Add and use getProxyFilename 2026-01-29 15:19:36 +00:00
Michael B. Gale a1c70789a3 Use getSafeErrorMessage for unhandled error message 2026-01-29 15:09:21 +00:00
Michael B. Gale d94d88d717 Add tests for getProxyBinaryPath 2026-01-29 15:06:20 +00:00
Michael B. Gale a6d296a341 Move getProxyBinaryPath to start-proxy module 2026-01-29 14:20:16 +00:00
Michael B. Gale 28f6d316c0 Handle toolcache errors with StartProxyError 2026-01-29 14:16:36 +00:00
Michael B. Gale 1d0f911837 Handle extraction errors with StartProxyError 2026-01-29 13:45:46 +00:00
Michael B. Gale 05bd050f34 Add and use withRecordingLoggerAsync 2026-01-29 13:44:10 +00:00
Michael B. Gale 325a3a2ae3 Add wrapFailureTest test macro 2026-01-29 13:34:19 +00:00
Michael B. Gale 6394750070 Add test for sendFailedStatusReport 2026-01-29 13:19:37 +00:00
Michael B. Gale f1588cde0c Add StartProxyError for status-report-safe errors, and use for proxy download 2026-01-29 12:38:04 +00:00
Michael B. Gale 4dcc8a9cdc Move failed status report code into sendFailedStatusReport 2026-01-29 10:28:55 +00:00
Michael B. Gale fbe3ae9de8 Move sendSuccessStatusReport to start-proxy module 2026-01-29 10:20:59 +00:00