From fba33f686abb9319a34cc9ab182b26e8141e0111 Mon Sep 17 00:00:00 2001 From: Henry Mercer Date: Mon, 23 Feb 2026 18:49:38 +0000 Subject: [PATCH] Enable `tseslint` strict rules --- eslint.config.mjs | 3 +++ lib/analyze-action-post.js | 3 --- lib/analyze-action.js | 6 ------ lib/autobuild-action.js | 3 --- lib/init-action-post.js | 6 ------ lib/init-action.js | 3 --- lib/resolve-environment-action.js | 3 --- lib/setup-codeql-action.js | 3 --- lib/start-proxy-action-post.js | 3 --- lib/start-proxy-action.js | 3 --- lib/upload-lib.js | 6 ------ lib/upload-sarif-action-post.js | 3 --- lib/upload-sarif-action.js | 6 ------ src/upload-lib.ts | 6 +----- src/util.ts | 6 +----- 15 files changed, 5 insertions(+), 58 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index c9249a9e0..3e1ea8a6a 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -27,6 +27,7 @@ export default [ js.configs.recommended, // Type-checked rules from typescript-eslint ...tseslint.configs.recommendedTypeChecked, + ...tseslint.configs.strict, // eslint-plugin-github recommended config githubFlatConfigs.recommended, // eslint-plugin-github typescript config @@ -127,6 +128,8 @@ export default [ "no-async-foreach/no-async-foreach": "error", "no-sequences": "error", "no-shadow": "off", + // This is overly restrictive with unsetting `EnvVar`s + "@typescript-eslint/no-dynamic-delete": "off", "@typescript-eslint/no-shadow": "error", "@typescript-eslint/prefer-optional-chain": "error", "one-var": ["error", "never"], diff --git a/lib/analyze-action-post.js b/lib/analyze-action-post.js index ff2e0c97e..5e0d240c4 100644 --- a/lib/analyze-action-post.js +++ b/lib/analyze-action-post.js @@ -160719,9 +160719,6 @@ function getRequiredEnvParam(paramName) { return value; } var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; var cachedCodeQlVersion = void 0; function cacheCodeQlVersion(version) { diff --git a/lib/analyze-action.js b/lib/analyze-action.js index ba3e6820b..681d17b7f 100644 --- a/lib/analyze-action.js +++ b/lib/analyze-action.js @@ -106067,9 +106067,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { @@ -112805,9 +112802,6 @@ function sanitize(str2) { return (str2 ?? "_").replace(/[^a-zA-Z0-9_]/g, "_").toLocaleUpperCase(); } var InvalidSarifUploadError = class extends Error { - constructor(message) { - super(message); - } }; function filterAlertsByDiffRange(logger, sarif) { const diffRanges = readDiffRangesJsonFile(logger); diff --git a/lib/autobuild-action.js b/lib/autobuild-action.js index 3e83d8a8c..86d8e8a6f 100644 --- a/lib/autobuild-action.js +++ b/lib/autobuild-action.js @@ -102977,9 +102977,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { diff --git a/lib/init-action-post.js b/lib/init-action-post.js index 4c3ab3265..a3b72917c 100644 --- a/lib/init-action-post.js +++ b/lib/init-action-post.js @@ -163645,9 +163645,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { @@ -169444,9 +169441,6 @@ function sanitize(str2) { return (str2 ?? "_").replace(/[^a-zA-Z0-9_]/g, "_").toLocaleUpperCase(); } var InvalidSarifUploadError = class extends Error { - constructor(message) { - super(message); - } }; function filterAlertsByDiffRange(logger, sarif) { const diffRanges = readDiffRangesJsonFile(logger); diff --git a/lib/init-action.js b/lib/init-action.js index 172fd45d0..b8cb1cc39 100644 --- a/lib/init-action.js +++ b/lib/init-action.js @@ -103402,9 +103402,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { diff --git a/lib/resolve-environment-action.js b/lib/resolve-environment-action.js index d697e747b..296128470 100644 --- a/lib/resolve-environment-action.js +++ b/lib/resolve-environment-action.js @@ -102970,9 +102970,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { diff --git a/lib/setup-codeql-action.js b/lib/setup-codeql-action.js index ffda1e031..868de72ed 100644 --- a/lib/setup-codeql-action.js +++ b/lib/setup-codeql-action.js @@ -103043,9 +103043,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { diff --git a/lib/start-proxy-action-post.js b/lib/start-proxy-action-post.js index 81cc185cc..f3ec42564 100644 --- a/lib/start-proxy-action-post.js +++ b/lib/start-proxy-action-post.js @@ -160697,9 +160697,6 @@ function getRequiredEnvParam(paramName) { return value; } var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function isInTestMode() { return process.env["CODEQL_ACTION_TEST_MODE" /* TEST_MODE */] === "true"; diff --git a/lib/start-proxy-action.js b/lib/start-proxy-action.js index ea199e443..24d774e53 100644 --- a/lib/start-proxy-action.js +++ b/lib/start-proxy-action.js @@ -120145,9 +120145,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { diff --git a/lib/upload-lib.js b/lib/upload-lib.js index 1e52870b9..c47b91512 100644 --- a/lib/upload-lib.js +++ b/lib/upload-lib.js @@ -105883,9 +105883,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { @@ -110783,9 +110780,6 @@ function sanitize(str2) { return (str2 ?? "_").replace(/[^a-zA-Z0-9_]/g, "_").toLocaleUpperCase(); } var InvalidSarifUploadError = class extends Error { - constructor(message) { - super(message); - } }; function filterAlertsByDiffRange(logger, sarif) { const diffRanges = readDiffRangesJsonFile(logger); diff --git a/lib/upload-sarif-action-post.js b/lib/upload-sarif-action-post.js index e5022b1b6..e1c7a185c 100644 --- a/lib/upload-sarif-action-post.js +++ b/lib/upload-sarif-action-post.js @@ -160697,9 +160697,6 @@ function getRequiredEnvParam(paramName) { return value; } var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function isInTestMode() { return process.env["CODEQL_ACTION_TEST_MODE" /* TEST_MODE */] === "true"; diff --git a/lib/upload-sarif-action.js b/lib/upload-sarif-action.js index 89a6435ac..9f4eb87db 100644 --- a/lib/upload-sarif-action.js +++ b/lib/upload-sarif-action.js @@ -105864,9 +105864,6 @@ var HTTPError = class extends Error { } }; var ConfigurationError = class extends Error { - constructor(message) { - super(message); - } }; function asHTTPError(arg) { if (typeof arg !== "object" || arg === null || typeof arg.message !== "string") { @@ -111287,9 +111284,6 @@ function sanitize(str2) { return (str2 ?? "_").replace(/[^a-zA-Z0-9_]/g, "_").toLocaleUpperCase(); } var InvalidSarifUploadError = class extends Error { - constructor(message) { - super(message); - } }; function filterAlertsByDiffRange(logger, sarif) { const diffRanges = readDiffRangesJsonFile(logger); diff --git a/src/upload-lib.ts b/src/upload-lib.ts index 114b2b57d..88f8276ae 100644 --- a/src/upload-lib.ts +++ b/src/upload-lib.ts @@ -1130,11 +1130,7 @@ function sanitize(str?: string) { /** * An error that occurred due to an invalid SARIF upload request. */ -export class InvalidSarifUploadError extends Error { - constructor(message: string) { - super(message); - } -} +export class InvalidSarifUploadError extends Error {} function filterAlertsByDiffRange(logger: Logger, sarif: SarifFile): SarifFile { const diffRanges = readDiffRangesJsonFile(logger); diff --git a/src/util.ts b/src/util.ts index 5d52b4d0a..f4fed19a8 100644 --- a/src/util.ts +++ b/src/util.ts @@ -690,11 +690,7 @@ export class HTTPError extends Error { * An Error class that indicates an error that occurred due to * a misconfiguration of the action or the CodeQL CLI. */ -export class ConfigurationError extends Error { - constructor(message: string) { - super(message); - } -} +export class ConfigurationError extends Error {} export function asHTTPError(arg: any): HTTPError | undefined { if (