diff --git a/lib/start-proxy-action.js b/lib/start-proxy-action.js index 6b88aef40..f88505a99 100644 --- a/lib/start-proxy-action.js +++ b/lib/start-proxy-action.js @@ -121817,7 +121817,10 @@ function getCredentials(logger, registrySecrets, registriesCredentials, language ); } } - if ((!hasUsername(authConfig) || !isDefined2(authConfig.username)) && isUsernamePassword(authConfig) && isDefined2(authConfig.password) && isPAT(authConfig.password) || isToken(authConfig) && isDefined2(authConfig.token) && isPAT(authConfig.token)) { + const noUsername = !hasUsername(authConfig) || !isDefined2(authConfig.username); + const passwordIsPAT = isUsernamePassword(authConfig) && isDefined2(authConfig.password) && isPAT(authConfig.password); + const tokenIsPAT = isToken(authConfig) && isDefined2(authConfig.token) && isPAT(authConfig.token); + if (noUsername && (passwordIsPAT || tokenIsPAT)) { logger.warning( `A ${e.type} private registry is configured for ${e.host || e.url} using a GitHub Personal Access Token (PAT), but no username was provided. This may not work correctly. When configuring a private registry using a PAT, select "Username and password" and enter the username of the user who generated the PAT.` ); diff --git a/src/start-proxy.ts b/src/start-proxy.ts index 32762eae3..1a68d99cf 100644 --- a/src/start-proxy.ts +++ b/src/start-proxy.ts @@ -447,15 +447,18 @@ export function getCredentials( } // If the password or token looks like a GitHub PAT, warn if no username is configured. - if ( - ((!hasUsername(authConfig) || !isDefined(authConfig.username)) && - isUsernamePassword(authConfig) && - isDefined(authConfig.password) && - isPAT(authConfig.password)) || - (isToken(authConfig) && - isDefined(authConfig.token) && - isPAT(authConfig.token)) - ) { + const noUsername = + !hasUsername(authConfig) || !isDefined(authConfig.username); + const passwordIsPAT = + isUsernamePassword(authConfig) && + isDefined(authConfig.password) && + isPAT(authConfig.password); + const tokenIsPAT = + isToken(authConfig) && + isDefined(authConfig.token) && + isPAT(authConfig.token); + + if (noUsername && (passwordIsPAT || tokenIsPAT)) { logger.warning( `A ${e.type} private registry is configured for ${e.host || e.url} using a GitHub Personal Access Token (PAT), but no username was provided. ` + `This may not work correctly. When configuring a private registry using a PAT, select "Username and password" and enter the username of the user ` +