From e9e36aec74b61c82b725ccff4dd9104df39abaaf Mon Sep 17 00:00:00 2001 From: Sam Robson Date: Thu, 30 Apr 2026 16:39:05 +0100 Subject: [PATCH] test: drop codescanning-config-cli scenario for overlay without diff-informed --- .github/workflows/codescanning-config-cli.yml | 29 +------------------ 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/.github/workflows/codescanning-config-cli.yml b/.github/workflows/codescanning-config-cli.yml index 0c4829339..38b5b6ecc 100644 --- a/.github/workflows/codescanning-config-cli.yml +++ b/.github/workflows/codescanning-config-cli.yml @@ -6,13 +6,6 @@ env: # Diff informed queries add an additional query filter which is not yet # taken into account by these tests. CODEQL_ACTION_DIFF_INFORMED_QUERIES: false - # Specify overlay enablement manually to ensure stability around the exclude-from-incremental - # query filter. Here we only enable for the default code scanning suite. - CODEQL_ACTION_OVERLAY_ANALYSIS: true - CODEQL_ACTION_OVERLAY_ANALYSIS_JAVASCRIPT: false - CODEQL_ACTION_OVERLAY_ANALYSIS_CODE_SCANNING_JAVASCRIPT: true - CODEQL_ACTION_OVERLAY_ANALYSIS_STATUS_CHECK: false - CODEQL_ACTION_OVERLAY_ANALYSIS_SKIP_RESOURCE_CHECKS: true on: push: @@ -79,33 +72,13 @@ jobs: with: version: ${{ matrix.version }} - # On PRs, overlay analysis may change the config that is passed to the CLI. - # Therefore, we have two variants of the following test, one for PRs and one for other events. - - name: Empty file (non-PR) - if: github.event_name != 'pull_request' + - name: Empty file uses: ./../action/.github/actions/check-codescanning-config with: expected-config-file-contents: "{}" languages: javascript tools: ${{ steps.prepare-test.outputs.tools-url }} - - name: Empty file (PR) - if: github.event_name == 'pull_request' - uses: ./../action/.github/actions/check-codescanning-config - with: - expected-config-file-contents: | - { - "query-filters": [ - { - "exclude": { - "tags": "exclude-from-incremental" - } - } - ] - } - languages: javascript - tools: ${{ steps.prepare-test.outputs.tools-url }} - - name: Packs from input if: success() || failure() uses: ./../action/.github/actions/check-codescanning-config