From bc0afcb9694f53ae3d6f4b62a2ebc57fed29c057 Mon Sep 17 00:00:00 2001 From: Angela P Wen Date: Wed, 21 Sep 2022 09:48:33 -0700 Subject: [PATCH] Turn all feature flags on --- lib/feature-flags.js | 36 ++++++++++++++++++++--------------- lib/feature-flags.js.map | 2 +- src/feature-flags.ts | 41 +++++++++++++++++++++------------------- 3 files changed, 44 insertions(+), 35 deletions(-) diff --git a/lib/feature-flags.js b/lib/feature-flags.js index 61a628ffb..a98b6ff51 100644 --- a/lib/feature-flags.js +++ b/lib/feature-flags.js @@ -37,21 +37,27 @@ class GitHubFeatureFlags { this.logger = logger; } async getValue(flag) { - // Bypassing the toolcache is disabled in test mode. - if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) { - return false; - } - const response = await this.getApiResponse(); - if (response === undefined) { - this.logger.debug(`No feature flags API response for ${flag}, considering it disabled.`); - return false; - } - const flagValue = response[flag]; - if (flagValue === undefined) { - this.logger.debug(`Feature flag '${flag}' undefined in API response, considering it disabled.`); - return false; - } - return flagValue; + // Always return true for purposes of investigation in this PR. + return true; + // // Bypassing the toolcache is disabled in test mode. + // if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) { + // return false; + // } + // const response = await this.getApiResponse(); + // if (response === undefined) { + // this.logger.debug( + // `No feature flags API response for ${flag}, considering it disabled.` + // ); + // return false; + // } + // const flagValue = response[flag]; + // if (flagValue === undefined) { + // this.logger.debug( + // `Feature flag '${flag}' undefined in API response, considering it disabled.` + // ); + // return false; + // } + // return flagValue; } async getApiResponse() { const loadApiResponse = async () => { diff --git a/lib/feature-flags.js.map b/lib/feature-flags.js.map index 7780882e7..cc8f3e9a2 100644 --- a/lib/feature-flags.js.map +++ b/lib/feature-flags.js.map @@ -1 +1 @@ -{"version":3,"file":"feature-flags.js","sourceRoot":"","sources":["../src/feature-flags.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;AAAA,6CAA8D;AAG9D,6CAA+B;AAM/B,IAAY,WAKX;AALD,WAAY,WAAW;IACrB,kEAAmD,CAAA;IACnD,qEAAsD,CAAA;IACtD,0DAA2C,CAAA;IAC3C,iGAAkF,CAAA;AACpF,CAAC,EALW,WAAW,GAAX,mBAAW,KAAX,mBAAW,QAKtB;AAUD,MAAa,kBAAkB;IAG7B,YACU,aAAiC,EACjC,UAA4B,EAC5B,aAA4B,EAC5B,MAAc;QAHd,kBAAa,GAAb,aAAa,CAAoB;QACjC,eAAU,GAAV,UAAU,CAAkB;QAC5B,kBAAa,GAAb,aAAa,CAAe;QAC5B,WAAM,GAAN,MAAM,CAAQ;IACrB,CAAC;IAEJ,KAAK,CAAC,QAAQ,CAAC,IAAiB;QAC9B,oDAAoD;QACpD,IAAI,IAAI,KAAK,WAAW,CAAC,sBAAsB,IAAI,IAAI,CAAC,YAAY,EAAE,EAAE;YACtE,OAAO,KAAK,CAAC;SACd;QAED,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,cAAc,EAAE,CAAC;QAC7C,IAAI,QAAQ,KAAK,SAAS,EAAE;YAC1B,IAAI,CAAC,MAAM,CAAC,KAAK,CACf,qCAAqC,IAAI,4BAA4B,CACtE,CAAC;YACF,OAAO,KAAK,CAAC;SACd;QACD,MAAM,SAAS,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC;QACjC,IAAI,SAAS,KAAK,SAAS,EAAE;YAC3B,IAAI,CAAC,MAAM,CAAC,KAAK,CACf,iBAAiB,IAAI,uDAAuD,CAC7E,CAAC;YACF,OAAO,KAAK,CAAC;SACd;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAEO,KAAK,CAAC,cAAc;QAC1B,MAAM,eAAe,GAAG,KAAK,IAAI,EAAE;YACjC,iDAAiD;YACjD,IAAI,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE;gBACzD,IAAI,CAAC,MAAM,CAAC,KAAK,CACf,8DAA8D,CAC/D,CAAC;gBACF,OAAO,EAAE,CAAC;aACX;YACD,MAAM,MAAM,GAAG,IAAA,yBAAY,EAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YAC7C,IAAI;gBACF,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,OAAO,CACnC,8DAA8D,EAC9D;oBACE,KAAK,EAAE,IAAI,CAAC,aAAa,CAAC,KAAK;oBAC/B,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI;iBAC9B,CACF,CAAC;gBACF,OAAO,QAAQ,CAAC,IAAI,CAAC;aACtB;YAAC,OAAO,CAAC,EAAE;gBACV,IAAI,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,KAAK,GAAG,EAAE;oBAC3C,IAAI,CAAC,MAAM,CAAC,OAAO,CACjB,gGAAgG;wBAC9F,oEAAoE;wBACpE,qFAAqF;wBACrF,kFAAkF,CAAC,EAAE,CACxF,CAAC;iBACH;qBAAM;oBACL,uFAAuF;oBACvF,mFAAmF;oBACnF,2FAA2F;oBAC3F,qBAAqB;oBACrB,MAAM,IAAI,KAAK,CACb,4DAA4D,CAAC,EAAE,CAChE,CAAC;iBACH;aACF;QACH,CAAC,CAAC;QAEF,MAAM,WAAW,GAAG,IAAI,CAAC,iBAAiB,IAAI,CAAC,MAAM,eAAe,EAAE,CAAC,CAAC;QACxE,IAAI,CAAC,iBAAiB,GAAG,WAAW,CAAC;QACrC,OAAO,WAAW,CAAC;IACrB,CAAC;CACF;AA5ED,gDA4EC;AAED;;;;GAIG;AACH,SAAgB,kBAAkB,CAAC,YAA2B;IAC5D,OAAO;QACL,QAAQ,EAAE,KAAK,EAAE,IAAI,EAAE,EAAE;YACvB,OAAO,YAAY,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QACrC,CAAC;KACF,CAAC;AACJ,CAAC;AAND,gDAMC"} \ No newline at end of file +{"version":3,"file":"feature-flags.js","sourceRoot":"","sources":["../src/feature-flags.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;AAAA,6CAA8D;AAG9D,6CAA+B;AAM/B,IAAY,WAKX;AALD,WAAY,WAAW;IACrB,kEAAmD,CAAA;IACnD,qEAAsD,CAAA;IACtD,0DAA2C,CAAA;IAC3C,iGAAkF,CAAA;AACpF,CAAC,EALW,WAAW,GAAX,mBAAW,KAAX,mBAAW,QAKtB;AAUD,MAAa,kBAAkB;IAG7B,YACU,aAAiC,EACjC,UAA4B,EAC5B,aAA4B,EAC5B,MAAc;QAHd,kBAAa,GAAb,aAAa,CAAoB;QACjC,eAAU,GAAV,UAAU,CAAkB;QAC5B,kBAAa,GAAb,aAAa,CAAe;QAC5B,WAAM,GAAN,MAAM,CAAQ;IACrB,CAAC;IAEJ,KAAK,CAAC,QAAQ,CAAC,IAAiB;QAC9B,+DAA+D;QAC/D,OAAO,IAAI,CAAC;QAEZ,uDAAuD;QACvD,4EAA4E;QAC5E,kBAAkB;QAClB,IAAI;QAEJ,gDAAgD;QAChD,gCAAgC;QAChC,uBAAuB;QACvB,4EAA4E;QAC5E,OAAO;QACP,kBAAkB;QAClB,IAAI;QACJ,oCAAoC;QACpC,iCAAiC;QACjC,uBAAuB;QACvB,mFAAmF;QACnF,OAAO;QACP,kBAAkB;QAClB,IAAI;QACJ,oBAAoB;IACtB,CAAC;IAEO,KAAK,CAAC,cAAc;QAC1B,MAAM,eAAe,GAAG,KAAK,IAAI,EAAE;YACjC,iDAAiD;YACjD,IAAI,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE;gBACzD,IAAI,CAAC,MAAM,CAAC,KAAK,CACf,8DAA8D,CAC/D,CAAC;gBACF,OAAO,EAAE,CAAC;aACX;YACD,MAAM,MAAM,GAAG,IAAA,yBAAY,EAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YAC7C,IAAI;gBACF,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,OAAO,CACnC,8DAA8D,EAC9D;oBACE,KAAK,EAAE,IAAI,CAAC,aAAa,CAAC,KAAK;oBAC/B,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,IAAI;iBAC9B,CACF,CAAC;gBACF,OAAO,QAAQ,CAAC,IAAI,CAAC;aACtB;YAAC,OAAO,CAAC,EAAE;gBACV,IAAI,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,KAAK,GAAG,EAAE;oBAC3C,IAAI,CAAC,MAAM,CAAC,OAAO,CACjB,gGAAgG;wBAC9F,oEAAoE;wBACpE,qFAAqF;wBACrF,kFAAkF,CAAC,EAAE,CACxF,CAAC;iBACH;qBAAM;oBACL,uFAAuF;oBACvF,mFAAmF;oBACnF,2FAA2F;oBAC3F,qBAAqB;oBACrB,MAAM,IAAI,KAAK,CACb,4DAA4D,CAAC,EAAE,CAChE,CAAC;iBACH;aACF;QACH,CAAC,CAAC;QAEF,MAAM,WAAW,GAAG,IAAI,CAAC,iBAAiB,IAAI,CAAC,MAAM,eAAe,EAAE,CAAC,CAAC;QACxE,IAAI,CAAC,iBAAiB,GAAG,WAAW,CAAC;QACrC,OAAO,WAAW,CAAC;IACrB,CAAC;CACF;AA/ED,gDA+EC;AAED;;;;GAIG;AACH,SAAgB,kBAAkB,CAAC,YAA2B;IAC5D,OAAO;QACL,QAAQ,EAAE,KAAK,EAAE,IAAI,EAAE,EAAE;YACvB,OAAO,YAAY,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QACrC,CAAC;KACF,CAAC;AACJ,CAAC;AAND,gDAMC"} \ No newline at end of file diff --git a/src/feature-flags.ts b/src/feature-flags.ts index 46c79b7ce..466c7582c 100644 --- a/src/feature-flags.ts +++ b/src/feature-flags.ts @@ -33,26 +33,29 @@ export class GitHubFeatureFlags implements FeatureFlags { ) {} async getValue(flag: FeatureFlag): Promise { - // Bypassing the toolcache is disabled in test mode. - if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) { - return false; - } + // Always return true for purposes of investigation in this PR. + return true; - const response = await this.getApiResponse(); - if (response === undefined) { - this.logger.debug( - `No feature flags API response for ${flag}, considering it disabled.` - ); - return false; - } - const flagValue = response[flag]; - if (flagValue === undefined) { - this.logger.debug( - `Feature flag '${flag}' undefined in API response, considering it disabled.` - ); - return false; - } - return flagValue; + // // Bypassing the toolcache is disabled in test mode. + // if (flag === FeatureFlag.BypassToolcacheEnabled && util.isInTestMode()) { + // return false; + // } + + // const response = await this.getApiResponse(); + // if (response === undefined) { + // this.logger.debug( + // `No feature flags API response for ${flag}, considering it disabled.` + // ); + // return false; + // } + // const flagValue = response[flag]; + // if (flagValue === undefined) { + // this.logger.debug( + // `Feature flag '${flag}' undefined in API response, considering it disabled.` + // ); + // return false; + // } + // return flagValue; } private async getApiResponse(): Promise {