github/codeql-action
0
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-04-26 16:58:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Henry Mercer
2026-03-03 18:48:23 +01:00
parent f654d61146
commit 776fd85f8c
4 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config-utils.ts
+10 -9
View File
@@ -702,21 +702,15 @@ async function getOverlayFeatureDisabledReason(
/** Checks if the runner has enough disk space for overlay analysis. */
function runnerHasSufficientDiskSpace(
diskUsage: DiskUsage | undefined,
diskUsage: DiskUsage,
logger: Logger,
useV2ResourceChecks: boolean,
): boolean {
const minimumDiskSpaceBytes = useV2ResourceChecks
? OVERLAY_MINIMUM_AVAILABLE_DISK_SPACE_V2_BYTES
: OVERLAY_MINIMUM_AVAILABLE_DISK_SPACE_BYTES;
if (
diskUsage === undefined ||
diskUsage.numAvailableBytes < minimumDiskSpaceBytes
) {
const diskSpaceMb =
diskUsage === undefined
? 0
: Math.round(diskUsage.numAvailableBytes / 1_000_000);
if (diskUsage.numAvailableBytes < minimumDiskSpaceBytes) {
const diskSpaceMb = Math.round(diskUsage.numAvailableBytes / 1_000_000);
const minimumDiskSpaceMb = Math.round(minimumDiskSpaceBytes / 1_000_000);
logger.info(
`Setting overlay database mode to ${OverlayDatabaseMode.None} ` +
@@ -772,6 +766,13 @@ async function getResourceDisabledReason(
logger: Logger,
useV2ResourceChecks: boolean,
): Promise<OverlayDisabledReason | undefined> {
if (diskUsage === undefined) {
logger.info(
`Unable to determine available disk space for overlay analysis. ` +
`Setting overlay database mode to ${OverlayDatabaseMode.None}.`,
);
return OverlayDisabledReason.UnableToDetermineDiskUsage;
}
if (!runnerHasSufficientDiskSpace(diskUsage, logger, useV2ResourceChecks)) {
return OverlayDisabledReason.InsufficientDiskSpace;
}