Address review comments

This commit is contained in:
Henry Mercer
2026-03-03 18:48:23 +01:00
parent f654d61146
commit 776fd85f8c
4 changed files with 24 additions and 14 deletions
+8 -2
View File
@@ -106415,8 +106415,8 @@ async function getOverlayFeatureDisabledReason(features, codeql, languages, code
}
function runnerHasSufficientDiskSpace(diskUsage, logger, useV2ResourceChecks) {
const minimumDiskSpaceBytes = useV2ResourceChecks ? OVERLAY_MINIMUM_AVAILABLE_DISK_SPACE_V2_BYTES : OVERLAY_MINIMUM_AVAILABLE_DISK_SPACE_BYTES;
if (diskUsage === void 0 || diskUsage.numAvailableBytes < minimumDiskSpaceBytes) {
const diskSpaceMb = diskUsage === void 0 ? 0 : Math.round(diskUsage.numAvailableBytes / 1e6);
if (diskUsage.numAvailableBytes < minimumDiskSpaceBytes) {
const diskSpaceMb = Math.round(diskUsage.numAvailableBytes / 1e6);
const minimumDiskSpaceMb = Math.round(minimumDiskSpaceBytes / 1e6);
logger.info(
`Setting overlay database mode to ${"none" /* None */} due to insufficient disk space (${diskSpaceMb} MB, needed ${minimumDiskSpaceMb} MB).`
@@ -106448,6 +106448,12 @@ async function runnerHasSufficientMemory(codeql, ramInput, logger) {
return true;
}
async function getResourceDisabledReason(codeql, diskUsage, ramInput, logger, useV2ResourceChecks) {
if (diskUsage === void 0) {
logger.info(
`Unable to determine available disk space for overlay analysis. Setting overlay database mode to ${"none" /* None */}.`
);
return "unable-to-determine-disk-usage" /* UnableToDetermineDiskUsage */;
}
if (!runnerHasSufficientDiskSpace(diskUsage, logger, useV2ResourceChecks)) {
return "insufficient-disk-space" /* InsufficientDiskSpace */;
}