Move getDefaultCliVersion out of GitHubFeatureFlags

It doesn't need to be in there since it doesn't depend on the API itself and call `getDefaultCliVersionFromFlags` directly
This commit is contained in:
Michael B. Gale
2026-02-12 17:39:03 +00:00
parent ea1a400e13
commit 5283c3ba5a
8 changed files with 56 additions and 83 deletions
+7 -13
View File
@@ -378,7 +378,13 @@ export class Features implements FeatureEnablement {
async getDefaultCliVersion(
variant: util.GitHubVariant,
): Promise<CodeQLDefaultVersionInfo> {
return await this.gitHubFeatureFlags.getDefaultCliVersion(variant);
if (supportsFeatureFlags(variant)) {
return await this.gitHubFeatureFlags.getDefaultCliVersionFromFlags();
}
return {
cliVersion: defaults.cliVersion,
tagName: defaults.bundleVersion,
};
}
/**
@@ -524,18 +530,6 @@ class GitHubFeatureFlags {
return version;
}
async getDefaultCliVersion(
variant: util.GitHubVariant,
): Promise<CodeQLDefaultVersionInfo> {
if (supportsFeatureFlags(variant)) {
return await this.getDefaultCliVersionFromFlags();
}
return {
cliVersion: defaults.cliVersion,
tagName: defaults.bundleVersion,
};
}
async getDefaultCliVersionFromFlags(): Promise<CodeQLDefaultVersionInfo> {
const response = await this.getAllFeatures();