Address review comments

This commit is contained in:
Henry Mercer
2026-03-04 17:38:24 +01:00
parent 5fa8dad095
commit 4cd47adfe1
2 changed files with 10 additions and 14 deletions
+5 -10
View File
@@ -869,21 +869,16 @@ export async function getOverlayDatabaseMode(
const checkOverlayStatus = await features.getValue(
Feature.OverlayAnalysisStatusCheck,
);
const diskUsage =
performResourceChecks || checkOverlayStatus
? await checkDiskUsage(logger)
: undefined;
if (
(performResourceChecks || checkOverlayStatus) &&
diskUsage === undefined
) {
const needDiskUsage = performResourceChecks || checkOverlayStatus;
const diskUsage = needDiskUsage ? await checkDiskUsage(logger) : undefined;
if (needDiskUsage && diskUsage === undefined) {
logger.warning(
`Unable to determine disk usage, therefore setting overlay database mode to ${OverlayDatabaseMode.None}.`,
);
return new Failure(OverlayDisabledReason.UnableToDetermineDiskUsage);
}
const resourceResult =
performResourceChecks && diskUsage
performResourceChecks && diskUsage !== undefined
? await checkRunnerResources(
codeql,
diskUsage,
@@ -897,7 +892,7 @@ export async function getOverlayDatabaseMode(
}
if (
checkOverlayStatus &&
diskUsage &&
diskUsage !== undefined &&
(await shouldSkipOverlayAnalysis(codeql, languages, diskUsage, logger))
) {
logger.info(