github/codeql-action
0
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-04-02 01:32:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Object.entries() instead of checking hasOwnProperty

Browse Source 
Co-authored-by: Robert <robertbrignull@github.com>
This commit is contained in:
Alex Kalyvitis
2020-06-19 13:27:45 +02:00
committed by GitHub
parent 5eccb79587
commit 34c941dc31
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/setup-tools.test.ts
View File

@@ -49,18 +49,14 @@ test('parse codeql bundle url version', t => {
'1.2.3-beta.1': '1.2.3-beta.1',
};
for (const version in tests) {
if (tests.hasOwnProperty(version)) {
for (const [version, expectedVersion] of Object.entries(tests)) {
const url = `https://github.com/.../codeql-bundle-${version}/...`;
const expectedVersion = tests[version];
const url = `https://github.com/.../codeql-bundle-${version}/...`;
try {
const parsedVersion = setupTools.getCodeQLURLVersion(url);
t.deepEqual(parsedVersion, expectedVersion);
} catch (e) {
t.fail(e.message);
}
try {
const parsedVersion = setupTools.getCodeQLURLVersion(url);
t.deepEqual(parsedVersion, expectedVersion);
} catch (e) {
t.fail(e.message);
}
}
});