mirror of
https://github.com/github/codeql-action.git
synced 2026-04-26 16:58:47 +00:00
Address review comments
This commit is contained in:
@@ -374,6 +374,7 @@ test("saves overlay status when overlay-base analysis did not complete successfu
|
||||
attemptedToBuildOverlayBaseDatabase: true,
|
||||
builtOverlayBaseDatabase: false,
|
||||
job: {
|
||||
checkRunId: undefined,
|
||||
workflowRunId: 12345,
|
||||
workflowRunAttempt: 1,
|
||||
name: "analyze",
|
||||
|
||||
@@ -283,7 +283,7 @@ async function recordOverlayStatus(
|
||||
attemptedToBuildOverlayBaseDatabase: true,
|
||||
builtOverlayBaseDatabase: false,
|
||||
},
|
||||
Number.isNaN(checkRunId) ? undefined : checkRunId,
|
||||
checkRunId !== undefined && checkRunId >= 0 ? checkRunId : undefined,
|
||||
);
|
||||
|
||||
const diskUsage = await checkDiskUsage(logger);
|
||||
|
||||
@@ -74,7 +74,7 @@ export function createOverlayStatus(
|
||||
workflowRunId: getWorkflowRunID(),
|
||||
workflowRunAttempt: getWorkflowRunAttempt(),
|
||||
name: getRequiredEnvParam("GITHUB_JOB"),
|
||||
...(checkRunId !== undefined && { checkRunId }),
|
||||
checkRunId,
|
||||
};
|
||||
return {
|
||||
...attributes,
|
||||
|
||||
Reference in New Issue
Block a user