Address review comments

This commit is contained in:
Henry Mercer
2026-03-04 12:16:54 +01:00
parent 129d771399
commit 281b265245
4 changed files with 5 additions and 4 deletions
+1
View File
@@ -374,6 +374,7 @@ test("saves overlay status when overlay-base analysis did not complete successfu
attemptedToBuildOverlayBaseDatabase: true,
builtOverlayBaseDatabase: false,
job: {
checkRunId: undefined,
workflowRunId: 12345,
workflowRunAttempt: 1,
name: "analyze",
+1 -1
View File
@@ -283,7 +283,7 @@ async function recordOverlayStatus(
attemptedToBuildOverlayBaseDatabase: true,
builtOverlayBaseDatabase: false,
},
Number.isNaN(checkRunId) ? undefined : checkRunId,
checkRunId !== undefined && checkRunId >= 0 ? checkRunId : undefined,
);
const diskUsage = await checkDiskUsage(logger);
+1 -1
View File
@@ -74,7 +74,7 @@ export function createOverlayStatus(
workflowRunId: getWorkflowRunID(),
workflowRunAttempt: getWorkflowRunAttempt(),
name: getRequiredEnvParam("GITHUB_JOB"),
...(checkRunId !== undefined && { checkRunId }),
checkRunId,
};
return {
...attributes,