github/codeql-action
0
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-04-27 17:39:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid mutating languages array in overlay status functions

Browse Source 
Use [...languages].sort() instead of languages.sort() to avoid
mutating the caller's array as a side effect.
This commit is contained in:
Henry Mercer
2026-02-17 13:38:11 +00:00
parent 5c583bbb19
commit 05d4e25296
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/overlay/status.ts
+3 -3
View File
@@ -81,7 +81,7 @@ export async function getOverlayStatus(
const statusFile = path.join(
getTemporaryDirectory(),
"overlay-status",
languages.sort().join("+"),
[...languages].sort().join("+"),
STATUS_FILE_NAME,
);
await fs.promises.mkdir(path.dirname(statusFile), { recursive: true });
@@ -132,7 +132,7 @@ export async function saveOverlayStatus(
const statusFile = path.join(
getTemporaryDirectory(),
"overlay-status",
languages.sort().join("+"),
[...languages].sort().join("+"),
STATUS_FILE_NAME,
);
await fs.promises.mkdir(path.dirname(statusFile), { recursive: true });
@@ -174,5 +174,5 @@ export async function getCacheKey(
// Include the CodeQL version in the cache key so we will try again to use overlay analysis when
// new queries and libraries that may be more efficient are released.
return `codeql-overlay-status-${languages.sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
return `codeql-overlay-status-${[...languages].sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
}