github/codeql-action
0
0
Fork 0
mirror of https://github.com/github/codeql-action.git synced 2026-05-01 19:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid mutating languages array in overlay status functions

Browse Source 
Use [...languages].sort() instead of languages.sort() to avoid
mutating the caller's array as a side effect.
This commit is contained in:
Henry Mercer
2026-02-17 13:38:11 +00:00
parent 5c583bbb19
commit 05d4e25296
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/init-action.js
Generated
+2 -2
View File
@@ -105730,7 +105730,7 @@ async function getOverlayStatus(codeql, languages, diskUsage, logger) {
const statusFile = path7.join(
getTemporaryDirectory(),
"overlay-status",
languages.sort().join("+"),
[...languages].sort().join("+"),
STATUS_FILE_NAME
);
await fs5.promises.mkdir(path7.dirname(statusFile), { recursive: true });
@@ -105763,7 +105763,7 @@ async function getOverlayStatus(codeql, languages, diskUsage, logger) {
}
async function getCacheKey(codeql, languages, diskUsage) {
const diskSpaceToNearest10Gb = `${10 * Math.floor(diskUsage.numTotalBytes / (10 * 1024 * 1024 * 1024))}GB`;
return `codeql-overlay-status-${languages.sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
return `codeql-overlay-status-${[...languages].sort().join("+")}-${(await codeql.getVersion()).version}-runner-${diskSpaceToNearest10Gb}`;
}
// src/trap-caching.ts