If a call to `vcpkg_replace_string` makes no changes i.e doesn't
effectively replace a string, A warning is logged.
This should also help identify ports that no longer need these calls to
fix things in `.pc` files etc.
Avoid wrong use of popular but ambiguous variables (`WIN32` etc.) in
scripts and portfiles by detection in CI.
Sometimes the variables are used wrongly, and sometimes this isn't
caught in PR review. This PR tries to catch those variables (when in the
active code path in script mode). [This can happen to every
contributor](https://github.com/microsoft/vcpkg/pull/34356#discussion_r1360074122),
even if he/she knows the rules ... vcpkg is raising the bar higher than
usual, having to deal with targets and hosts even in script mode.
(`b2-options.cmake` (boost fragment) shows where we get if we don't pay
attention: the same code being used in script mode (`WIN32` meaning
host) and in project mode (`WIN32` meaning target).)
The new check doesn't break any user builds because it relies on command
line options. However it changes the ABI hashes.
Fixes#37189
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] The name of the port matches an existing name for this component
on https://repology.org/ if possible, and/or is strongly associated with
that component on search engines.
- [x] Optional dependencies are resolved in exactly one way. For
example, if the component is built with CMake, all `find_package` calls
are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or
disabled with
[CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html).
- [x] The versioning scheme in `vcpkg.json` matches what upstream says.
- [x] The license declaration in `vcpkg.json` matches what upstream
says.
- [x] The installed as the "copyright" file matches what upstream says.
- [x] The source code of the component installed comes from an
authoritative source.
- [x] The generated "usage text" is accurate. See
[adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md)
for context.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is in the new port's versions file.
- [x] Only one version is added to each modified port's versions file.
---------
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [ ] The "supports" clause reflects platforms that may be fixed by this
new version.
- [ ] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [ ] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
# Changes
- Add `vcpkg_cmake_config_fixup()`. Without it, we had problems like
```shell
CMake Warning at $VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake:639
(_add_library):
Cannot generate a safe dependent library path for target CoveoTarget
because
there is a cycle in the constraint graph:
dir 0 is [/builds/build/vcpkg_installed/arm64-linux-dynamic/debug/lib]
dir 1 must precede it due to runtime library [libhareflow.so]
dir 1 is [/builds/build/vcpkg_installed/arm64-linux-dynamic/lib]
dir 0 must precede it due to runtime library [libaws-cpp-sdk-sqs.so]
Some of these libraries may not be found correctly.
Call Stack (most recent call first):
CoveoTarget/CMakeLists.txt:1 (add_library)
```
because `IMPORTED_LOCATION_DEBUG` was missing.
- Minor update to the port from version 0.1.0 to 0.1.1. This integrates
a pull request by @BillyONeal (thanks!) where some missing headers were
added. Following this pull request, we don't need the patch anymore.
c.c. @yrivardmulrooney, @dalloriam: this might interest you.
# Housekeeping
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
---------
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
Fixes#38181.
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
Add new CMake target `harfbuzz::harfbuzz-subset` and new feature
`experimental-api`
---------
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: Jon <v-zhli17@microsoft.com>
<!-- If your PR fixes issues, please note that here by adding "Fixes
#NNNNNN." for each fixed issue on separate lines. -->
<!-- If you are still working on the PR, open it as a Draft:
https://github.blog/2019-02-14-introducing-draft-pull-requests/. -->
<!-- If this PR updates an existing port, please uncomment and fill out
this checklist:
- [ ] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] SHA512s are updated for each updated download.
- [ ] The "supports" clause reflects platforms that may be fixed by this
new version.
- [ ] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [ ] Any patches that are no longer applied are deleted from the port's
directory.
- [ ] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [ ] Only one version is added to each modified port's versions file.
END OF PORT UPDATE CHECKLIST (delete this line) -->
<!-- If this PR adds a new port, please uncomment and fill out this
checklist: -->
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] The name of the port matches an existing name for this component
on https://repology.org/ if possible, and/or is strongly associated with
that component on search engines.
- [x] Optional dependencies are resolved in exactly one way. For
example, if the component is built with CMake, all `find_package` calls
are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or
disabled with
[CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html).
- [x] The versioning scheme in `vcpkg.json` matches what upstream says.
- [x] The license declaration in `vcpkg.json` matches what upstream
says.
- [x] The installed as the "copyright" file matches what upstream says.
- [x] The source code of the component installed comes from an
authoritative source.
- [x] The generated "usage text" is accurate. See
[adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md)
for context.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is in the new port's versions file.
- [x] Only one version is added to each modified port's versions file.
- [X] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md)
- [X] SHA512s are updated for each updated download
- [ ] ~The "supports" clause reflects platforms that may be fixed by
this new version~
- [ ] ~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~
- [ ] ~Any patches that are no longer applied are deleted from the
port's directory.~
- [X] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [X] Only one version is added to each modified port's versions file.
<!-- If your PR fixes issues, please note that here by adding "Fixes
#NNNNNN." for each fixed issue on separate lines. -->
Fixes
https://github.com/microsoft/vcpkg/pull/32661#issuecomment-1954949791
All features passed with following triplets:
x86-windows
x64-windows
<!-- If you are still working on the PR, open it as a Draft:
https://github.blog/2019-02-14-introducing-draft-pull-requests/. -->
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
<!-- If this PR adds a new port, please uncomment and fill out this
checklist:
- [ ] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] The name of the port matches an existing name for this component
on https://repology.org/ if possible, and/or is strongly associated with
that component on search engines.
- [ ] Optional dependencies are resolved in exactly one way. For
example, if the component is built with CMake, all `find_package` calls
are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or
disabled with
[CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html).
- [ ] The versioning scheme in `vcpkg.json` matches what upstream says.
- [ ] The license declaration in `vcpkg.json` matches what upstream
says.
- [ ] The installed as the "copyright" file matches what upstream says.
- [ ] The source code of the component installed comes from an
authoritative source.
- [ ] The generated "usage text" is accurate. See
[adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md)
for context.
- [ ] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [ ] Only one version is in the new port's versions file.
- [ ] Only one version is added to each modified port's versions file.
END OF NEW PORT CHECKLIST (delete this line) -->
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
* [vulkan-sdk] Separate port
* Update ci.baseline.txt
* [hikogui] Using glslc from shaderc
* [vulkan] Drop LICENSE.txt
* [vulkan-sdk-components] Avoid vulkan-sdk name
* [vulkan] Fixup copyright text
* [hwinfo] create a new port
* [hwinfo] update baseline
* [hwinfo] can't use WbemIdl in UWP
* [hwinfo] suppress NO_OCL unused
* it's just not accessed in CMakeLists.txt
* [hwinfo] fix NO_OCL expression
* Install vulkan.
* add gfxreconstruct
* format manifest and cr changes
* remove moltenvk
* fix ci part 1
* fix a dep
* more fixes
* remove vulkan failures from CI pipeline
* remove annoying stuff to deal with in static builds
* fix trailing ,
* remove vendored cmakelists
* force ci to be green
* format manifest
* Fix more ci issues
* fix hikogui
* make ci happier
* add jsoncpp dep
* only remove the debug folder if targeting windows
* bump port-version
* v db
* vulkan-loader add usage
* Rename vulkantools to lunarg-vulkantools
* Make VMA install headers platform dependent
* Remove vcpkg_check_linkage
* readd vulkan-validationlayers
* v db
* make 'cairo' an optional feature for 'harfbuzz'
* regenerate versions
* add 'defaulti-features : false' for feature 'cairo'
* regenerate versions
* add 'freetype' as a feature for feature 'cairo'
* regenerate versions
* Xbox triplets should not support ports with only copyleft licenses
* Reverted ports that build with xbox currently
* Fix conflict and rebase
* Update baseline
* Update baseline
* Updated hidapi to 0.14.0
Added new feature pp-data-dump, to make the build of the new pp_data_dump.exe developer tool optional
* Use vcpkg_copy_tools for pp_data_dump
* Removed unnecessary added empty lines from portfile
* Use ${VERSION} variable in portfile instead of hardcoded version number
* [harfbuzz] update to 7.1.0 (microsoft#30851)
* [harfbuzz] regenerate versions registries (microsoft#30851)
---------
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* fix SHA
* Update version database
* add local patch from PR669 instead of download it
* Update version database
* update port-version
* update port-version
* Update highfive.json
* set patch from url as before
* Update version database
* add full_index in the url
* Update version database
---------
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
* [cgns] update to 4.2.0
* [vtk-m] update to 1.6.0
* [vtk] Update to 9.0.1-pv5.9.1
- VTK update to match release version of ParaView
* [ParaView] Update to 5.9.1
* version stuff
* fix automatic svg linkage in static builds
* update qt5-svg
* revisit vtk
- fix build with vtk-m 1.6
- remove unused patches
- remove comments
* bump version
* remove two commented lines
* version stuff
* remove old PR version
* commit stuff
* commit stuff
* update notes
* wip commit
* update paraview
* fix hdf5 patch
* fix patch
* fix patch
* fix portfile
* add mpi feature
* format manifest
* use relativ path
* trace
* retry
* move qml files again
* try with host triplet
* - use VCPKG_CRT_LINKAGE
- use METIS not metis
* fix casing Zlib
* hopefully more fixes on other platforms.
* fix patch
* fix missing ws
* fix typos
* scale down to warning
* revert jsoncpp change
fix zoltan on osx?
* move trace option to failing port
* move trace option to failing port
* Revert "trilinos vcpkg.json changes"
* verdict fix osx build ?
* fix patch
* fix internal find_package call
* also apply correct case for metis
* disable METIS on osx
* vtk-m don't support arm.
* force more features in Ci
* fix missing ,
* more fixes
* more vtk python try and error.
* - paraview python setup same as vtk
- remove openvr from platforms not supporting it
- trace openimageio
* fix case and remove fmt for openimageio.
* trying to fix stuff
* set hash to 0
* [skip actions] add missing module
* WebCore module moved to paraview&python
* fixes
* remove patch in vtk-dicom
* add var to maybe unused
* use correct 5.11 ref instead of the one in release
* Patch cleanup round 1
* remove empty patch parts
* fix vtkm configs
* reintegrate jsoncpp.patch
* fix patch
* add single seacas/kokkos/zoltan ports
* throw out trilinos, zoltan, kokkos
replace trilinos with seacas
make seacas work for dynamic windows
* fix mpi feature
* fix dependency
* retry dep fix
* rename target
* remove double line
* fix target
* fix patch
* retry
* remove cgns config
* fix cgns
* no seacas trace
* lowercase hdf5 target
* fix case of metis
* disable Fortran
* add iotr patch
* add additional config folder
* handel case sensitive Seacas again
* get trace again and force jsoncpp
* update cmake to 3.25.0
* bump port-version
* add patch from vtk upstream
* cleanup, format-manifest
* fix port version
* v db
* opencv4 always inject deps.
* fix test port to not require stuff which is not supported on x86
* Fix HDF5 lookup in opencv4
* only delete bin folder in static builds
* add license field
* v db
* add missing "
* v db
* trace again
* fix rtabmap python dep
* fix openimageio by deleting the find module
* v db
* cr cleanup
* v db
* opencv4 v db due to merge with master. Had to bump port version
* v db
* v db
* v db
* CR comments
* v db for cr comments
* trace theia output
* revert theia trace
* v db
* try without patch
* revert rtabmap changes
* v db after merge
* v db for all
