On MS Windows qt5-webengine fails to build in a context where protobuf
from vcpkg is also used because it includes the vcpkg supplied version
of protobuf headers when building the Qt part of the code in
qt5-webengine, against the internal copy of Chromium which has used its
older copy of protobuf to generate the headers. The build failure seen
is this:
FAILED: obj/QtWebEngineCore/browser_message_filter_qt.obj
...
...
C:\vcpkgroot\qt5-webengine\x64-windows-dbg\src\core\debug\gen\net/third_party/quiche/src/quic/core/proto/cached_network_parameters.pb.h(17):
fatal error C1189: #error: This file was generated by an older version
of protoc which is
To work around this issue we ensure that the path to the chromium
provided version of protobuf is included before the path to the vcpkg
provided includes residing in:
C:/vcpkgroot/qt5-webengine/x64-windows-dbg/include
Fixes#12150Fixes#27932Fixes#34452
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
These are dependencies that must otherwise be provided by the operating
system. libdbus-1.so, at least on some Linux distributions, depends on
other system provided libraries like liblz4.so, libzstd.so, and
liblzma.so. It was necessary to cherry-pick two patches for the chromium
embedded in qtwebengine to make it build with ICU 74.
- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.
* [qt5-webengine] remove build_3.with_missing_stdbool_include.patch from qt5-webengine
* [qt5-webengine] remove workaround-msvc2022-ice.patch from qt5-webengine
* [qt5-webengine] increase port version number
* [qt5-webengine] updated versions to include qt5-webengine port version 5.15.10#1
* [qt5-webengine] add missing includes in third party libraries
This fixes issue #30006. Newer versions of msvc require more includes than previous versions. To accommodate this change, two missing includes are added to the third party libraries chromium and libxml.
* [qt5-webengine] update port number
* [qt5-webengine] restore LF line endings on patch
* [qt5-webengine] re-run vcpkg x-add-version for qt5-webengine port-version 3
* [qt5-webengine] Manually add nodejs to the path (microsoft#23574)
The build process requires nodejs to be in PATH when webengine is
built, and will build only the pdf-plugin if it's not (see #23574)
* [qt5-webengine] Workaround MSVC2022 Internal Compiler Error
(microsoft#23574)
Add a patch based on
https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/407582
which was merged into upstream. We can't take the upstream patch
directly, because the patch was committed to the chromium
(sub)repository which is a subdirectory in the release zip file, i.e.
I had to modify the pathnames for the patch to apply
* [qt5-webengine] Update diagnostics (microsoft#23574)
I've spotted the linker using 16GB singlehandedly on the release
(opposed to "debug") packaging, and emory consumption was almost
permanently over 32GB while compiling, though peak memory
consumption can be reduced by setting up low values for
VCPKG_MAX_CONCURRENY
Also, reword the build-prefix-too-long message
* [qt5-webengine] Attempt enabling windows ci baselines (microsoft#23574)
* [qt5-webengine] Regenerate version registries (microsoft#23574)
* Also remove out of date comments from ci.baseline.txt referring to deleted lines.
* Revert "Also remove out of date comments from ci.baseline.txt referring to deleted lines."
This reverts commit 7a4d84643102231bf8e60f2340db970c8775a607.
* [qt5-webengine] Re-add webengine blacklisting to ci.baseline (microsoft#23574)
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* [qt5-webengine]
- add feature "proprietary-codecs"
- fix build error due to internal changes how options are passed.
- try to fail early on too long build paths instead of late
* comment the ci baseline for x64-windows to actually test it in ci
and only build one configuration to not overstress the ci system
* be less strict about the buildtree path length
* adjust qt5-webengine ci back
* update baseline
* change length error message according to CR.
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* fix version
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
