* update glib to meson
* update ci baseline
* update glib to 2.66.3
remove cmakelists
* fix some minor meson issue but meson is still a mess
* add_bin_to_path to vcpkg_install_meson
* regen docs
* try fixing/touching all glib dependent ports
* fix libsigcpp-3 version
* fix glibmm
* fix gmime
* fix libcroco
* update libnice
* fix atk build
* update harfbuzz
* fix few builds
* update libxmlpp
* fix gdk-pixbuf
* fix gts
* gts add patch
* remove old libsigcpp
* add missing comma
* fix supports logic
* fix name mismatch
* restore original ci baseline.
* fix a lot of small details.
increment controls.
* fix harfbuzz & glib
* bump port version
* update port_versions
* fix version field
* update versions
* fix glib in harfbuzz
* update port versions
* silly uppercase type
* update port-versions
* fix cairo build
* update version
* fix atk
* update atk port-verisons
* fix gts public includes
* update versions
* fix cairomm
* fix pango
* fix ignition
* update versions.
* fix gtk
* fix librsvg
* update versions
* fix atk linux
* fix libgpod
* update versions
* fix lcm
* fix librsvg
* update pango and pangomm
* update pango to meson
* more updates
* update pixman
* fix cairo
* fix cairo
* some fixes
* reorder meson a bit
* add none.txt for meson
* fix x86_x64 to x86 "cross" builds
* add tiff pkgconfig
* update gdk-pixbuf
* fix tiff and jpeg
* add graphene
* fix gdk-pixbuf
* add sassc
* update gtk
* fix cairo complete build
* add harfbuzz inlcude in pango since meson does not add it into pkgconfig.
* fix gtk build. Remaining issue fix install script.
* fix gtk build
* fix io2d
* add supports field
* fix cartographer?
* fix librsvg build
* fix gtk build
* fix cartographer
* fix sassc on linux
* fix tiff and libjpeg pc files
* fix pixman x86
* _isnanf is undefined on arm-
* merge fix for make on arm64
* fix gdk-pixbuf on arm64-windows
* pixman remove test/demos.
should fix it on osx.
* [vcpkg_install_meson] add bin to path to run code generators
* [vcpkg_configure_meson]
deactivate native compiler in cross builds
make x86 on x86_x64 a native instead of a cross build
(as long as we are not building for UWP)
* pixman reenable UWP support.
* pixman reenable arm support
* add pixman:arm-uwp=fail to baseline
* update gtkmm
* remove double whitespaces
* gtk baseline
gtk dependency on cairo x11
remove double spaces in flags
* fix linux build
* native none again
* cairo fix cairo-script.pc
* comment out patch since the cairo changes should have fixed it.
* disable wayland backend in GTK since CI is missing system packages
* silly typo in cairo pc file correction
install lzo pc on windows
* remove double spaces in _FLAGS
remove unnecessary comments
* actually disabling wayland backend
* fix glib codegen issue having the wrong path
* try to fix paths in glib codegen
* integrate changes form #12860
* add the uwp patch back in
* deactivate extra harfbuzz shapers.
* vcpkg x-add-version --all --overwrite-version
* remove patches in tesseract.
* fix version
* rerun add-version
* add libgpod:x64-linux=fail to baseline due to missing system tools/libraries
* change regex to take double - into account.
* run x-add-version
* run format-manifest
* add missing removal of multiple spaces back into the regex
* remove ws diff change
* fix gtkmm the upstream way
* remove ws to reduce diff
* make glib build on osx
* format manifest
* run x-add-version
* add pthread dependency
* update baseline due to glib compiling on osx now.
* add meson as a dep to glib
* - add glib host dependencies
- switch to manifest of touched ports
* switch to manifest.
* [libxml2] add gnuinstalldirs
* [libxml2] add missing include of GNUInstallDirs
* add version info
* add include dir to pc files ....
* update version
* add UWP as crosscompiling target
* Apply suggestions from code review
* trying to fix cairo pthread detection on osx.
* fix libmicrohttpd by adding the required system frameworks on osx
* fix poppler by not removing the CXX standard
* fix missing coretext header from harfbuzz in pano
* fix formating issues
* fix librsvg on osx
* revert version changes
* bump version
* version stuff.
* fix graphene version stuff
* fix version stuff
* removing ports from ci baseline to cause me pain
* move cairomm:x64-linux=fail
to gtkmm:x64-linx=fail
remove pangomm:x64-osx=fail
* fix typo
* revert ws changes to vcpkg_install_meson
* update port version after merge
* version stuff
* fix fluidsynth by adding vcpkg_check_features
* move cairo to ci baseline on osx
* version stuff
* fluidsynth corrections
* more version stuff
* apply code review changes
* clean version stuff.
* update version stuff
* code review cleanup
* version stuff
* formating
* update version stuff again
* remove gdi again
* version stuff
* version stuff
* version baseline
* Apply strega-nil suggestions from code review
* run x-add-version
* reset versions to upstream/master
* v8 CONTROL -> json
* reset fluidsynth to upstream/master
* first batch of version-string -> version conversion
* second and last batch of version-string -> version conversions
* update version stuff
* disable gdi feature in harfbuzz (missing user32 linkage in qt5-base)
* version stuff
* Apply suggestions from code review
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* more CR stuff
* update versions
* back out provision changes so that pr can be merged.
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* Update to CUDA 11.3 on Windows.
* Update PowerShell to 7.1.3.
* Update CUDA to 11.3 on Linux.
* "Explode" VM provisioning scripts for more consistent feedback during deploy. This resolves the deployment script often hanging with no feedback as to why.
* [libdatachannel] Fix use of deprecated result_type typedef.
Submitted upstream as https://github.com/paullouisageneau/libdatachannel/pull/413
* [libvpx] Get the libvpx outputs from the correct place.
(Perhaps VS2019 version 16.10 moved where these are placed? I've been defensive and left an attempt to find from the old location in place.)
* [chromaprint] Support implementations where lrintf is an intrinsic.
* Add provision-entire-image script.
* [cudnn] Disable download-on-the-fly due to licensing concerns.
* Add libnccl to Linux VMs.
* [wangle] Disable x64-windows due to an ICE.
* [cmake] Update cmake to 3.20.1 to avoid https://gitlab.kitware.com/cmake/cmake/-/issues/21571 race
* [libudis86] Fix passing a bogus working directory which fails on CMake 3.20.x
* [dartsim] Disable unit tests, examples, and tutorials, some of which have CMake authoring errors rejected by 3.20.1.
* Add thrust to the cuda installees.
* [tensorflow] Put .bzl in CURRENT_BUILDTREES_DIR to avoid running out of disk space in CI and to respect --clean-after-build.
* [dimcli] Skip port broken by changes in VS2019 project system.
* [upb] Disable an additional warning.
* [libhv] Fix typo DISABLE_PARALLEL => DISABLE_PARALLEL_CONFIGURE
* Update pools
* Update KF5 framework to 5.73
kf5crash
- make x11 patch exclusive to linux
- enable win/macOS builds
kf5syntaxhighlighting
- fix building on non-Win by removing the cli tool from all platforms
* Add kf5auth port
* Revert "Add kf5auth port"
This reverts commit 8703c2423667f62075c34496ef273394a5b8d538.
* Add kf5globalaccel port
* Revert "Add kf5globalaccel port"
This reverts commit f1ac3db8e2019f474a09d6964aea8e21bc9da166.
* [ecm] use where possible
* [kf5holidays] use PORT placeholder where possible
* [kf5syntaxhighlighting] use PORT placeholder where possible
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [kf5plotting] use PORT placeholder where possible
* [kf5crash] fix logical condition in the patch
* [kf5crash] logical condition again, include other BSDs
* [kf5i18n] acquire python3
* [kf5i18n] remove vcpk cmake wrapper added mistakenly
* Update KF5 framework to 5.73
kf5crash
- make x11 patch exclusive to linux
- enable win/macOS builds
kf5syntaxhighlighting
- fix building on non-Win by removing the cli tool from all platforms
* Add kf5auth port
* Revert "Add kf5auth port"
This reverts commit 8703c2423667f62075c34496ef273394a5b8d538.
* Add kf5globalaccel port
* Revert "Add kf5globalaccel port"
This reverts commit f1ac3db8e2019f474a09d6964aea8e21bc9da166.
* [ecm] use where possible
* [kf5holidays] use PORT placeholder where possible
* [kf5syntaxhighlighting] use PORT placeholder where possible
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [kf5plotting] use PORT placeholder where possible
* [kf5crash] fix logical condition in the patch
* [kf5crash] logical condition again, include other BSDs
* [kf5i18n] acquire python3
* [kf5i18n] remove vcpk cmake wrapper added mistakenly
* [ecm] Remove 'skip' from windows baseline
* Fixed KF5ItemModel for windows
* [kf5syntaxhighlighting] fix Windows build
* Fixed k5syntaxhighlighting for windows
* [kf5plotting] fix license files
* [kf5archive] fix license files
* [kf5*] update to 5.75.0
* [kf5holidays] fix sha sum
* [kf5syntaxhighlighting] fix licensing
* [kf5itemviews] fix windows static build
* [kf5widgetsaddons] fix windows static build
* [kf5completion] fix windows static build
* [kf5*] fix windows static build
* [kf5i18n] fix windows static build
* [kf5windowsystem] require libxcb-res0-dev
* [kf5windowsystem] depend on qt5-x11extras
* [qt5] fix brotli reference
* Delete duplicate apt entries.
* kf5crash: fix linux build
* kf5i18n: fix Linux build
* ecm: do not override custom clang format files
* kf5i18n: fix Windows build
* [kf5*] update versions
* [kf5i18n] fix logical NOT
* [kf5syntaxhighlighting] disable parallel configure
* [kf5*] update versions
* [kf5*] convert CONTROL to manifest
* [kf5*] update versions
* [kf5*] update versioning scheme
* [ecm] syntax formatting
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [kf5syntaxhighlighting] syntax formatting
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [kf5holidays] syntax formatting
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [kf5archive] restore original line order
* [kf5holidays] restore CRLF
* [kf5archive] restore CRLF
* [kf5syntaxhighlighting] syntax formatting
* [kf5syntaxhighlighting] quotations
* [kf5syntaxhighlighting] fix \bin removal redundancy
* [kf5*] update versions
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: Kuntal Majumder <hellozee@disroot.org>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* [woff2] fix static linking and alternate toolchain
First, this change teaches the woff2 CMake configuration to
understand the vcpkg's custom unofficial-brotli pkg-config
configuration in order to support static linking. This fixes a
build failure on x64-linux or other triplets when
VCPKG_LIBRARY_LINKAGE is set to static.
Secondly, the CANONICAL_PREFIXES option for the woff2 CMake
configuration has been changed to be on by default, otherwise
custom triplets or toolchains using alternate compilers such as
Clang/LLVM or other versions of GCC will fail.
Leaving CANONICAL_PREFIXES set to OFF causes
-no-canonical-prefixes to be passed to the compiler, which
prevents symlinked compiler toolchains from working correctly.
If a user does actually need non-canonical prefixes, chances are
they will have a custom triplet or toolchain file that passes in
-no-canonical-prefixes as a CFLAG for every port, and so setting
it to ON here is a better default for vcpkg.
* [woff2] update versions
* [woff2] update control file
* [woff2] update versions
* [woff2] update ci.baseline.txt
* Update ports/woff2/0001-unofficial-brotli.patch
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
* [woff2] regenerate 0001-unofficial-brotli.patch file
* [woff2] update versions
* [woff2] regenerate 0001-unofficial-brotli.patch file attempt #2
* [woff2] update versions
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
* [qt5-base] fix glib link issues on linux
* add version
* remove unused vars
* update version
* write port info file.
* version stuff
* remove paraview from baseline. It was added due to the same spurious glib failures.
* trying out a different approach
* more changes
* change the if to actually use the buildtype instead
* remove x_vcpkg_get_port_info
* add option QT_OPENSSL_LINK back in
* use INCLUDE_DIRS_(DEBUG|RELEASE) instead of just INCLUDE_DIRS
* regen docs
* remove function call I forgot to remove
* [vcpkg-pkgconfig-get-modules] Move to port
* revert changes to ports.cmake
* include the file in qt5-base
* fix path
* remove unnecessary include
* Apply suggestions from code review
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
* Apply suggestions from code review
* update version
* ws removal
* version stuff
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
* Add control and portfile for mfl port
* Add mfl port
* reference version better header inclusion
* reference version with fmt linkage
* Apply suggestions from code review
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* Set ports that don't build to fail in the ci baseline
* add version
* Check for static linkage and add message about C++20 requirements.
* add fail to ci baseline for dynamic windows builds
* version update
* Code review improvements
- Improve warning message that the port requires a C++20 compiler
- Use `version` rather than `version-string` in manifest
- Use `"supports": "static"` in manifest instead of setting dynamic
builds to `fail` in ci baseline.
* update version
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [metrohash] exclude CRC for x86
* the change will allow x86 triplets
* update port SHA
* [metrohash] remove fail_port_install
* update ci.baseline.txt
* [metrohash] sync portfile and CMakeLists.txt
* make both file use 'VCPKG_TARGET_TRIPLET' to make ease of comparison
* [metrohash] Use try_compile helpers
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* [libbacktrace] add new port
* add version files
* Update ports/libbacktrace/portfile.cmake: Apply suggestion
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* add version files
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* fix supports field to correctly run CI for other platforms
* Merge from master
* Update baseline version
* Fix the format issue
* Fix baseline version
* Revert the changes for host
* Fix the baseline version
* Disable mpfr:x64-osx and mpfr:x64-linux in Ci testing
Co-authored-by: PhoebeHui <20694052+PhoebeHui@users.noreply.github.com>
* [liblsl] Update to 1.14.0
* Adjust CI baseline, assuming liblsl:x64-linux and liblsl:x64-osx pass
* Add back set(VCPKG_LIBRARY_LINKAGE dynamic)
* [libsls] Improve portfile.cmake, add homepage
* update version record
* Update ports/liblsl/CONTROL
* Update versions/l-/liblsl.json
* [liblsl] Use pugixml vcpkg package instead of bundled one
* Convert tabs to spaces
* Update version
* Fix Supports in liblsl/CONTROL
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* Update versions/l-/liblsl.json
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* [scripts-audit rollup] PR #16419
* pull the cmake doc comment parsing out into its own function
* support cmake helper ports
* add real support for deprecation, as opposed to ad-hoc
* [scripts-audit rollup] PR #16192
* add a z_ in front of internal functions
* move internal functions out
set feature_vars again in parent scope
* [scripts-audit rollup] PR #16309
Audit vcpkg_copy_pdbs
* [scripts-audit rollup] PR #16304
* Fix usage, documentation
* [scripts-audit rollup] PR #16393
* [scripts-audit rollup] PR #16377
Deprecate `vcpkg_*_cmake` in favor of `vcpkg_cmake_*` from the
`vcpkg-cmake` port, as well as `vcpkg_fixup_cmake_targets`
in favor of `vcpkg_cmake_config_fixup` from the
`vcpkg-cmake-config` port.
* add port workflow
* format manifest
* add versions
* add versions for all
* ignore arm_uwp and x64_uwp
* merge two portfile
* Revert "add versions for all"
This reverts commit 3806e22a7d49c80a614c08a4107ca2657001085e.
* delete unnecessary line
* update versions
* [pugixml] Update to 1.11.4
* update version
* Update ci.baseline.txt
Add paraview:x64-linux=fail
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Jonliu1993 <13720414433@163.com>
* Fixed macos build
Fixed missing libiconv library on osx build
* [libxslt] Bump version
* update version record
* update baseline
* [libxslt] Add Support field.
* update version record
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
* [tesseract] add missing reference for downstream projects
* [tesseract] restore ci, fix many regressions that are uncovered by that
* Update ports/opencv2/CONTROL
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [opencv] fix regressions on uwp, accept failure on arm64 for now
* Apply suggestions from code review
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [opencv4] allow failures on all arm windows targets, both win32 and uwp
* [OpenCV] update to v4.5, draft
* Restore CI tests on arm architectures, they will have to work!
* adopts hints from #15180
* [libarchive] bump control version
* [libarchive] use vcpkg-cmake-wrapper instead of a custom libarchiveConfig, since it is vcpkg-provided and not port-provided
* enable features to be visible in parent scope
* apply documentation fix from CI
* [libarchive] remove unnecessary lines in portfile
* update patches
* restore ci tests for all opencv4 configs
* add port versions to baseline
* [OpenCV contrib] fix glog integration
* [OpenCV4] fix target processor detection
* update version refs
* [OpenCV3] fix target processor detection
* fix also ocv3
* remove vtk feature from opencv-ci testing
* remove qt5-tools from baseline, it works locally
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [tesseract] add missing reference for downstream projects
* [tesseract] restore ci, fix many regressions that are uncovered by that
* Update ports/opencv2/CONTROL
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [opencv] fix regressions on uwp, accept failure on arm64 for now
* Apply suggestions from code review
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* [opencv4] allow failures on all arm windows targets, both win32 and uwp
* adopts hints from #15180
* [libarchive] bump control version
* [libarchive] use vcpkg-cmake-wrapper instead of a custom libarchiveConfig, since it is vcpkg-provided and not port-provided
* enable features to be visible in parent scope
* apply documentation fix from CI
* [libarchive] remove unnecessary lines in portfile
* fix regressions
* Update ports/gdcm/CONTROL
* use more compact logic syntax
* add new versions to baseline
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
* Update for directx-headers release 1.0.1
* DirectXMesh, DirectXTex, and UVAtlas now support Linux
* Updated hashes and bins
* Fix linux builds
* Fixed directxtex[openexr] for x64-linux
* Removed stray file
* directxmath hot-fix for GCC arm64
* Fixed hash
* Hash fix again
* x64-linux CIs use GCC 7, but I require GCC 9
* Added warning message for GCC 9 requirement
* [mesa] new port
* make mesa build more.
* more fine tuning
* fix x86
* add supports.
* comment about EGL feature.
* apply suggestion from CR.
added opengl feature.
error on disabled shared glapi if multiple GL APIs are selected.
* fix boolean option
* make sharedgl-api=true the hardcoded default
* add suggestion from CR
* add mesa:x64-windows-static=fail to ci.baseline.txt due to static crt and parts being a dynamic library.
* apply CR sugesstion
Co-authored-by: PhoebeHui <20694052+PhoebeHui@users.noreply.github.com>
* Update port geotrans to version 3.8
1. Added new files to CMakeLists.txt required by version 3.8
2. Remove old style CONTROL file used by vcpkg
3. Updated portfile.cmake for version 3.8
4. Add new style vcpkg.json file used by vcpkg
* Add skip to CI baseline. Add slow warning messages to portfile
* Refine warning message about long download times
* Fixed port of quirc - patch did no longer apply / modified to fix build
* Updated quirc to the latest version + removed obsolete patch-for-msvc.patch
* update baseline
* [quirc] Fix license file name
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
* [capnproto] Remove from baseline.
PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x64-windows-static (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: capnproto:x86-windows (.\scripts\ci.baseline.txt)
These were fixed by the update to VS2019 version 16.8. Other capnproto skips moved into "supports" because:
capnp.lib(serialize-packed.c++.obj) : error LNK2019: unresolved external symbol __popcnt referenced in function "int __cdecl kj::popCount(unsigned int)" (?popCount@kj@@YAHI@Z)
i.e. the port wants popcnt to exist and it doesn't, so this isn't an artifact of our CI.
* Remove "passing: remove from fail list" entries.
* [atk, atkmm, gdk-pixbuf, glibmm, gtkmm, libsigcpp, libxmlpp, pangomm] Acquire using HTTPS.
* [chardir] Update osx download.
* [leaf] Remove leaf in favor of boost-leaf.
```
Starting package 759/1414: leaf:x86-windows
Building package leaf[core]:x86-windows...
-- Downloading https://github.com/zajo/leaf/archive/0.2.2.tar.gz...
-- Extracting source D:/downloads/zajo-leaf-0.2.2.tar.gz
-- Using source at D:/buildtrees/leaf/src/0.2.2-26417cde9d.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: D:/packages/leaf_x86-windows/share/leaf/copyright
-- Performing post-build validation
-- Performing post-build validation done
Uploaded binaries to 1 HTTP remotes.
Building package leaf[core]:x86-windows... done
Installing package leaf[core]:x86-windows...
The following files are already installed in D:/installed/x86-windows and are in conflict with leaf:x86-windows
Installed by boost-leaf:x86-windows
include/boost/leaf/capture.hpp
include/boost/leaf/common.hpp
include/boost/leaf/context.hpp
include/boost/leaf/detail/all.hpp
include/boost/leaf/detail/demangle.hpp
include/boost/leaf/detail/function_traits.hpp
include/boost/leaf/detail/mp11.hpp
include/boost/leaf/detail/optional.hpp
include/boost/leaf/detail/print.hpp
include/boost/leaf/error.hpp
include/boost/leaf/exception.hpp
include/boost/leaf/result.hpp
Elapsed time for package leaf:x86-windows: 2.931 s
```
Caused by the update to Boost 1.75.0. Because this port is touching include/boost, I'm interpreting that as "the author intends users to use it as a Boost library", and have deleted this port in favor of the Boost version.
* [magic-get] Remove magic-get in favor of boost-pfr.
* Update ports/chartdir/portfile.cmake
Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>
* Restore versions.
* format-manifest
Co-authored-by: ras0219 <533828+ras0219@users.noreply.github.com>