From 75744206edd0304c5de3f6d857e412c1a2e48e9c Mon Sep 17 00:00:00 2001 From: Etienne Dechamps Date: Thu, 8 Nov 2018 07:50:51 +0000 Subject: [PATCH] [portaudio] Enable debug output (#4592) * [portaudio] Enable debug output. This is enabled by default in the original MSVC project in the PortAudio distribution, but not in their CMake build. This commit fixes the regression. I don't think there are any performance concerns with this, as PortAudio (AFAICT) does not log from performance-critical code. Note that this change might still be somewhat controversial, because PortAudio will by default dump its debug output directly to stderr, which is not particularly nice. However, the alternative is not having any way for end users to troubleshoot PortAudio issues at all, which IMHO is worse. Applications can always call `PaUtil_SetDebugPrintFunction()` to redirect the output away from stderr, and I encourage them to do so. * [portaudio] Bump control version --- ports/portaudio/portfile.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/ports/portaudio/portfile.cmake b/ports/portaudio/portfile.cmake index 3498281584..503b080483 100644 --- a/ports/portaudio/portfile.cmake +++ b/ports/portaudio/portfile.cmake @@ -26,6 +26,7 @@ vcpkg_configure_cmake( -DPA_USE_WASAPI=ON -DPA_USE_WDMKS=ON -DPA_USE_WMME=ON + -DPA_ENABLE_DEBUG_OUTPUT:BOOL=ON ) vcpkg_install_cmake()