mirror of
https://github.com/rbock/sqlpp11.git
synced 2024-11-16 04:47:18 +08:00
ac2bc0495e
- `.from(t1, t2)` produces an unconditional join if you forget to add a condition in the .where() sqlpp11 therefore now deprecates unconditional joins. - more often than not, writing something like `where(name == "doe")`, you meant to write `where(t.name == "doe")`. It is hard to find bugs when the former expression compiles because you happen to have a variable `name` in the current scope as well. sqlpp11 therefore now deprecates `.where(bool)` and disallows raw bool values boolean expression like `something and bool` wrap bools in sqlpp::value(), if you REALLY want a bool value here
135 lines
5.4 KiB
C++
135 lines
5.4 KiB
C++
/*
|
|
* Copyright (c) 2015-2015, Roland Bock
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without modification,
|
|
* are permitted provided that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
|
|
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
|
|
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
|
|
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
|
|
* OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
|
|
* OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <iostream>
|
|
#include "Sample.h"
|
|
#include "MockDb.h"
|
|
#include <sqlpp11/alias_provider.h>
|
|
#include <sqlpp11/select.h>
|
|
#include <sqlpp11/functions.h>
|
|
#include <sqlpp11/connection.h>
|
|
|
|
namespace sqlpp
|
|
{
|
|
namespace test
|
|
{
|
|
template <typename T>
|
|
void print_type_on_error(std::true_type, const T&)
|
|
{
|
|
}
|
|
|
|
template <typename T>
|
|
void print_type_on_error(std::false_type, const T& t)
|
|
{
|
|
t._print_me_;
|
|
}
|
|
|
|
template <typename Assert, typename Expression>
|
|
void run_check(const Expression&)
|
|
{
|
|
using Context = MockDb::_serializer_context_t;
|
|
using CheckResult = std::is_same<sqlpp::run_check_t<Context, Expression>, Assert>;
|
|
static_assert(CheckResult::value, "Unexpected run_check result");
|
|
print_type_on_error(CheckResult{}, sqlpp::run_check_t<Context, Expression>{});
|
|
}
|
|
|
|
template <typename Expression>
|
|
void run_check(const Expression&)
|
|
{
|
|
using Context = MockDb::_serializer_context_t;
|
|
using CheckResult = std::is_same<sqlpp::run_check_t<Context, Expression>, consistent_t>;
|
|
static_assert(CheckResult::value, "Unexpected run_check result");
|
|
print_type_on_error(CheckResult{}, sqlpp::run_check_t<Context, Expression>{});
|
|
}
|
|
}
|
|
}
|
|
|
|
namespace
|
|
{
|
|
SQLPP_ALIAS_PROVIDER(whatever)
|
|
using sqlpp::test::run_check;
|
|
static constexpr auto t = test::TabBar{};
|
|
|
|
// If there is no group_by, we can select whatever we want
|
|
void no_group_by()
|
|
{
|
|
run_check(select(all_of(t)).from(t).unconditionally());
|
|
run_check(select(t.alpha).from(t).unconditionally());
|
|
run_check(select(count(t.alpha)).from(t).unconditionally());
|
|
}
|
|
|
|
// If there is a dynamic group_by, we can still select whatever we want
|
|
// because there is no way of knowing which expressions might have been added dynamically
|
|
void dynamic_group_by()
|
|
{
|
|
run_check(select(all_of(t)).from(t).unconditionally());
|
|
run_check(select(t.alpha).from(t).unconditionally());
|
|
run_check(select(count(t.alpha)).from(t).unconditionally());
|
|
}
|
|
|
|
// If there is a static group_by, selected columns must be made of group_by expressions, or aggregate expression (e.g.
|
|
// count(t.id)) or values to be valid
|
|
void static_group_by_ok()
|
|
{
|
|
run_check(select(t.alpha).from(t).unconditionally().group_by(t.alpha));
|
|
run_check(select((t.alpha + 42).as(whatever)).from(t).unconditionally().group_by(t.alpha));
|
|
run_check(select((t.alpha + 42).as(whatever)).from(t).unconditionally().group_by(t.alpha, t.alpha + t.delta * 17));
|
|
run_check(select((t.alpha + t.delta * 17).as(whatever))
|
|
.from(t)
|
|
.unconditionally()
|
|
.group_by(t.alpha, t.alpha + t.delta * 17));
|
|
run_check(select((t.beta + "fortytwo").as(whatever)).from(t).unconditionally().group_by(t.beta));
|
|
|
|
run_check(select(avg(t.alpha)).from(t).unconditionally().group_by(t.beta));
|
|
run_check(select(count(t.alpha)).from(t).unconditionally().group_by(t.beta));
|
|
run_check(select(max(t.alpha)).from(t).unconditionally().group_by(t.beta));
|
|
run_check(select(min(t.alpha)).from(t).unconditionally().group_by(t.beta));
|
|
run_check(select(sum(t.alpha)).from(t).unconditionally().group_by(t.beta));
|
|
|
|
run_check(select((t.alpha + count(t.delta)).as(whatever)).from(t).unconditionally().group_by(t.alpha));
|
|
|
|
run_check(select(sqlpp::value(1).as(whatever)).from(t).unconditionally().group_by(t.alpha));
|
|
run_check(select(sqlpp::value("whatever").as(whatever)).from(t).unconditionally().group_by(t.alpha));
|
|
}
|
|
|
|
// Failures with static group_by and selected non-aggregates or incorrect aggregates
|
|
void static_group_by_nok()
|
|
{
|
|
run_check<sqlpp::assert_aggregates_t>(select(t.beta).from(t).unconditionally().group_by(t.alpha));
|
|
run_check<sqlpp::assert_aggregates_t>(
|
|
select((t.alpha + t.delta).as(whatever)).from(t).unconditionally().group_by(t.alpha));
|
|
run_check<sqlpp::assert_aggregates_t>(
|
|
select((t.alpha + t.delta).as(whatever)).from(t).unconditionally().group_by(t.alpha, t.alpha + t.delta * 17));
|
|
}
|
|
}
|
|
|
|
int main(int, char* [])
|
|
{
|
|
no_group_by();
|
|
dynamic_group_by();
|
|
static_group_by_ok();
|
|
static_group_by_nok();
|
|
}
|