3party/sqlpp11
0
0
Fork 0
mirror of https://github.com/rbock/sqlpp11.git synced 2024-11-16 04:47:18 +08:00
Code Issues Projects Releases Wiki Activity

Fixed bug in in() serialization

Browse Source 
in(select(...)) did have an extra set of braces, which lead to different behaviour.
Thanks to Thomas Marsh for finding the bug
This commit is contained in:
rbock 2014-10-03 08:51:27 +02:00
parent 236b367231
commit b3ef68101f
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/sqlpp11/in.h
View File

@ -79,7 +79,11 @@ namespace sqlpp
{ {
serialize(t._operand, context); serialize(t._operand, context);
context << (t._inverted ? " NOT IN(" : " IN("); context << (t._inverted ? " NOT IN(" : " IN(");
interpret_tuple(t._args, ',', context); if (sizeof...(Args) == 1)
serialize(std::get<0>(t._args), context); // FIXME: this is a bit of a hack until there is a better overall strategy for using braces
// see https://github.com/rbock/sqlpp11/issues/18
else
interpret_tuple(t._args, ',', context);
context << ')'; context << ')';
return context; return context;
} }

3
tests/InterpretTest.cpp
View File

@ -179,6 +179,9 @@ int main()
printer.reset(); printer.reset();
std::cerr << serialize(x, printer).str() << std::endl; std::cerr << serialize(x, printer).str() << std::endl;
printer.reset();
std::cerr << serialize(select(all_of(t)).from(t).where(t.alpha.in(select(f.epsilon).from(f).where(true))), printer).str() << std::endl;
return 0; return 0;