3party/raygui
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix division by zero in GuiScrollBar function (#396)

Browse Source 
When trying to use the floating window example, I got several times some crashes when expanding the window size. 
It's caused in the GuiScrollBar function, when the maxValue is equal to the minValue (I don't know if this case is intended in the first place).
Because valueRange variable is maxValue minus minValue, then it is equal to 0, and triggers a crash later, when we use it in division (division by 0).

I'm not sure if it's the best fix, maybe minValue == maxValue is not indentend in the first place and we should fix this problem earlier?
This commit is contained in:
Victor Gallet 2024-04-11 10:40:05 +02:00 committed by GitHub
parent 85549da837
commit 34ef12062c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/raygui.h
View File

@ -5173,7 +5173,9 @@ static int GuiScrollBar(Rectangle bounds, int value, int minValue, int maxValue)
if (value > maxValue) value = maxValue; if (value > maxValue) value = maxValue;
if (value < minValue) value = minValue; if (value < minValue) value = minValue;
const int valueRange = maxValue - minValue; int valueRange = maxValue - minValue;
if (valueRange <= 0) valueRange = 1;
int sliderSize = GuiGetStyle(SCROLLBAR, SCROLL_SLIDER_SIZE); int sliderSize = GuiGetStyle(SCROLLBAR, SCROLL_SLIDER_SIZE);
if (sliderSize < 1) sliderSize = 1; // TODO: Consider a minimum slider size if (sliderSize < 1) sliderSize = 1; // TODO: Consider a minimum slider size