mirror of
https://github.com/protobuf-c/protobuf-c.git
synced 2024-12-26 21:04:23 +08:00
e72e7e7e81
configure now has a "--enable-code-coverage" option, and if the
lcov/gcov tools are available a code coverage report can be built with
"make check-code-coverage".
this is mostly based on the AX_CODE_COVERAGE / GNOME_CODE_COVERAGE
macro:
http://savannah.gnu.org/patch/?8451
but i also looked at knot-dns's code coverage implementation:
https://github.com/CZNIC-Labs/knot/blob/master/m4/code-coverage.m4
and kevin lyda's pull request:
https://github.com/protobuf-c/protobuf-c/pull/131/files
88 lines
3.2 KiB
Plaintext
88 lines
3.2 KiB
Plaintext
----------------------
|
|
--- IMPORTANT TODO ---
|
|
----------------------
|
|
- ensure enums are int-size
|
|
- per comments on the main page: wire_format_inl.h is now
|
|
wire_format_lite_inl.h .. adjust somehow .. possibly write an email
|
|
- BUG? shouldn't enum..by_name[] and enum..by_number[] in the generated-code
|
|
be static??
|
|
|
|
--------------------
|
|
--- NEEDED TESTS ---
|
|
--------------------
|
|
- test:
|
|
- service method lookups
|
|
- out-of-order fields in messages (ie if the number isn't ascending)
|
|
- gaps in numbers: check that the number of ranges is correct
|
|
- default values
|
|
- message unpack alloc failures when allocating new slab
|
|
- message unpack alloc failures when allocating unknown field buffers
|
|
- packed message corruption.
|
|
- meta-todo: get a list of all the unpack errors together to check off
|
|
|
|
---------------------
|
|
--- DOCUMENTATION ---
|
|
---------------------
|
|
Document:
|
|
- services
|
|
- check over documentation again
|
|
|
|
--------------------------
|
|
--- LOW PRIORITY STUFF ---
|
|
--------------------------
|
|
- support Group (whatever it is)
|
|
- proper support for extensions
|
|
- slot for ranges in descriptor
|
|
- extends is implemented as c-style function
|
|
whose name is built from the package, the base message type-name
|
|
and the member. which takes the base message and returns the
|
|
value, if it is found in "unknown_values".
|
|
boolean package__extension_member_name__get(Message *message,
|
|
type *out);
|
|
void package__extension_member_name__set_raw(type in,
|
|
ProtobufCUnknownValue *to_init);
|
|
|
|
------------------------------------
|
|
--- EXTREMELY LOW PRIORITY STUFF ---
|
|
------------------------------------
|
|
- stop using qsort in the code generator: find some c++ish way to do it
|
|
|
|
----------------------------------------------
|
|
--- ISSUES WE ARE PROBABLY GOING TO IGNORE ---
|
|
----------------------------------------------
|
|
- strings may not contain NULs
|
|
|
|
-------------------------
|
|
--- IDEAS TO CONSIDER ---
|
|
-------------------------
|
|
|
|
- optimization: structures without repeated members could skip
|
|
the ScannedMember phase
|
|
|
|
- optimization: a way to ignore unknown-fields when unpacking
|
|
|
|
- optimization: certain functions are not well setup for WORDSIZE==64;
|
|
especially the int64 routines are inefficient that way.
|
|
The best might be an internal #define WORDSIZE (sizeof(long)*8)"
|
|
except w/ a real constant there, one that the preprocessor can use.
|
|
I think the functions in protobuf-c.c are already tagged.
|
|
|
|
- lifetime functions for messages:
|
|
message__new()
|
|
return a new message using an allocator with standard allocation policy
|
|
message__unpack_onto(...)
|
|
unpack onto an initialized message
|
|
message__clear(...)
|
|
clears all allocations, does not free the message itself
|
|
message__free(...)
|
|
free the message.
|
|
[yeah, right: after typing it out, i see it's way too complicated]
|
|
|
|
- switching to pure C.
|
|
- Rewrite the code-generator in C, including the parser.
|
|
- This would have the huge advantage that we could use ".proto" files
|
|
directly, instead of having to invoke the compilers.
|
|
- keep in a separate c file for static linking optimziation purposes
|
|
- need alignment tests
|
|
- the CAVEATS should discuss our structure-packing assumptions
|