Pieter Hintjens
79daac119a
Merge pull request #1592 from c-rack/fix-test
...
Solution: full is if number of msg is greater than hwm, not greater than hwm - 1
2015-09-25 12:26:33 +02:00
Constantin Rack
e4c06bef18
Problem: check_hwm() has different semantic of 'full'
2015-09-25 11:56:54 +02:00
Pieter Hintjens
a8605f576e
Merge pull request #1591 from c-rack/check-hwm
...
Solution: use existing check_hwm() method
2015-09-25 11:36:41 +02:00
Constantin Rack
f1358c1243
Problem: duplicate code for hwm check
2015-09-25 11:24:48 +02:00
Constantin Rack
dd6bb9ae0c
Merge pull request #1586 from ricnewton/master
...
Update cmake to support Visual Studio 2015
2015-09-19 15:51:47 +02:00
Richard Newton
05d0451e29
Update cmake to support Visual Studio 2015
2015-09-19 14:39:18 +01:00
Pieter Hintjens
d89753cbf0
Merge pull request #1585 from msb-at-yahoo/fix-send-doc-typo
...
Fix typo on send documentation re: nullification
2015-09-18 20:28:50 +02:00
maurice barnum
b12b8ca23b
Fix typo on send documentation re: nullification
2015-09-18 11:22:12 -07:00
Constantin Rack
ed1009b3a5
Merge pull request #1584 from ymax/master
...
fixed zmq assertion in signaler.cpp under ubuntu
2015-09-18 16:57:19 +02:00
Maxim Yakhontov
e9e03f5ade
fixed zmq assertion in signaler.cpp under ubuntu
2015-09-18 20:48:08 +06:00
Constantin Rack
2452c598b7
Merge pull request #1582 from pengweichu/master
...
Fixed the bug which cause the application crashed when use TCP connec…
Fixes #1581
2015-09-17 11:31:10 +02:00
PP
5dc8b51ceb
Fixed the bug which cause the application crashed when use TCP connect to an invalid address(such as 192.168.1.255).
2015-09-17 16:59:25 +08:00
Pieter Hintjens
0f51190c27
Merge pull request #1580 from ricnewton/master
...
Fix windows cmake build
2015-09-14 14:24:37 +02:00
Richard Newton
3f4f3c1137
Fix windows cmake build
2015-09-14 13:21:20 +01:00
Constantin Rack
ee7f2a278a
Merge pull request #1579 from staticfloat/patch-2
2015-09-14 07:59:12 +02:00
Elliot Saba
1fbc67a40a
Fix pointer indirection precedence issue in docs
...
Without this change, a segmentation fault is likely to occur when using the proposed snippet of code, as `*address[size]` is equivalent to `*(address[size])`, not `(*address)[size]` as clearly intended.
2015-09-13 20:46:14 -07:00
Constantin Rack
2c94bb42c5
Merge pull request #1578 from hintjens/master
...
Problem: drop tests on CLIENT/SERVER are misleading
2015-09-13 14:18:49 +02:00
Pieter Hintjens
3f9255019b
Problem: description of ZMQ_CLIENT/SERVER has inaccuracies
...
- both are thread safe
- they do not accept ZMQ_SNDMORE nor ZMQ_RCVMORE
2015-09-13 12:28:43 +02:00
Pieter Hintjens
50859e40b9
Problem: drop tests on CLIENT/SERVER are misleading
...
These sockets deal only with single part data (at present), so the
drop tests are misleading / inappropriate.
Solution: remove them.
2015-09-13 12:17:53 +02:00
Joe Eli McIlvain
fb57110b94
Merge pull request #1577 from hintjens/master
...
Various cleanups for CLIENT-SERVER sockets
2015-09-11 14:24:51 -07:00
Pieter Hintjens
f3ee8c69db
Problem: request-reply pattern is lousy
...
REQ-REP barely work, and DEALER-ROUTER are misnamed. As we move to
formalizing CLIENT-SERVER, we can deprecate request-reply.
Solution: move this section to the end of the man page, and mark as
"will be deprecated".
2015-09-11 17:22:37 -04:00
Pieter Hintjens
e7da0ea07b
Problem: client/server pattern is not documented
...
Solution: add man pages/sections for:
* ZMQ_SERVER
* ZMQ_CLIENT
* ZMQ_THREADSAFE
* zmq_msg_routing_id
* zmq_msg_set_routing_id
2015-09-11 17:12:58 -04:00
Pieter Hintjens
4db73fc18b
Problem: msg.cpp:set_routing_id accepts a zero routing ID
...
Solution: check/reject a zero routing ID with EINVAL.
2015-09-11 17:09:24 -04:00
Pieter Hintjens
6b00f40f74
Problem: test_client/server_drop_more are invalid
...
These tests connected CLIENT and SERVER to DEALER... this isn't
allowed. I changed to CLIENT-to-SERVER in both cases. The result
was aborts in client.cpp and server.cpp which cannot handle
invalid multipart data.
I removed the asserts in each of these in xsend.
Solution: fix the test cases and remove the (unwanted?) asserts
in client.cpp:xsend and server.cpp:xsend.
2015-09-11 17:07:50 -04:00
Pieter Hintjens
c2dffb9908
Problem: threadsafe test uses CLIENT-to-CLIENT
...
Solution: fix to use CLIENT-to-SERVER and increase number of messages
sent to 100K per thread, to better stress thread safety.
2015-09-11 17:01:27 -04:00
Pieter Hintjens
d416ffcec5
Problem: cannot build single test case in tests
...
This is due to the mangled include of platform.h, which was to make
CMake happy.
Solution: in CMakeLists.txt, define USING_CMAKE and then look for
platform.h in current directory if that is defined, else look in
../src/ as one would expect.
2015-09-11 16:42:26 -04:00
Pieter Hintjens
5e936fe955
Problem: routing ID cycles back to zero
...
It should never be zero.
Solution: if rid cycles back to zero, bump to 1.
2015-09-11 14:30:27 -04:00
Pieter Hintjens
60fdfd9a1b
Problem: whitespace at end of lines, removed
2015-09-11 14:30:20 -04:00
Pieter Hintjens
c5b1de368a
Problem: code lets CLIENT connect to CLIENT
...
This has no sense IMO; people who need this can still use DEALER-DEALER.
Solution: let CLIENT talk only to SERVER.
2015-09-11 13:46:02 -04:00
Pieter Hintjens
87f2dff38c
Problem: zmq_msg_get_routing_id () is not consistent with API
...
We do not use 'get' for getters.
Solution: rename to zmq_msg_routing_id () for public API.
2015-09-11 13:15:00 -04:00
Pieter Hintjens
7be6ad0504
Replaced tabs in some files, with spaces
2015-09-11 13:03:31 -04:00
Constantin Rack
d0ffb91323
Merge pull request #1574 from pijyoi/master
...
avoid dereferencing uint32_t on unaligned address
2015-09-08 11:40:04 +02:00
KIU Shueng Chuan
25a50ca0d5
avoid dereferencing uint32_t on unaligned address
2015-09-08 17:26:31 +08:00
Pieter Hintjens
734a73c63d
Merge pull request #1571 from c-rack/fix-typos
...
Solution: fix typos
2015-09-06 19:00:56 +02:00
Constantin Rack
bd923f0fbb
Problem: some comments contain typos
2015-09-06 18:46:32 +02:00
Pieter Hintjens
3e43258769
Merge pull request #1570 from djelenc/deque_bug
...
Problem: Tests in Travis are failing randomly
2015-09-06 02:01:02 +02:00
David Jelenc
64ffda90d2
Problem: Tests in Travis are failing randomly
...
Tests were failing, because some deque calls were causing undefined
behavior: calling front() or pop_front() on an empty deque. Such
calls are now safeguarded.
2015-09-06 01:49:50 +02:00
Constantin Rack
39a0d33912
Merge pull request #1569 from djelenc/xpub_manual_lost_subscriptions
...
Fixed missing subscriptions on XPUB with manual subscriptions
2015-09-05 16:30:36 +02:00
David Jelenc
8fd71d631d
Fixed missing subscriptions on XPUB with manual subscriptions
...
The patch fixes the issue #1568 .
2015-09-05 15:56:26 +02:00
Pieter Hintjens
47e1216e1e
Merge pull request #1567 from djelenc/xpub_manual_proxy_disconnect_unsubscribe
...
Problem: lingering subscriptions on XPUB sockets (#1566 )
2015-09-05 12:14:27 +02:00
David Jelenc
dd35e1db0f
Problem: lingering subscriptions on XPUB sockets ( #1566 )
...
The patch fixes lingering subscriptions that occur upon disconnection
on XPUB sockets with option XPUB_MANUAL when used in a XPUB-XSUB
proxies.
2015-09-05 12:07:50 +02:00
Pieter Hintjens
9e8e81cf9a
Merge pull request #1564 from c-rack/issue-1558-2
...
Solution: do not call poller->add_fd() with -1. Fixes #1558
2015-09-03 12:41:55 +02:00
Constantin Rack
5dad00ebdc
Problem: do not call poller->add_fd() with -1. Fixes #1558
2015-09-03 12:31:55 +02:00
Pieter Hintjens
23c55612e4
Merge pull request #1563 from zeromq/revert-1561-issue-1558
...
Revert "Solution: check return code of make_fdpair() with zmq_assert"
2015-09-03 12:15:42 +02:00
Constantin Rack
2159618b56
Revert "Solution: check return code of make_fdpair() with zmq_assert"
2015-09-03 10:56:26 +02:00
Constantin Rack
13db11c6ae
Merge pull request #1562 from markuspf/fix-dragonfly-compile-2
...
Make DragonFly a first class citizen in terms of compilation
2015-09-03 10:19:42 +02:00
Markus Pfeiffer
ee984b1fe6
Make DragonFly a first class citizen in terms of compilation
2015-09-03 09:00:12 +01:00
Pieter Hintjens
32d7da1103
Merge pull request #1561 from c-rack/issue-1558
...
Solution: check return code of make_fdpair() with zmq_assert
2015-09-02 23:25:51 +02:00
Constantin Rack
bb9788867f
Problem: return code of make_fdpair() is not checked. Fixes #1558
2015-09-02 23:19:27 +02:00
Constantin Rack
801f39dbef
Merge pull request #1557 from hintjens/master
...
Cleaned up test case
2015-09-02 10:02:56 +02:00
Pieter Hintjens
1fdf8f78e4
Cleaned up test case
2015-09-02 09:55:19 +02:00
Constantin Rack
146be48495
Merge pull request #1553 from flub/master
...
Update zmq_inproc manpage for bind/connect order
2015-08-27 12:50:17 +02:00
Floris Bruynooghe
f86264db3e
Update zmq_inproc manpage for bind/connect order
...
The order of zmq_bind() and zmq_connect() is no longer important
for the inproc transport since libzmq 4.0. This updates this
in the zmq_inproc manpage.
2015-08-27 10:40:21 +01:00
Constantin Rack
0e1448a26f
Merge pull request #1550 from xaqq/master
...
Problem: Identity frame from router has no metadata
2015-08-24 22:35:31 +02:00
Pieter Hintjens
bc513b6381
Merge pull request #1547 from jemc/master
...
Problem: Private/internal macros defined in public header.
2015-08-22 09:09:56 +02:00
Joe Eli McIlvain
33419425eb
Problem: Private/internal macros defined in public header.
...
Solution: Move the macros to a private header.
2015-08-21 16:12:22 -07:00
Pieter Hintjens
735c02ed5e
Merge pull request #1546 from reza-ebrahimi/master
...
rename ZMQ_UNUSED macro to LIBZMQ_UNUSED
2015-08-21 23:57:18 +02:00
reza.ebrahimi
63260d8701
rename ZMQ_UNUSED macro to LIBZMQ_UNUSED
2015-08-22 00:31:25 +04:30
Constantin Rack
b07b1e270e
Merge pull request #1545 from ricnewton/master
...
Fix zmq crash when calling shutdown with a pending inproc socket connect
2015-08-21 11:25:45 +02:00
Richard Newton
096007c574
Fix zmq crash when calling shutdown with a pending inproc socket connect
2015-08-21 10:06:54 +01:00
Constantin Rack
4e5843b8ff
Merge pull request #1543 from csiro-workspace/master
...
Set signaler_port to 0 which allows the OS to find a free port
2015-08-21 08:12:09 +02:00
Matt Bolger
7e09306cb3
-Set signaler_port to 0 which allows the OS to find a free port, rather than crashing if 5905 is in use ( https://github.com/zeromq/libzmq/issues/1542 )
...
-Added config.hpp to the source list so it shows up in generated projects
-Remove CMAKE_BUILD_TYPE setting for generators that don't use it
2015-08-21 13:45:59 +10:00
Constantin Rack
ec98916e82
Merge pull request #1541 from jemc/master
...
Problem: Source files contain mixed tabs and spaces.
2015-08-20 16:54:03 +02:00
Joe Eli McIlvain
61217a2686
Problem: Source files contain mixed tabs and spaces.
...
Solution: Convert to spaces and remove trailing whitespace in these files.
2015-08-20 07:46:34 -07:00
Richard Newton
6aa5c20b3d
Merge pull request #1540 from djelenc/fix_failing_tests
...
Fixes failing tests regarding XPUB sockets.
2015-08-20 14:44:45 +01:00
David Jelenc
1240d7ac83
Fixes failing tests regarding XPUB sockets.
...
Fixes tests that were introduced in a previous pull request. See
https://github.com/zeromq/libzmq/pull/1539#issuecomment-132968987
2015-08-20 15:32:23 +02:00
Constantin Rack
391bc12d17
Merge pull request #1539 from djelenc/issue1116
...
Addresses zeromq/libzmq#1116 .
2015-08-20 12:34:19 +02:00
David Jelenc
b9634e11a3
Addresses zeromq/libzmq#1116 .
...
This patch adds a new member of type deque to the
xpub class that contains pointers to metadata_t.
This deque is then used (alongside pending_data
and pending_flags) to preserve metadata when
copying messages.
2015-08-20 12:09:56 +02:00
Kapp Arnaud
370b8c9bb1
Problem: Identity frame from router has no metadata
...
The routing id (identity) frame return when reading from
a router doesn't have the same metadata as the "real"
message that follows.
For example, The ZAP "User-Id" property is missing.
This patch attach the "data message"'s metadata
to the "identity message" when it is read from the router.
2015-08-20 01:15:18 +02:00
Constantin Rack
3f326b10d6
Merge pull request #1536 from bluca/ci-osx-missing-dependency
...
CI run on OSX needs binutils
2015-08-17 18:17:20 +02:00
Constantin Rack
709a1e9a2d
Merge pull request #1535 from somdoron/master
...
problem: trying to support polling on thread safe sockets with zmq_poll failed
2015-08-17 18:11:52 +02:00
Luca Boccassi
0c4032b5af
CI run on OSX needs binutils
...
OSX does not ship with binutils, need to install it before the script
run via brew in order to be able to use greadelf, needed by the
qt-android CI script.
2015-08-17 17:06:56 +01:00
somdoron
4da5ff6a7d
revert to original zmq_polland creating zmq_pollfd_poll for polling on pollfd
2015-08-17 18:57:47 +03:00
Constantin Rack
a96f16e3fa
Merge pull request #1534 from somdoron/master
...
problem: new poller field in zmq_pollitem_t is changing the api
2015-08-17 13:40:26 +02:00
somdoron
d83b045347
rename poller to pollfd
2015-08-17 14:20:49 +03:00
Pieter Hintjens
7d42aac0c5
Merge pull request #1533 from c-rack/fix-tests
...
Problem: tests fail after PR #1531
2015-08-17 13:17:53 +02:00
Constantin Rack
34fe5eaf26
Solution: explicitly set u.base.metadata to null
2015-08-17 12:41:27 +02:00
somdoron
5bae6911af
remove poller field, using fd instead
2015-08-17 11:56:23 +03:00
Constantin Rack
87e7ed054b
Merge pull request #1531 from reza-ebrahimi/master
...
apply a change to LIBZMQ_DELETE macro (related to issue #1524 )
2015-08-16 22:54:01 +02:00
reza.ebrahimi
7058c54672
apply a change to LIBZMQ_DELETE macro (related to issue #1524 )
2015-08-17 01:00:55 +04:30
Constantin Rack
6d9eb184b5
Merge pull request #1530 from reza-ebrahimi/master
...
define a macro for heap object deletion in a unified manner (related …
2015-08-16 22:21:19 +02:00
reza.ebrahimi
1621c25ef0
define a macro for heap object deletion in a unified manner (related to issue #1524 )
2015-08-17 00:35:11 +04:30
Constantin Rack
9bf88bcc03
Merge pull request #1529 from bluca/container
...
Container-based CI build
2015-08-16 21:32:39 +02:00
Luca Boccassi
1ab4667412
Set -x in ci_build.sh to show commands in log
2015-08-16 20:20:59 +01:00
Luca Boccassi
f6b0eaddb5
Set sudo: false to force container build
2015-08-16 20:20:59 +01:00
Luca Boccassi
1afc30a6c4
CI build/install in local directory
2015-08-16 20:20:59 +01:00
Constantin Rack
9ebd54a9e5
Merge pull request #1528 from bluca/fix-travis-check
...
CI build does not fail when tests fail. Fix #1527
2015-08-16 17:45:57 +02:00
Luca Boccassi
f4e9e6f062
CI build does not fail when tests fail. Fix #1527
2015-08-16 16:41:17 +01:00
taotetek
eb1d72f81d
Merge pull request #1526 from somdoron/master
...
problem: new field is breaking existing code
2015-08-16 11:09:28 -04:00
somdoron
9d829f72f4
moving new poller field to the end of the struct
2015-08-16 18:00:32 +03:00
Constantin Rack
e74e36def1
Merge pull request #1525 from somdoron/master
...
problem: user cannot poll on thread safe sockets
2015-08-16 13:10:16 +02:00
somdoron
6eddbd98bc
polling on thread safe sockets
2015-08-16 13:57:28 +03:00
somdoron
1653d3c093
add new tests to gitignore
2015-08-16 13:57:28 +03:00
somdoron
1aaa893e02
add tests for polling on thread safe sockets
2015-08-16 13:57:28 +03:00
somdoron
a63818904d
add methods to handle poller
2015-08-16 13:57:28 +03:00
somdoron
34968771ca
add an option to check if the socket is thread safe
2015-08-16 11:50:50 +03:00
Constantin Rack
de018e8766
Merge pull request #1522 from reza-ebrahimi/master
...
fixed issue with ticket #1517 (wrong lib output name in MSVC CMake bu…
2015-08-14 16:13:41 +02:00
reza.ebrahimi
a50834cbec
fixed issue with ticket #1517 (wrong lib output name in MSVC CMake build) and apply some improvements in CMake build system
2015-08-14 18:04:54 +04:30
Constantin Rack
eb2eec646f
Merge pull request #1521 from reza-ebrahimi/master
...
changing some camelCase variable names to snake_case in previous commit
2015-08-14 14:42:54 +02:00
reza.ebrahimi
8e6ef4616e
changing some camelCase variable names to snake_case in previous commit
2015-08-14 16:56:07 +04:30