Luca Boccassi
d7da31ed25
Problem: typo in comment in proxy.cpp
...
Solution: fix it
2017-09-06 08:27:17 +01:00
Doron Somech
f520738a0a
Merge pull request #2740 from bluca/proxy_stats_frames
...
Problem: proxy_steerable STATISTICS returns conflated buffers
2017-09-06 08:58:34 +03:00
Luca Boccassi
b8695a47b5
Problem: proxy_steerable STATISTICS returns conflated buffers
...
Solution: split each stat into its own frame, to make it simpler and
easier to use it, especially from high level bindings
2017-09-06 01:28:28 +01:00
Constantin Rack
a89d79aa71
Merge pull request #2738 from bluca/proxy_stat_fixes
...
Problems: proxy stats test break 32bit build, not declared as draft
2017-09-05 20:52:51 +02:00
Luca Boccassi
78c4d33600
Problem: new STATISTICS proxy_steerable not behind DRAFT
...
Solution: ifdef it until it's declared stable
2017-09-05 17:37:52 +01:00
Luca Boccassi
c5aef5e078
Problem: compilation fails on 32 bit
...
Solution: trucate 64 bit stats in test_proxy, as it's much easier than
to try and print 64 unsigned integers in a portable way
2017-09-05 17:23:08 +01:00
f18m
4be9513443
Add "STATISTICS" command to zmq_proxy_steerable() ( #2737 )
...
* Issue #2736 : Add STATISTICS command to zmq_proxy_steerable()
2017-09-05 17:05:04 +01:00
Luca Boccassi
f4b32aa792
Merge pull request #2734 from pavel-pimenov/fix-v1001
...
Variable is assigned but is not used until the end of the function
2017-09-04 15:25:43 +01:00
Luca Boccassi
197ae832bf
Merge pull request #2735 from pavel-pimenov/fix-728
...
Excessive check options.mechanism == ZMQ_NULL
2017-09-04 14:50:34 +01:00
pavel.pimenov
0e8bf3520c
V728 An excessive check 'options.mechanism == 0' can be simplified.
...
The '||' operator is surrounded by opposite expressions. session_base.cpp 377
2017-09-04 15:25:31 +03:00
pavel.pimenov
51ac7d28c5
V1001 The 'ptr' variable is assigned but is not used until the end of the function.
2017-09-04 15:15:35 +03:00
Constantin Rack
7afd6ab5ef
Merge pull request #2732 from bluca/compiler_warnings
...
Problems: compiler warnings
2017-09-01 22:11:57 +02:00
Luca Boccassi
8feed48bb9
Problem: switch statements without breaks
...
Solution: add /* FALLTHROUGH */ comments so that nagging compilers
don't nag
2017-09-01 20:01:15 +01:00
Luca Boccassi
31089326fb
Problem: unused variables warnings in get_peer_state
...
Solution: wrap arguments with LIBZMQ_UNUSED
2017-09-01 19:57:00 +01:00
Luca Boccassi
0382118371
Problem: unused variable in test_wait_corner_cases
...
Solution: don't pass it
2017-09-01 19:55:51 +01:00
Luca Boccassi
31e3977ab9
Merge pull request #2731 from sigiesec/fix-issue-2723
...
Problem: assertion in src\select.cpp:111 on Windows or hang on zmq_ctx_destroy
2017-09-01 19:51:39 +01:00
Luca Boccassi
17b95683ce
Merge pull request #2730 from sigiesec/fix-issue-2623
...
Problem: unable to query state of a router for a particular peer
2017-09-01 16:23:42 +01:00
sigiesec
79e28af4ce
Problem: new function zmq_socket_get_peer_state not in zmq_draft.h
...
Solution: added function to zmq_draft.h
2017-09-01 17:15:23 +02:00
sigiesec
f3b268d84f
Problem: no tests for error cases of zmq_socket_get_peer_state
...
Solution: added tests
2017-09-01 16:28:59 +02:00
sigiesec
eeccbbd6f8
Problem: test case fails with tcp transport
...
Solution: use inproc transport instead
2017-09-01 16:28:59 +02:00
sigiesec
fc334bc759
Problem: unclean and duplicated test code
...
Solution: refactoring
2017-09-01 16:28:59 +02:00
sigiesec
f70097c1cf
Problem: test does not trigger HWM
...
Solution: modify order of operations, add diagnostic output
2017-09-01 16:28:59 +02:00
sigiesec
48a1e637b6
Problem: zmq_socket_get_peer_state is not implemented
...
Solution: add initial implementation
2017-09-01 16:28:58 +02:00
sigiesec
cda20260b3
Problem: missing call to zmq_poller_destroy
...
Solution: added call
2017-09-01 16:28:58 +02:00
sigiesec
f4d139bd16
Problem: duplicated code in socket-related functions
...
Solution: extract as_socket_base_t function
2017-09-01 16:28:58 +02:00
sigiesec
efa86fe629
Problem: no test case using the proposed zmq_socket_get_peer_state function
...
Solution: added test case (with dummy implementation of zmq_socket_get_peer_state)
2017-09-01 16:28:58 +02:00
sigiesec
49e1b8b75f
Problem: test case in main function
...
Solution: extracted test_basic function
2017-09-01 16:28:57 +02:00
Jim Klimov
4691714d5c
Merge pull request #2729 from bluca/cmake
...
Problems: ZMQ_HAVE_O_CLOEXEC not defined by CMake, support for CMake << 3.1 broken
2017-09-01 14:53:45 +02:00
Luca Boccassi
fab14a3cc1
Problem: support for CMake << 3.1 broken
...
Solution: remove redundant target_sources directive
2017-09-01 10:59:48 +01:00
sigiesec
23e018f37a
Problem: termination is requested from a session's owner when already in
...
pending termination while processing an error
Solution: terminate pipe instead
Fixes #2723
2017-09-01 11:55:31 +02:00
sigiesec
eb8105cde1
Problem: assertion failure in select.cpp:111 under Windows
...
Solution: handle case when get_fd_family fails
2017-09-01 11:55:31 +02:00
Luca Boccassi
124e04659c
Problem: ZMQ_HAVE_O_CLOEXEC not defined by CMake
...
Solution: add it to CMake's platform.hpp.in
2017-09-01 10:15:42 +01:00
Luca Boccassi
28a4b9a969
Merge pull request #2727 from fove-robin/fix-o-cloexec
...
Problem: ZMQ_HAVE_O_CLOEXEC always disabled
2017-09-01 09:39:39 +01:00
Robin Stacey
83f54d90ad
Problem: ZMQ_HAVE_O_CLOEXEC always disabled
...
Solution: Escape quotes in cmake test.
2017-09-01 16:37:27 +09:00
Simon Giesecke
f1c72dc8e5
Merge pull request #2721 from bjovke/my_work
...
Problem: Inconsistent size_t/int usage. size_t and int don't match in 64 bit build and produce warnings. Solution: types corrected.
2017-08-28 15:47:57 +02:00
bjovke
91e0d689bb
Problem: Inconsistent size_t/int usage. Solution: types corrected.
2017-08-28 15:03:46 +02:00
Constantin Rack
9c8844fd08
Merge pull request #2719 from jimklimov/setThreadName
...
Problem: cosmetic setThreadName() can be fatal
2017-08-25 16:01:52 +02:00
Jim Klimov
40a3b0746f
Problem: cosmetic setThreadName() can be fatal
...
Solution: do not assert() the values returned; if we failed to set the thread name - we just have harder debugging, not flawed production conditions.
Closes github issue #2679
Signed-off-by: Jim Klimov <EvgenyKlimov@eaton.com>
2017-08-25 15:30:03 +02:00
Luca Boccassi
5c981be9f8
Merge pull request #2718 from sigiesec/issue-template
...
Problem: bug reports are often missing relevant information
2017-08-25 12:20:43 +01:00
sigiesec
3f946428ec
Problem: bug reports are often missing relevant information
...
Solution: provide template for bug reports
2017-08-25 13:16:23 +02:00
Constantin Rack
f6933f85a9
Merge pull request #2716 from sigiesec/remove-tweetnacl-from-coverage
...
Problem: coverage includes tweetnacl, which is not our code
2017-08-23 15:16:33 +02:00
sigiesec
fc2b7cd5ea
Problem: coverage includes tweetnacl, which is not our code
...
Solution: exclude tweetnacl from coverage
2017-08-23 14:42:52 +02:00
Luca Boccassi
3d1f11881f
Merge pull request #2715 from sigiesec/add-timers-tests
...
Problem: insufficient tests for zmq_timers_* and inadequate behaviour in corner cases
2017-08-23 12:52:43 +01:00
sigiesec
7eebed56a5
Problem: no test for zmq_timers_timeout without any active timers
...
Solution: add test
2017-08-23 10:31:44 +02:00
sigiesec
6147e45a07
Problem: missing tests for zmq_timers_* corner cases, missing handling of such corner cases, code duplication, missing assertions in test code
...
Solution: add tests, add checks to timers_t, add match_by_id functor, add assertions
2017-08-23 09:41:34 +02:00
sigiesec
d072d57e2e
Problem: no tests for zmq_timer_* with NULL timers argument
...
Solution: added tests
2017-08-23 09:41:22 +02:00
sigiesec
8b263d5820
Problem: test_timers.cpp sleep_ duplicates msleep from testutil
...
Solution: replace sleep_ my msleep
2017-08-23 09:05:10 +02:00
Doron Somech
8f3113b278
Merge pull request #2714 from sigiesec/add-poller-tests
...
Problem: insufficient tests for zmq_poller_*
2017-08-22 22:38:36 +03:00
sigiesec
f685a3ffd2
Solution: unreachable code paths in socket_poller_t
...
Problem: replaced by assertions resp. removed
2017-08-22 21:23:09 +02:00
sigiesec
8ae91fdf9a
Problem: no test cases for zmq_poller_add*, zmq_poller_modify*, zmq_poller_remove* corner cases
...
Solution: added test cases
2017-08-22 20:22:39 +02:00