3party/libzmq
0
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-03-19 09:53:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,666 Commits 4 Branches 39 Tags
Commit Graph

302 Commits

Author SHA1 Message Date
Simon Giesecke
3db3bbfbbb Problem: duplication in implementation zmq_poller_poll 
Solution: remove duplication
 2018-06-01 17:08:38 +02:00
Simon Giesecke
0179b7577a Problem: literals protocol names used at various places 
Solution: introduced named constants
 2018-05-30 22:50:29 +02:00
Simon Giesecke
d767909b50 Problem: old C-style casts used 
Solution: replace by static_cast/reinterpret_cast
 2018-05-27 13:24:07 +02:00
Simon Giesecke
12a97bb769 Problem: redundant else after return 
Solution: remove else
 2018-05-26 09:34:45 +02:00
Simon Giesecke
c581f43c97 Problem: parameter naming style inconsistent 
Solution: define and apply parameter naming style: lower_case_
 2018-05-26 09:34:44 +02:00
Simon Giesecke
440be28d7e Problem: unnecessary non-const variables 
Solution: add const
 2018-05-22 18:46:40 +02:00
Simon Giesecke
4e616f30dd Problem: C-style casts used 
Solution: replace by C++-style casts
 2018-05-18 17:04:01 +02:00
Simon Giesecke
62e48f837d Problem: assignment within complex condition 
Solution: restructured code, inverted condition
 2018-05-18 14:34:43 +02:00
Luca Boccassi
d81a041f18
Merge pull request #3103 from sigiesec/win-warnings-as-errors 
Warnings in Windows builds
 2018-05-14 22:53:04 +01:00
Simon Giesecke
d437d668c0 Problem: MSVC warnings in connection with poll 
Solution: handle types properly
 2018-05-14 22:25:21 +02:00
Simon Giesecke
bf6bde3ae3 Problem: unnecessary ifdefs regarding handling of int vs. SOCKET at various places 
Solution: use a typedef instead
 2018-05-14 14:58:36 +02:00
Simon Giesecke
e8877f78a9 Problem: zmq_poller_[add/modify] accept invalid events arguments silently 
Solution: check and return an error on invalid arguments. Fixes #3088
 2018-05-14 14:58:36 +02:00
Simon Giesecke
6b9b369469 Problem: zmq_poller_* argument check code is cloned 
Solution: extract common code into functions
 2018-05-14 14:34:46 +02:00
Simon Giesecke
213254cca5 Problem: inconsistent behaviour of zmq_poller_new in case of memory exhaustion 
Solution: return NULL and set errno to ENOMEM
 2018-05-14 11:29:24 +02:00
Luca Boccassi
8d544ef1c4 Problem: formatting issues in the CI 
Solution: commit clang-format-diff
 2018-03-10 12:44:27 +00:00
Manuel Segura
4726f7262d Pull request to merge porting to WindRiver VxWorks 6.x (#2966) 
* Problem: Still need to port over more files to VxWorks 6.x

Solution: Port more files to VxWorks 6.x

* Problem: Need to port over remaining files to VxWorks 6.x. Also remove POSIX thread dependency for VxWorks (because of priority inversion problem in POSIX mutexes with VxWorks 6.x processes)

Solution: Port over remaining files to VxWorks 6.x. Also removed POSIX thread dependency for VxWorks

* Problem: Needed to modify TCP, UDP, TIPC classes with #ifdefs to be compatible with VxWorks 6.x.

Solution:  Modify TCP, UDP, TIPC classes with #ifdefs to be compatible with VxWorks 6.x
 2018-03-10 11:03:02 +00:00
Luca Boccassi
541ca30d8e Problem: make clang-format still shows error in the CI 
Solution: run make clang-format-diff and commit the changes.
 2018-03-05 22:41:11 +00:00
Simon Giesecke
e8e24030ea Problem: network initialization and shutdown functions not available for 
reuse

Solution: extract into functions defined in ip.hpp

Problem: signaler_t::make_fdpair not reusable

Solution: move make_fdpair to ip.hpp

Problem: epoll worker with no fds cannot be stopped

Solution: use interruptible epoll_pwait call

Problem: insufficient unit tests for poller

Solution: add test cases
 2018-02-13 18:38:17 +01:00
sigiesec
41f459e1dc Problem: formatting inconsistent 
Solution: applied clang-format
 2018-02-02 15:47:43 +01:00
sigiesec
206c832167 Problem: in case of exhausted resources on creation of a context, assertions are triggered 
Solution: signal error to caller, and apply appropriate cleanup
 2018-01-31 20:53:06 +01:00
sigiesec
9e7507b38b Problem: term "identity" is confusing 
Solution: replace by "routing id"
 2017-09-19 17:53:44 +02:00
Doron Somech
af03241dcb Revert "Problem: term "identity" is confusing" 2017-09-07 15:47:43 +03:00
sigiesec
1daf83079a Problem: term "identity" is confusing 
Solution: replace by "routing id"
 2017-09-06 17:45:56 +02:00
sigiesec
48a1e637b6 Problem: zmq_socket_get_peer_state is not implemented 
Solution: add initial implementation
 2017-09-01 16:28:58 +02:00
sigiesec
f4d139bd16 Problem: duplicated code in socket-related functions 
Solution: extract as_socket_base_t function
 2017-09-01 16:28:58 +02:00
sigiesec
efa86fe629 Problem: no test case using the proposed zmq_socket_get_peer_state function 
Solution: added test case (with dummy implementation of zmq_socket_get_peer_state)
 2017-09-01 16:28:58 +02:00
sigiesec
a71f7b0405 Problem: zmq_poller_* uses ETIMEDOUT (instead of the usual EAGAIN) to indicate timeouts 
Solution: replace ETIMEDOUT within socket_poller_t and all client code by EAGAIN

Fixes #2713
 2017-08-22 20:00:29 +02:00
sigiesec
6a3c053a3e Problem: EFAULT is returned for bad file descriptors passed to zmq_poller_*_fd 
Solution: Return EBADF instead
 2017-08-22 19:43:56 +02:00
sigiesec
74303b08e6 Problem: calling zmq_poller_wait* with NULL events causes an assertion, as opposed to other NULL arguments, which return an error 
Solution: return EFAULT when such an operation is attempted
 2017-08-22 19:43:56 +02:00
sigiesec
2e4fc4faf0 Problem: zmq_poller_*_fd functions do not check for invalid fd 
Solution: add checks, added test cases
 2017-08-22 19:28:07 +02:00
KIU Shueng Chuan
d11f501dc1 problem: not using official api FD_ZERO to init fd_set 
solution: fix it

In particular, on Windows, using FD_ZERO is much more efficient than
zeroing out the whole structure.
 2017-05-06 08:03:09 +08:00
bjovke
dc7bbe35b4 Problem: FD set copying on Windows still not optimal on some places. Solution: Improved memcpy() of FD sets for Windows builds. 2017-04-14 16:31:05 +02:00
bjovke
319eb27f19 Unnecessary dynamic memory allocation for zmq::socket_poller_t in zmq_poller_poll(). Fixed by allocating zmq::socket_poller_t from stack. 2017-04-04 11:51:59 +02:00
Thomas Braun
19f30f7926 Problem: throwing version of new called 
Solution: Pass (std::nothrow) as done in all other places.
 2017-03-27 23:58:19 +02:00
evoskuil
616fbeff21 Problem: insufficient use of const complicates calling. 2017-03-26 00:53:50 -07:00
Asmod4n
4dbd387fa9 Add "draft" capability to zmq_has 
As discussed in #2307
 2017-01-19 18:44:56 +01:00
Min RK
0abdc28c84 only compare FD when neither item is a zmq socket 2016-12-15 14:05:40 +01:00
Luca Boccassi
72176d5fbe Problem: check for item.fd causes zloop_poller regression 
Solution: fix the check for the socket.
This regression happens when using zloop with zmq_pollitem_it with
only file descriptors registerted through zloop_poller.
 2016-12-10 23:49:18 +00:00
Min RK
f302d8a7b6 only compare pollitem.fd if pollitem.socket is NULL 
item.fd should be ignored if item.socket is defined.

Failing to check .socket could cause false-matches, raising EINVAL in zmq_poller_modify_fd.
 2016-11-21 11:47:50 +01:00
Hunter Laux
60b63ed518 Remove an unnecessary while (true) 
This block of code will either return -1 or fall through.
The while (true) does nothing.
The braces limit the scope of int rc.
 2016-10-31 11:46:57 -07:00
Luca Boccassi
c592897f60
Problem: a request 
Solution: honor it
 2016-10-04 15:48:12 +01:00
Nick Guiffrida
f3de534897 Do not assign rc to zmq_poller_destroy in zmq_poller_poll 
* Doing so was zmq_poller_poll to always return 0.
 2016-09-30 21:10:25 -07:00
Min RK
fb5a04e21d allow duplicate entries in zmq_poller_poll 
This should restore full compatibility with earlier zmq_poll behavior.

It complicates things a little bit, as collisions must be detected, and when collisions are found:

- event masks must be merged
- pollitems, events arrays are no longer co-ordered

Reverts the recent zmq_proxy patch to workaround the lack of repeat-item support in zmq_poll that is now fixed.
 2016-09-29 16:33:02 +02:00
Min RK
310dafbc75 zmq_poll returns 0 on timeout 
not -1, ETIMEDOUT like zmq_poller
 2016-09-29 15:44:31 +02:00
Min RK
718608ce94 socket_poller::wait returns only triggered events 
Return value is the number of events found. This also propagates to the return value of zmq_poller_wait_all.

zmq_poller_wait was only returning events on the first-registered socket.
 2016-09-29 15:21:52 +02:00
Min RK
53fb120687 heap-allocate events in zmq_poller_poll 
variable-size array allocation is not allowed by some compilers
 2016-09-28 15:17:57 +02:00
Min RK
bdcaa935b9 zmq_poll calls zmq_poller if available 
enables zmq_poll on threadsafe sockets only supported in zmq_poller (radio, dish, etc.)
 2016-09-28 13:53:57 +02:00
Min RK
ec750732d4 pass through poller events 
instead of allocating a new, identical array and copying the data.

This is only safe while zmq_poller_event_t and zmq::socket_poller_t::event_t are the same struct,
which they presumably will remain.
 2016-09-27 14:59:07 +02:00
Min RK
de7fc1fcf8 add n_events argument to zmq_poller_wait_all 
avoids unnecessary heap allocations, races on the number of items
 2016-09-27 14:37:52 +02:00
Min RK
2bc9796651 Problem: zmq_poller only signals one event 
Solution: zmq_poller_wait_all signals all events

allows signaling multiple events with one call to zmq_poller_wait_all
rather than emitting only one event.

this prepares for zmq_poll being based on zmq_poller,
which requires events for all sockets rather than just one.
 2016-09-27 13:39:16 +02:00