Luca Boccassi
|
cb73745250
|
Problem: cannot send more than one value per v2 event
Solution: refactor code and add extra frame with value count before the
values in v2
|
2019-02-07 20:42:47 +00:00 |
|
Luca Boccassi
|
1e26a93ce2
|
Problem: test_monitor fails in valgrind
Solution: expect additional events
|
2019-02-07 20:42:47 +00:00 |
|
Luca Boccassi
|
c1b374fa6a
|
Problem: manpage for zmq_socket_monitor_versioned has old example
Solution: update it
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
83946d5c98
|
Problem: testutil_monitoring does not close received messages
Solution: do it, as above 32 bytes they might be on the heap
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
edf79dfefc
|
Problem: test_monitor check for DRAFT has to be kept up to date
Solution: check for the available version instead
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
b20cb122d9
|
Problem: zmq_socket_monitor_versioned manpage not generated
Solution: add it to doc/Makefile.am
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
2edba1259e
|
Problem: zmq_socket_monitor_versioned manpage doesn't build
Solution: fix formatting
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
86697347fc
|
Problem: symlinking manpages in automake does not work
Solution: remove them for now
|
2019-02-07 16:24:41 +00:00 |
|
Luca Boccassi
|
e5a7f2eb56
|
Merge pull request #3402 from sigiesec/revert-64-bit-assertions
Revert 64 bit assertions
|
2019-02-07 15:58:38 +00:00 |
|
Simon Giesecke
|
31ff05d156
|
Revert "Problem: test build fails on 32 bit systems"
This reverts commit ac19d5f41ccca7acc40fb5970d6f7a0b20e0bc66.
|
2019-02-07 10:42:32 -05:00 |
|
Simon Giesecke
|
4273ffd266
|
Partially revert "Problem: monitor events are output as decimal in assertion messages"
This partially reverts commit 19c6aa5c9210144205b3e7f26752ebec8302a2f2.
|
2019-02-07 10:42:32 -05:00 |
|
Luca Boccassi
|
4bdb05df78
|
Merge pull request #3400 from sigiesec/fix-issue-3397
Add test for ZMQ_BINDTODEVICE
|
2019-02-07 14:53:48 +00:00 |
|
Simon Giesecke
|
9cb1fca115
|
Problem: on a failure to setsockopt SO_BINDTODEVICE, libzmq asserts
Solution: return an error to the user instead
|
2019-02-07 09:39:02 -05:00 |
|
Simon Giesecke
|
ec4ecb01ff
|
Problem: no test for ZMQ_BINDTODEVICE
Solution: add test case run with cap_net_admin
Fixes #3397
|
2019-02-07 09:39:02 -05:00 |
|
Doron Somech
|
a3a40a01c9
|
Merge pull request #3399 from sigiesec/fix-unity-64-bit
Problem: test build fails on 32 bit systems
|
2019-02-07 14:46:19 +02:00 |
|
Simon Giesecke
|
ac19d5f41c
|
Problem: test build fails on 32 bit systems
Solution: define UNITY_SUPPORT_64 to force 64 bit support
|
2019-02-07 12:13:11 +01:00 |
|
Luca Boccassi
|
eb42e0442b
|
Merge pull request #3396 from sigiesec/fix-issue-3394
Fix regression introduced by 68d520e
|
2019-02-07 11:07:04 +00:00 |
|
Simon Giesecke
|
a763d734f2
|
Problem: formatting broken
Solution: run clang-format
|
2019-02-07 11:44:18 +01:00 |
|
Simon Giesecke
|
7cf0d125d3
|
Problem: failed address resolution on TCP connect is not observable
Solution: added TODO comment for now
|
2019-02-07 11:07:37 +01:00 |
|
Simon Giesecke
|
e45ede49b5
|
Problem: regression introduced by 68d520e, changing behaviour of unblocking sockets
Solution: move unblock call to original location
|
2019-02-07 11:04:05 +01:00 |
|
Simon Giesecke
|
db8c26fce3
|
Problem: testutil_unity uses undefined names on Windows
Solution: make compilation conditional
|
2019-02-07 11:04:05 +01:00 |
|
Simon Giesecke
|
8de7e529ec
|
Problem: no test case for tcp name resolution no longer working
Solution: add test case
|
2019-02-07 11:04:05 +01:00 |
|
Simon Giesecke
|
84dc40dd90
|
Problem: regression introduced by 68d520e, leading to tcp name resolution no longer working
Solution: restore "local" flag values in call to resolve
Fixes #3394
|
2019-02-07 11:03:51 +01:00 |
|
Luca Boccassi
|
5ecf8f93e2
|
Merge pull request #3395 from somdoron/ZeroCond
Problem: invoking the conditional variable for zero time is expensive
|
2019-02-06 22:08:16 +00:00 |
|
Luca Boccassi
|
792a1e61f3
|
Merge pull request #3393 from sigiesec/add-v2-monitoring
Add v2 monitoring ipc/tipc tests
|
2019-02-06 21:34:46 +00:00 |
|
somdoron
|
462dd36d0e
|
Problem: invoking the conditional variable for zero time is expensive
Solution: for zero timeout, unlock and relock immediately instead of timedwait
|
2019-02-06 21:07:53 +02:00 |
|
Simon Giesecke
|
61e476ec89
|
Problem: MAX_SOCKET_STRING is too short for ipc wildcard binds
Solution: increase size to 256
|
2019-02-06 09:09:14 -05:00 |
|
Simon Giesecke
|
b54b55d854
|
Problem: sun_path in an AF_UNIX address might not be null-terminated
Solution: use addrlen to determine the length
|
2019-02-06 07:18:28 -05:00 |
|
Simon Giesecke
|
31015fdcfe
|
Problem: ipc_address data member does not conform with naming convention
Solution: rename data member
|
2019-02-06 07:12:21 -05:00 |
|
Simon Giesecke
|
808028fe02
|
Problem: use of unnecessary complex stringstream
Solution: use memcpy instead
|
2019-02-06 07:11:10 -05:00 |
|
Simon Giesecke
|
19c6aa5c92
|
Problem: monitor events are output as decimal in assertion messages
Solution: output as hex instead
|
2019-02-06 07:11:10 -05:00 |
|
Simon Giesecke
|
a86592f78c
|
Problem: test_monitor is not run for ipc and tipc
Solution: add test cases
|
2019-02-06 07:11:10 -05:00 |
|
Simon Giesecke
|
9b1627f041
|
Merge pull request #3391 from bluca/listener_unistd
Problem: build broken with newer gcc
|
2019-02-05 14:13:31 -05:00 |
|
Luca Boccassi
|
2df988eec3
|
Problem: build broken with newer gcc
Solution: add missing includes to stream_listener_base
|
2019-02-05 18:57:33 +00:00 |
|
Luca Boccassi
|
0b4bb92395
|
Merge pull request #3389 from sigiesec/fix-issue-3387
Problem: close always fails with wildcard bind, since directory is no…
|
2019-02-05 16:17:35 +00:00 |
|
Simon Giesecke
|
8d784f26ab
|
Problem: close always fails with wildcard bind, since directory is not empty
Solution: unlink the socket file first
|
2019-02-05 10:17:28 -05:00 |
|
Luca Boccassi
|
b14bb2d8f8
|
Merge pull request #3388 from sigiesec/add-missing-include
Problem: missing include directive for close/closesocket
|
2019-02-05 14:24:16 +00:00 |
|
Simon Giesecke
|
ded4ff6fd2
|
Problem: missing include directive for close/closesocket
Solution: add appropriate includes
|
2019-02-05 09:21:06 -05:00 |
|
Luca Boccassi
|
b8b1b8def3
|
Merge pull request #3384 from sigiesec/remove-socks-tcp-code-duplication
Remove socks/tcp code duplication
|
2019-02-05 13:19:54 +00:00 |
|
Luca Boccassi
|
69a6522741
|
Merge pull request #3386 from sigiesec/remove-locale-dependency
Problem: tcp address strings are dependent on locale
|
2019-02-05 13:18:26 +00:00 |
|
Simon Giesecke
|
74d62bb908
|
Problem: tcp address strings are dependent on locale
Solution: use sprintf instead of std::stringstream
Fixes #3385
|
2019-02-05 05:45:35 -05:00 |
|
Simon Giesecke
|
e583276380
|
Problem: unnecessary platform-specific code parts around socklen_t
Solution: use zmq_socklen_t
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
c215235fb2
|
Problem: redundant string operations in zmq::udp_engine_t::sockaddr_to_msg
Solution: reuse string lengths and use memcpy instead
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
d451a95234
|
Problem: redundant code in different preprocessor branches
Solution: change preprocessor guard scope
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
fc6ef0ebff
|
Problem: zmq::get_peer_ip_address duplicates code from get_socket_address
Solution: change to use get_socket_address
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
2f7a450294
|
Problem: socks_connecter_t duplicates code around opening and configuring a TCP socket
Solution: use tcp_open_socket function
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
68d520ef68
|
Problem: tcp_connecter_t and tcp_listener_t duplicate code around opening and configuring a TCP socket
Solution: extract common parts into tcp_open_socket function
|
2019-02-05 03:34:32 -05:00 |
|
Simon Giesecke
|
3f4e64edc0
|
Problem: bind_to_device unnecessarily accepts a non-const string parameter
Solution: add const
|
2019-02-04 09:29:42 -05:00 |
|
Simon Giesecke
|
12c4b55af8
|
Problem: socks_connecter_t duplicates code with stream_connecter_base_t
Solution: let socks_connecter_t derive from stream_connecter_base_t and remove duplicate code
|
2019-02-04 09:29:42 -05:00 |
|
Simon Giesecke
|
14da2ab629
|
Merge pull request #3382 from bluca/tipc_endpoint
Problem: tipc disconnect does not work anymore
|
2019-02-03 23:31:59 +01:00 |
|