Constantin Rack
34164ec6f5
Merge pull request #2001 from evoskuil/master
...
Problem: unresolved dgram externals in msvc builds.
2016-05-18 21:55:31 +02:00
evoskuil
c7f167377c
Problem: unresolved dgram externals in msvc builds.
2016-05-18 12:25:51 -07:00
evoskuil
6a99bb041d
Problem: implicit integer narrowing cast warnings.
2016-05-18 12:02:30 -07:00
Luca Boccassi
d018029652
Merge pull request #2000 from Chris-P-Bacon/patch-1
...
Typo in define for libsodium
2016-05-18 14:19:47 +01:00
Chris-P-Bacon
874c346c20
Typo in define for libsodium
...
Since ZMQ_USE_SODIUM is nowhere defined i guess it's meant to be ZMQ_USE_LIBSODIUM?
2016-05-18 14:52:30 +02:00
Luca Boccassi
99373ff0b4
Merge pull request #1998 from hitstergtd/x-style-testsrcfd
...
Problem: Wrapping issue in test for SRCFD [style]
2016-05-16 22:22:58 +01:00
hitstergtd
fed17746c6
Problem: Wrapping issue in test for SRCFD [style]
...
Solution:
Wrap it.
2016-05-16 20:47:47 +01:00
Luca Boccassi
5f0ac2aebe
Merge pull request #1997 from Bitiquinho/master
...
Problem: my name is not in the AUTHORS file
2016-05-16 15:03:26 +01:00
Bitiquinho
c1af4fd24b
Add myself to the AUTHORS file
2016-05-16 10:46:45 -03:00
Luca Boccassi
d65d15fb63
Merge pull request #1996 from somdoron/udp_raw_sockets
...
problem: no way to send raw udp messages with zeromq
2016-05-16 14:16:09 +01:00
somdoron
bbfed6b8d0
problem: memory issues, access uninitiailized memory and leak
2016-05-16 15:51:08 +03:00
Luca Boccassi
c7effea912
Merge pull request #1995 from somdoron/udp_raw_sockets
...
problem: udp doesn't enforce correct usage of bind/connect
2016-05-16 11:49:19 +01:00
somdoron
c4d0146f2c
problem: udp doesn't enforce correct usage of bind/connect
...
solution: enforce that dish and gram can only bind and radio can only
connect
2016-05-16 13:34:38 +03:00
Luca Boccassi
443176d5ef
Merge pull request #1994 from somdoron/udp_raw_sockets
...
problem: no way to send raw udp messages with zeromq.
2016-05-16 11:07:58 +01:00
Doron Somech
0db70e247c
problem: compilation error on windows
2016-05-16 12:48:47 +03:00
somdoron
d58eb54581
problem: test_dgram is missing in .gitignore
2016-05-16 12:19:38 +03:00
somdoron
55f0a5503e
problem: dgram is not enforcing two-part message
2016-05-16 12:18:36 +03:00
somdoron
ded0e5a6d9
problem: udp_engine didn't work with dgram socket type
2016-05-16 12:18:36 +03:00
somdoron
6db8f1e74b
problem: test is using connect with dgram, dgram only support bind
2016-05-16 12:18:30 +03:00
somdoron
eb80fa31ea
problem: dgram more out logic was incorrect
2016-05-16 12:07:07 +03:00
somdoron
47c0b6ec25
problem: dgram doesn't need to prefetch messages
2016-05-16 10:31:38 +03:00
somdoron
d791932635
problem: terminating conn doesn't make sense in disconnected protocol
2016-05-16 10:28:42 +03:00
Bitiquinho
8cd64b76e4
Adapt to new draft header. Rebase dgram socket on pair socket
2016-05-15 16:16:09 -03:00
Bitiquinho
23b3403fa5
Remove printf and add asserts on test
2016-05-15 15:37:33 -03:00
Bitiquinho
977e700893
Fix Copyright range
2016-05-15 15:37:33 -03:00
Bitiquinho
a7399fab51
Fix Makefile.am
2016-05-15 15:37:33 -03:00
Bitiquinho
da14bb4bc2
Added ZMQ_DGRAM tests to build (Makefile.am and CMakeLists.txt)
2016-05-15 15:37:33 -03:00
Bitiquinho
94c53e541d
Added test for ZMQ_DGRAM socket type (unicast and multicast)
2016-05-15 15:37:33 -03:00
Bitiquinho
cea473de59
Added ZMQ_DGRAM socket option to precmpiled.hpp
2016-05-15 15:37:33 -03:00
Bitiquinho
3e54ecd49c
Added dgram.cpp to CMakeLists.txt sources
2016-05-15 15:35:35 -03:00
Bitiquinho
365c8eda72
Add dgram_t class (based on stream socket and udp engine)
2016-05-15 15:35:35 -03:00
Luca Boccassi
72f19648d1
Merge pull request #1992 from evoskuil/master
...
Problem: name confl from windows.h, draft API decl in pch.
2016-05-14 11:49:08 +01:00
evoskuil
8474dc3c53
Problem: precompiled.cpp/hpp required but excluded from non-msvc builds.
2016-05-14 03:29:11 -07:00
Constantin Rack
bd66cfe6f8
Merge pull request #1991 from hitstergtd/x-testcov-zmq-2
...
Problem: zmq_poller_destroy can segfault
2016-05-14 08:17:41 +02:00
evoskuil
5939debe41
Problem: incorrect file extension (.hpp) for zmq_draft.h in Makefile.am.
2016-05-13 20:55:17 -07:00
evoskuil
2b798e486a
Problem: name conflicts from windows.h, draft API declared in pch.
2016-05-13 20:41:26 -07:00
evoskuil
bda9374864
Problem: inadvertently deployed nuget package without tweetnacl enabled.
2016-05-13 04:08:40 -07:00
evoskuil
a3aa10c06b
Problem: nuget packaging script doesn't pause at the end.
2016-05-13 04:07:21 -07:00
Luca Boccassi
94774f6915
Merge pull request #1988 from evoskuil/master
...
Problem: msvc builds are misconfigured.
2016-05-13 11:48:19 +01:00
evoskuil
5e0fb27cc6
Problem: tab characters are poor for source readability.
2016-05-13 03:25:30 -07:00
evoskuil
af524aed6b
Problem: msvc dist has redundancies and missing elements.
2016-05-13 03:22:01 -07:00
evoskuil
9e26bb1885
Problem: typo in platform.hpp comment.
2016-05-13 02:30:37 -07:00
evoskuil
1c9d02d700
Problem: mo current nuget package.
2016-05-13 02:24:45 -07:00
evoskuil
7684ce4fcd
Problem: incorrect white spacing for standard vcxproj file.
2016-05-13 01:48:08 -07:00
evoskuil
9622a830d0
Problem: inapplicable, redundant and invalid references in msvc pch.
2016-05-13 01:40:14 -07:00
evoskuil
4b041ef67d
Problem: nuget package using wrong symbol and configured for libsodium.
2016-05-13 01:05:42 -07:00
evoskuil
2113feec39
Problem: msvc precompiled header config is a mess, tweetnacl is missing.
2016-05-13 01:04:22 -07:00
evoskuil
0db07394d0
Problem: msvc configuration options are invalid and/or inconsistent.
2016-05-13 01:00:58 -07:00
evoskuil
01ab149b96
Problem: copy of libsodium import props is unnecessary.
2016-05-13 00:56:09 -07:00
evoskuil
7425fcca80
Problem: incorrect include guard symbol.
2016-05-13 00:47:03 -07:00
evoskuil
40d7a4c896
Problem: redundant copies of msvc .props and .xml files.
2016-05-13 00:46:06 -07:00
Joe Eli McIlvain
71ba7df781
Merge pull request #1987 from hitstergtd/x-reduce-cliserv-sends
...
Problem: test send count too high for AppVeyor CI environment
2016-05-12 20:15:08 -07:00
hitstergtd
e82e4ea13e
Problem: test send count too high for AppVeyor
...
Solution:
Reduce send count so that the test does not timeout on AppVeyor CI
environment and older Windows boxes.
2016-05-13 04:04:08 +01:00
evoskuil
f25a13bc8a
Problem: configure.bat is incomplete and conflicts with MSVC UI.
2016-05-12 15:36:18 -07:00
Constantin Rack
9e872d0269
Merge pull request #1984 from hitstergtd/x-testcov-zmq-ctx
2016-05-12 19:21:31 +02:00
hitstergtd
477cc1cb12
Problem: zmq_poller_destroy parameter checking
...
Solution:
- Add checks for **poller_p_ to ensure that we do not segfault when either it
or the value within it are NULL
- Add tests for the above and increase error state coverage
2016-05-12 18:09:59 +01:00
hitstergtd
4842b6bd81
Problem: No coverage for ctx termination errors
...
Solution:
- Add error state coverage for zmq_ctx_term(), zmq_term() and
zmq_ctx_shutdown(); zmq_ctx_destroy() is already covered since it only
calls zmq_ctx_term()
- Add coverage for zmq_term()
2016-05-12 17:47:08 +01:00
Luca Boccassi
f8c93d508f
Merge pull request #1983 from hitstergtd/x-unused-thread
...
Problem: scheduling parameters unused on OSX
2016-05-12 16:53:22 +01:00
hitstergtd
e946b0d1a6
Problem: scheduling parameters unused on OSX
...
Solution:
Mark them with LIBZMQ_UNUSED macro as per convention; although in future the
appropriate pthread code should be updated to support thread scheduling
priorities (for Mac OS X, et. al.)
2016-05-12 16:36:59 +01:00
evoskuil
bce1cf96d9
Problem: vc common props have platform specific conditions.
2016-05-12 03:36:39 -07:00
evoskuil
a3c3bcfe4a
Problem: visual c++ invalid ToolsVersion warnings.
2016-05-12 03:31:52 -07:00
evoskuil
9cb7077e3d
Problem: inconsistent msvc property sheet display name (vs2012).
2016-05-12 03:15:16 -07:00
evoskuil
b5342bc008
Problem: no tool for maintainers to build all vs solutions.
2016-05-12 03:14:37 -07:00
evoskuil
398a5fd454
Problem: vs2010/12 build breaks, exclude atomic & inttypes in msvc pch.
2016-05-12 03:14:30 -07:00
Hitster GTD
29c8e30fc0
Merge pull request #1982 from Hugne/bug_1968
...
tipc: add support for address domain suffix
2016-05-11 21:17:23 +01:00
Erik Hugne
f81ef1bc72
tipc: add support for address domain suffix
...
The TIPC protocol bindings in ZeroMQ defaults to a lookup domain
of 1.0.0 to prevent 'closest first' search, and instead always
do round robin if several sockets in the network or node have
the same name published. In retrospect, this might have been a
bad idea because it won't work on standalone configurations.
We solve this by allowing an optional domain suffix to be provided
in the address, and 0.0.0 should be used in that case, or if the
TIPC address range in the cluster configuration is defined to some
other value. Domain suffixes are only relevant for connecting
addresses.
Signed-off-by: Erik Hugne <erik.hugne@gmail.com>
2016-05-11 21:54:25 +02:00
Luca Boccassi
4ad68e0dfe
Merge pull request #1981 from hitstergtd/x-unused-req
...
Problem: hint parameter throws unused warning
2016-05-11 15:57:12 +01:00
Luca Boccassi
10a84ac8b1
Merge pull request #1979 from dmillard/patch-1
...
Fix autotools for static MinGW builds
2016-05-10 22:11:59 +01:00
David Millard
9e6745c12e
Fix autotools for static MinGW builds
2016-05-10 13:53:53 -07:00
Luca Boccassi
c7ecbedb0e
Merge pull request #1977 from hitstergtd/x-unused-variables
...
Problem: sockfd_ parameter throws unused warning
2016-05-10 18:43:22 +01:00
hitstergtd
5efa11828c
Problem: hint parameter throws unused warning
...
Solution:
Mark it with LIBZMQ_UNUSED macro as per convention.
2016-05-10 18:22:15 +01:00
hitstergtd
545e8e848e
Problem: sockfd_ parameter throws unused warning
...
Solution:
Mark it with LIBZMQ_UNUSED as per our convention.
2016-05-10 18:12:44 +01:00
Luca Boccassi
dc7296537c
Merge pull request #1976 from zeromq/revert-1975-master
...
Revert "problem:Socket try to access closed mutex"
2016-05-10 14:31:57 +01:00
Doron Somech
c41d514b8b
Revert "problem:Socket try to access closed mutex"
2016-05-10 16:23:29 +03:00
Constantin Rack
f6ce1d764c
Merge pull request #1975 from somdoron/master
2016-05-10 13:00:31 +02:00
Doron Somech
77d3d7b4dc
problem:Socket try to access closed mutex
2016-05-10 13:49:57 +03:00
Luca Boccassi
a6e8d153cb
Merge pull request #1974 from hitstergtd/master
...
Problem: style/typo issue
2016-05-09 14:59:19 +01:00
hitstergtd
8fc985a9b0
Problem: style/typo issue
...
Solution:
Fix it.
2016-05-09 14:24:12 +01:00
Luca Boccassi
a4a247cf57
Merge pull request #1973 from hitstergtd/x-fix-m4-llvm-gcov-coverage
...
Problem: Coverage option broken with LLVM GCOV Frontend
2016-05-09 14:10:50 +01:00
Constantin Rack
3eef0a7ba8
Merge pull request #1972 from hitstergtd/x-stylefix-udpengine
...
Problem: UDP engine code not indented properly [style]
2016-05-09 14:30:31 +02:00
hitstergtd
415af27395
Problem: Coverage option broken with LLVM GCOV
...
Solution:
This is an issue with the imported Autoconf M4 macro package for standardised
code coverage builds, i.e. using --enable-code-coverage.
The simplest way that I could find is to add a case statement that checks if
the output of running `gcov -version` contains the "LLVM" keyword; if that is
true then do not link with LIBGCOV as its neither required nor supported when
using the GCOV frontend for LLVM; least not on Mac OS X. The case statement
would also be the most portable.
Moreover, using the "-version" argument instead of "-v" seems to be the best
bet as that is supported by the normal GCOV and LLVM GCOV frontend.
Upstream candidate - this solution should be improved by Autoconf M4 macro
overlords and applied to the upstream M4 package; I could not find a suitable
way to detect if LLVM GCOV is being used, except for the solution herein; this
should also work on *BSD too.
2016-05-09 13:27:41 +01:00
Luca Boccassi
1f309d3a3d
Merge pull request #1971 from sappo/master
...
Problem: Deploying release artifacts to github is a manual process
2016-05-09 10:15:13 +01:00
Kevin Sapper
b22558119d
Problem: Deploying release artifacts is a manual process
...
Solution: Use travis to deploy these artifacts automatically.
The deployment is triggered by tagging on the zeromq/libzmq repository.
Of the many builds travis is checking only the default one with
libsodium and drafts disabled is used for deployment.
For now the results of `make distcheck` are deployed as well as their
md5 and sha1 hash sums. Further changes may upload a generated
Changelog as well.
2016-05-09 10:30:13 +02:00
Luca Boccassi
c4ce6d9b1b
Merge pull request #1970 from hitstergtd/x-add-ancillary-tests
...
Problem: Not all ancillary API methods tested
2016-05-08 18:36:03 +01:00
hitstergtd
124ebd2dd6
Problem: UDP engine code not indented properly
...
Solution:
Indent it.
2016-05-08 18:30:17 +01:00
hitstergtd
206771afd2
Problem: Not all ancillary API methods tested
...
Solution:
- Add file for testing ancillary API methods and any misc internal machinery
- Add tests for zmq_version(3) and zmq_strerror(3)
- Add test file into gitignore, Autotools and CMake build files
- Increase test coverage
Note:
MSVC solution files have not been updated.
2016-05-08 18:25:03 +01:00
Constantin Rack
d6aa6e71ec
Merge pull request #1969 from pijyoi/fix_invalidsocket
...
problem: sockets are not signed int on Windows
2016-05-08 10:40:14 +02:00
KIU Shueng Chuan
bb4bcf8f45
fix: sockets are not signed int on Windows
2016-05-08 16:29:15 +08:00
Doron Somech
f88d129b50
Merge pull request #1966 from bluca/backtrace_assert
...
Problem: no backtrace is printed on assert
2016-05-06 23:45:47 +03:00
Luca Boccassi
bb5037e855
Problem: leftover commented out line in configure
...
Solution: clean up and remove it
2016-05-06 21:34:43 +01:00
Luca Boccassi
8045e9ae24
Problem: no backtrace is printed on assert
...
Solution: add an optional dependency on libunwind, and if present
use it to print the backtrace when zmq_abort is called.
2016-05-06 21:34:25 +01:00
Luca Boccassi
c1dc9d0244
Merge pull request #1967 from hitstergtd/x-add-militant-option
...
Problem: No CMake option to set ZMQ_ACT_MILITANT
2016-05-06 21:05:40 +01:00
hitstergtd
6ea9dbc9ce
Problem: No CMake option to set ZMQ_ACT_MILITANT
...
Solution:
Add CMake option called WITH_MILITANT so that it aligns with the Autotools
build infrastructure; enabling this option defines ZMQ_ACT_MILITANT, which
enables assertions should malformed requests make their way into
zmq_setsockopt(3) or zmq_getsockopt(3).
2016-05-06 20:57:54 +01:00
Doron Somech
f98b5bb5cf
Merge pull request #1964 from bluca/sock_close_read_after_free
...
Problem: read-after-free when closing socket
2016-05-05 23:33:04 +03:00
Luca Boccassi
17132f0387
Problem: read-after-free when closing socket
...
Solution: use socket object's mutex before the send_reap() call that
might deallocate it
2016-05-05 17:47:16 +01:00
Constantin Rack
e9380b5a1a
Merge pull request #1962 from somdoron/master
...
problem: timers test is flapping on windows
2016-05-05 13:47:44 +02:00
Doron Somech
be741f604a
problem: timers test is flapping on windows
2016-05-05 14:24:47 +03:00
Constantin Rack
5dadded0a1
Merge pull request #1961 from somdoron/Signaler
...
problem: closed poller still associated with socket
2016-05-05 12:57:24 +02:00
Doron Somech
a747f72450
problem:closed poller still associated with socket
2016-05-05 13:50:33 +03:00
Luca Boccassi
fb75b201c3
Merge pull request #1960 from hitstergtd/x-sort-AUTHORS
...
Problem: AUTHORS file is not sorted
2016-05-05 11:02:41 +01:00