Luca Boccassi
a6e8d153cb
Merge pull request #1974 from hitstergtd/master
...
Problem: style/typo issue
2016-05-09 14:59:19 +01:00
hitstergtd
8fc985a9b0
Problem: style/typo issue
...
Solution:
Fix it.
2016-05-09 14:24:12 +01:00
Luca Boccassi
a4a247cf57
Merge pull request #1973 from hitstergtd/x-fix-m4-llvm-gcov-coverage
...
Problem: Coverage option broken with LLVM GCOV Frontend
2016-05-09 14:10:50 +01:00
Constantin Rack
3eef0a7ba8
Merge pull request #1972 from hitstergtd/x-stylefix-udpengine
...
Problem: UDP engine code not indented properly [style]
2016-05-09 14:30:31 +02:00
hitstergtd
415af27395
Problem: Coverage option broken with LLVM GCOV
...
Solution:
This is an issue with the imported Autoconf M4 macro package for standardised
code coverage builds, i.e. using --enable-code-coverage.
The simplest way that I could find is to add a case statement that checks if
the output of running `gcov -version` contains the "LLVM" keyword; if that is
true then do not link with LIBGCOV as its neither required nor supported when
using the GCOV frontend for LLVM; least not on Mac OS X. The case statement
would also be the most portable.
Moreover, using the "-version" argument instead of "-v" seems to be the best
bet as that is supported by the normal GCOV and LLVM GCOV frontend.
Upstream candidate - this solution should be improved by Autoconf M4 macro
overlords and applied to the upstream M4 package; I could not find a suitable
way to detect if LLVM GCOV is being used, except for the solution herein; this
should also work on *BSD too.
2016-05-09 13:27:41 +01:00
Luca Boccassi
1f309d3a3d
Merge pull request #1971 from sappo/master
...
Problem: Deploying release artifacts to github is a manual process
2016-05-09 10:15:13 +01:00
Kevin Sapper
b22558119d
Problem: Deploying release artifacts is a manual process
...
Solution: Use travis to deploy these artifacts automatically.
The deployment is triggered by tagging on the zeromq/libzmq repository.
Of the many builds travis is checking only the default one with
libsodium and drafts disabled is used for deployment.
For now the results of `make distcheck` are deployed as well as their
md5 and sha1 hash sums. Further changes may upload a generated
Changelog as well.
2016-05-09 10:30:13 +02:00
Luca Boccassi
c4ce6d9b1b
Merge pull request #1970 from hitstergtd/x-add-ancillary-tests
...
Problem: Not all ancillary API methods tested
2016-05-08 18:36:03 +01:00
hitstergtd
124ebd2dd6
Problem: UDP engine code not indented properly
...
Solution:
Indent it.
2016-05-08 18:30:17 +01:00
hitstergtd
206771afd2
Problem: Not all ancillary API methods tested
...
Solution:
- Add file for testing ancillary API methods and any misc internal machinery
- Add tests for zmq_version(3) and zmq_strerror(3)
- Add test file into gitignore, Autotools and CMake build files
- Increase test coverage
Note:
MSVC solution files have not been updated.
2016-05-08 18:25:03 +01:00
Constantin Rack
d6aa6e71ec
Merge pull request #1969 from pijyoi/fix_invalidsocket
...
problem: sockets are not signed int on Windows
2016-05-08 10:40:14 +02:00
KIU Shueng Chuan
bb4bcf8f45
fix: sockets are not signed int on Windows
2016-05-08 16:29:15 +08:00
Doron Somech
f88d129b50
Merge pull request #1966 from bluca/backtrace_assert
...
Problem: no backtrace is printed on assert
2016-05-06 23:45:47 +03:00
Luca Boccassi
bb5037e855
Problem: leftover commented out line in configure
...
Solution: clean up and remove it
2016-05-06 21:34:43 +01:00
Luca Boccassi
8045e9ae24
Problem: no backtrace is printed on assert
...
Solution: add an optional dependency on libunwind, and if present
use it to print the backtrace when zmq_abort is called.
2016-05-06 21:34:25 +01:00
Luca Boccassi
c1dc9d0244
Merge pull request #1967 from hitstergtd/x-add-militant-option
...
Problem: No CMake option to set ZMQ_ACT_MILITANT
2016-05-06 21:05:40 +01:00
hitstergtd
6ea9dbc9ce
Problem: No CMake option to set ZMQ_ACT_MILITANT
...
Solution:
Add CMake option called WITH_MILITANT so that it aligns with the Autotools
build infrastructure; enabling this option defines ZMQ_ACT_MILITANT, which
enables assertions should malformed requests make their way into
zmq_setsockopt(3) or zmq_getsockopt(3).
2016-05-06 20:57:54 +01:00
Doron Somech
f98b5bb5cf
Merge pull request #1964 from bluca/sock_close_read_after_free
...
Problem: read-after-free when closing socket
2016-05-05 23:33:04 +03:00
Luca Boccassi
17132f0387
Problem: read-after-free when closing socket
...
Solution: use socket object's mutex before the send_reap() call that
might deallocate it
2016-05-05 17:47:16 +01:00
Constantin Rack
e9380b5a1a
Merge pull request #1962 from somdoron/master
...
problem: timers test is flapping on windows
2016-05-05 13:47:44 +02:00
Doron Somech
be741f604a
problem: timers test is flapping on windows
2016-05-05 14:24:47 +03:00
Constantin Rack
5dadded0a1
Merge pull request #1961 from somdoron/Signaler
...
problem: closed poller still associated with socket
2016-05-05 12:57:24 +02:00
Doron Somech
a747f72450
problem:closed poller still associated with socket
2016-05-05 13:50:33 +03:00
Luca Boccassi
fb75b201c3
Merge pull request #1960 from hitstergtd/x-sort-AUTHORS
...
Problem: AUTHORS file is not sorted
2016-05-05 11:02:41 +01:00
Doron Somech
001ddd80cc
Merge pull request #1958 from hitstergtd/x-deprecate-zmq-sendrecviov-fix
...
Problem: zmq_sendiov/zmq_recviov not Deprecated
2016-05-04 19:14:38 +03:00
KAPP Arnaud
a46d7b994f
Merge pull request #1959 from hitstergtd/x-zmqpoll-fix
...
Problem: style issues with comment in zmq_poll
2016-05-04 17:55:55 +02:00
hitstergtd
b3bb0b7f1c
Problem: zmq_sendiov/zmq_recviov not Deprecated
...
Solution:
As preparation for 4.2 release, move the zmq_sendiov and zmq_recviov API
methods under the Deprecated Methods section.
Note: the actual methods have NOT been deprecated yet, functionally speaking
however it is good to let API users know early. Moreover, these methods were
not ever considered stable, at least according to src/zmq.h, and have no
associated man pages.
2016-05-04 16:48:10 +01:00
hitstergtd
109122dd46
Problem: style issues with comment in zmq_poll
...
Solution:
Wrap and clean it.
2016-05-04 16:24:51 +01:00
Luca Boccassi
c33e96f2d2
Merge pull request #1957 from hitstergtd/x-TIPC-CMake-fix
...
Problem: ZMQ_HAVE_TIPC option for CMake is broken
2016-05-04 16:18:26 +01:00
hitstergtd
b470ed451f
Problem: ZMQ_HAVE_TIPC option for CMake is broken
...
Solution:
Fix it - there was a typo in the source list variable; it should be
'cpp-sources' and not 'cpp-source'.
2016-05-04 16:15:28 +01:00
Luca Boccassi
00d7ee1646
Merge pull request #1956 from hitstergtd/x-addto-AUTHORS-file
...
Problem: Not shamelessly plugged into AUTHORS
2016-05-04 16:12:59 +01:00
Luca Boccassi
ad82bd1b1a
Merge pull request #1955 from hitstergtd/x-remove-MAINTAINERS-file
...
Problem: MAINTAINERS file has no purpose anymore
2016-05-04 16:08:13 +01:00
hitstergtd
6ae2ff6446
Problem: MAINTAINERS file has no purpose anymore
...
Solution:
Remove until such time that a new and appropriate file can replace it should
it be deemed necessary.
2016-05-04 16:06:33 +01:00
Luca Boccassi
745e07d93c
Merge pull request #1954 from somdoron/master
...
problem: compilation error on osx
2016-05-04 14:15:08 +01:00
Doron Somech
e15da4b38c
problem: compilation error on osx
2016-05-04 16:09:31 +03:00
Luca Boccassi
feec47604f
Merge pull request #1953 from somdoron/master
...
problem: src is broken and unneeded as we have metadata
2016-05-04 13:35:19 +01:00
Doron Somech
ba20f665ae
problem: SRCFD is redundant as we have metadata
2016-05-04 15:33:20 +03:00
Doron Somech
4012538ce4
problem: srcfd is broken
2016-05-04 15:33:19 +03:00
Doron Somech
a192663ece
Merge pull request #1951 from hitstergtd/x-monitorcomment-fix
...
Problem: supported protocols comment is stale
2016-05-04 09:56:46 +03:00
Luca Boccassi
372ab4b8fe
Merge pull request #1949 from somdoron/master
...
problem: zeromq performance got worsen by some changes
2016-05-03 17:58:55 +01:00
somdoron
50c2f7af8f
fix sndbuf/rcvbuf tests
2016-05-03 19:46:34 +03:00
somdoron
fca45921a8
problem: zeromq performance got worsen by some changes
2016-05-03 19:37:39 +03:00
Luca Boccassi
115e7de7d2
Merge pull request #1948 from hitstergtd/x-gitignore-fix
...
Problem: Not all GCOV extensions in .gitignore
2016-05-03 11:50:38 +01:00
hitstergtd
e68c8ae1eb
Problem: Not all GCOV extensions in .gitignore
...
Solution:
Fix it.
2016-05-03 11:38:25 +01:00
Luca Boccassi
fc7d5e7fbb
Merge pull request #1946 from somdoron/master
...
problem: no way to enable draft on windows
2016-05-03 09:05:24 +01:00
Doron Somech
b3667cccf9
mark zmq_msg new methods as draft
2016-05-03 10:44:00 +03:00
Doron Somech
fcc80d4ffb
add draft option to windows configure
2016-05-03 10:18:46 +03:00
Doron Somech
91394d27c7
Merge pull request #1945 from bluca/draft_api
...
problem: no way to disable draft when compiling
2016-05-03 08:01:37 +03:00
Luca Boccassi
b741350745
Problem: test_pub_invert_matching not ignored
...
Solution: add it to .gitignore
2016-05-02 22:51:30 +01:00
Luca Boccassi
a782be73ac
Problem: no CI tests with DRAFT enabled
...
Solution: do default test with DRAFT APIs enabled
2016-05-02 22:51:30 +01:00
Luca Boccassi
6de24c190a
Problem: scatter/gather are not yet stable APIs
...
Solution: mark them as DRAFT APIs
2016-05-02 21:47:05 +01:00
Luca Boccassi
caaf66c32c
Problem: radio/dish are not yet stable APIs
...
Solution: mark them as DRAFT APIs
2016-05-02 21:47:05 +01:00
Luca Boccassi
32a1ef85a8
Problem: zmq_timers* are not yet stable APIs
...
Solution: mark them as DRAFT APIs
2016-05-02 21:47:05 +01:00
Luca Boccassi
738968082b
Problem: zmq_poller* are not yet stable APIs
...
Solution: mark them as DRAFT APIs
2016-05-02 21:47:05 +01:00
Luca Boccassi
7e700f1e73
Problem: client/server are not yet stable APIs
...
Solution: mark them as DRAFT APIs
2016-05-02 21:47:05 +01:00
Luca Boccassi
064cd1fbfb
Problem: no support for DRAFT API in build systems
...
Solution: add support for --enable-drafts/ENABLE_DRAFTS=ON in
Autools and CMake.
2016-05-02 21:47:05 +01:00
Luca Boccassi
f0a34e0ff5
Problem: test_poller/use_fd_ipc/tcp use draft API
...
Solution: only use ZMQ_SERVER/CLIENT if the defines are available.
2016-05-02 21:46:47 +01:00
Luca Boccassi
c293618ae8
Problem: testutil.hpp includes platform.hpp last
...
Solution: before including internal headers, include platform.hpp
so that the build time options are correctly applied to the included
headers.
2016-05-02 20:00:53 +01:00
Luca Boccassi
b469832409
Problem: precompiled.hpp ifdef'd for windows
...
Solution: include platform.hpp and include/zmq.h outside of ifdef
for windows, in order to be able to use it for internal definitions.
2016-05-02 20:00:53 +01:00
Luca Boccassi
464d3fd3f8
Merge pull request #1944 from hitstergtd/x-testmonitor-fix
...
Problem: bounce() arguments reversed
2016-05-02 17:26:15 +01:00
Luca Boccassi
b65fc903cd
Merge pull request #1943 from hitstergtd/x-style-tunetcpkeepalives-fix
...
Problem: tune_tcp* related code has style issues
2016-05-02 17:25:48 +01:00
Luca Boccassi
dc81aac195
Merge pull request #1940 from hitstergtd/x-update-autoconf-archive-m4-macros
...
Problem: autoconf-archive m4 macros out of date
2016-05-02 16:52:09 +01:00
hitstergtd
52871b0f3c
Problem: autoconf-archive m4 macros out of date
...
Solution:
Update them from the latest archive located at:
git://git.savannah.gnu.org/autoconf-archive.git
Hat-tip:
@bluca
2016-05-02 16:12:27 +01:00
Luca Boccassi
a8f756173a
Merge pull request #1941 from hitstergtd/x-doc-setsockopt-fix
...
Problem: zmq_setsockopt(3) man page formatting
2016-05-02 09:23:32 +01:00
hitstergtd
1ab7dd0122
Problem: supported protocols comment is stale
...
Solution:
Fix it and align with the documentation; zmq_socket_monitor(3) outlines
that ZMQ socket monitoring is supported for TCP, IPC and TIPC.
2016-05-01 22:00:20 +01:00
hitstergtd
40dbbe342e
Problem: bounce() arguments reversed
...
Solution:
Put them in the right order to quiet Coverity.
Found by:
Coverity Scan
2016-05-01 21:40:08 +01:00
hitstergtd
4809926c10
Problem: zmq_setsockopt(3) man page formatting
...
Solution:
- Update formatting and remove redundant parts from ZMQ_PROBE_ROUTER,
ZMQ_USE_FD, ZMQ_TCP_MAXRT, ZMQ_TCP_TOS
- Only cosmetic changes to the content
- These changes already merged on api.zeromq.org by me
2016-05-01 20:32:22 +01:00
Luca Boccassi
b3ae7cfa0d
Merge pull request #1937 from hitstergtd/test-add-sendiov
...
Problem: multiple issues with zmq_sendiov/recviov
2016-05-01 20:01:07 +01:00
hitstergtd
e4539778a4
Problem: multiple issues with sendiov/recviov
...
Solution:
- Add check for the [count] parameter in zmq_sendiov() and zmq_recviov()
- Use and add test for zmq_sendiov() in tests/test_iov.cpp
- Add error state tests for zmq_sendiov() in tests/test_iov.cpp
- Add error state tests for zmq_recviov() in tests/test_iov.cpp
- Cleanup tests/test_iov.cpp for style, consistency and clarity
- Generally improve test coverage for both API methods
Hat-tip:
@somdoron, @bluca
2016-05-01 19:41:50 +01:00
hitstergtd
a31c508979
Problem: tune_tcp* related code has style issues
...
Solution: fix it
2016-05-01 14:42:27 +01:00
Luca Boccassi
89ef8b38c0
Merge pull request #1938 from hitstergtd/decoder-fix
...
Problem: style issues in decoder.hpp
2016-05-01 12:30:10 +01:00
hitstergtd
d7038bf11b
Problem: AUTHORS file is not sorted
...
Solution: sort it and strip trailing whitespaces
2016-04-30 21:51:02 +01:00
hitstergtd
56e83d0eb6
Problem: Not shamelessly plugged into AUTHORS
...
Solution: plug myself in
2016-04-30 21:34:54 +01:00
hitstergtd
8820e35a56
Problem: style issues in decoder.hpp
...
Solution: fix it
2016-04-30 21:20:31 +01:00
Luca Boccassi
95acb29bfb
Merge pull request #1934 from somdoron/master
...
problem: no documentation for Radio-dish and UDP
2016-04-29 10:40:56 +01:00
somdoron
fee84134e7
UDP and Radio-dish documentation
2016-04-29 12:17:17 +03:00
somdoron
34d5028ea8
allow specify binding address on radio with udp
2016-04-29 12:17:17 +03:00
Doron Somech
9ec9c4ad0c
Merge pull request #1933 from sappo/master
...
Problem: relicense statement from imatix is in the wrong place
2016-04-29 11:50:59 +03:00
Kevin Sapper
a1ee5e3136
Problem: relicense statement from imatix is in the wrong place
...
Solution: move the statement to the folder introduced in commit:
dd51cad082923a5973cdaff9c0418e5ab28de763
2016-04-29 09:47:39 +02:00
Kevin Sapper
5264a9afce
Merge pull request #1917 from hintjens/master
...
Problem: need to collect grants to relicense under MPLv2
2016-04-29 09:39:23 +02:00
Kevin Sapper
c1155fad71
Merge pull request #1925 from ewen-naos-nz/ewen_mcneill_relicense_naos
...
Naos Ltd license grant/quitclaim
2016-04-29 09:38:56 +02:00
Kevin Sapper
f64c8429b9
Merge pull request #1924 from ewen-naos-nz/ewen_mcneill_relicense_readme
...
RELICENSE: Start collecting MPLv2 license grants
2016-04-29 09:38:18 +02:00
Doron Somech
f7cf246373
Merge pull request #1932 from hitstergtd/doxygen-libzmq
...
Problem: libzmq lacks a good doxygen config
2016-04-29 09:36:20 +03:00
hitstergtd
f950f2ba69
Problem: No default doxygen cfg for ZeroMQ project
...
Solution:
- Add Doxygen.cfg file to make it simpler for library users and interested
parties to view library internals/externals
- Add README.doxygen.md as an Overview for Doxygen-generated documentation
Notes:
This could later be added into CI for autogenerated documentation that could be
posted to the gh-pages branch.
2016-04-28 14:14:38 +01:00
Luca Boccassi
6712f6dd01
Merge pull request #1931 from hitstergtd/unistd-fix
...
Problem: unistd.h redundantly included twice
2016-04-27 11:15:14 +01:00
Ewen McNeill
e604bbcc13
RELICENSE: Link to 0MQ Licensing page
2016-04-27 20:27:09 +12:00
Doron Somech
3df0a4f7e4
Merge pull request #1929 from hitstergtd/autotools-fix
...
Problem: test_pub_invert_matching missing in autotools build
2016-04-26 19:01:36 +03:00
hitstergtd
9218441f97
Problem: unistd.h redundantly included twice
...
Solution: fix it
2016-04-26 16:57:30 +01:00
hitstergtd
876ee5d6b4
Problem: test_pub_invert_matching missing in autotools build
...
Solution:
- add it to Makefile.am
2016-04-26 16:29:06 +01:00
Doron Somech
4b3199fefa
Merge pull request #1927 from hitstergtd/codespell-fixes
...
Problem: tune_tcp_keepalives signature more than 80 chars on a line
2016-04-25 16:02:11 +03:00
Luca Boccassi
af82d0641c
Merge pull request #1926 from hitstergtd/codespell-fixes
...
Problem: typos and trailing whitespace in code/comments
2016-04-25 13:44:47 +01:00
hitstergtd
d3c800a237
Problem: tune_tcp_keepalives signature >80 chars
...
Solution: fix it
2016-04-25 13:43:10 +01:00
hitstergtd
b2d0ab18f2
Problem: trailing whitespace in code
...
Solution: fix them
2016-04-25 12:18:46 +01:00
hitstergtd
11311f9776
Problem: trailing spaces in code comments
...
Solution: fix them
2016-04-25 11:18:49 +01:00
hitstergtd
a4b426b18e
Problem: typos/trailing spaces in code comments
...
Solution: fix them
2016-04-25 11:16:26 +01:00
Ewen McNeill
0e5ea0c8f0
RELICENSE: Naos Ltd MPLv2 grant
2016-04-25 11:28:04 +12:00
Ewen McNeill
dd51cad082
RELICENSE: Start collecting MPLv2 license grants
2016-04-25 11:24:50 +12:00
Luca Boccassi
7b9005a7a1
Merge pull request #1923 from hitstergtd/testxpubmanual-msvc-fix
...
Problem: XPUB test broken since #1566 on Windows
2016-04-24 17:04:40 +01:00
hitstergtd
8872809337
Problem: XPUB test broken since #1566 on Windows
...
Solution:
- Adjust test_xpub_proxy_unsubscribe_disconnect() to support different
protocol types
- Exclude the IPC tests on Windows and OpenVMS
H/T: @somdoron
2016-04-24 16:56:06 +01:00
Constantin Rack
fb015569a2
Merge pull request #1921 from somdoron/master
...
problem: no way to detect in czmq if timers class available
2016-04-24 11:32:53 +02:00