From ba9274c39a8884ce242c40d015c52e0e2fc74ba9 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Sat, 12 May 2018 16:19:49 +0100 Subject: [PATCH] Problem: test_heartbeats mocked ZMQ_REP is hacky and fragile Solution: remove it, it doesn't add much value anyway --- tests/test_heartbeats.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tests/test_heartbeats.cpp b/tests/test_heartbeats.cpp index 15cd481a..92c40bb4 100644 --- a/tests/test_heartbeats.cpp +++ b/tests/test_heartbeats.cpp @@ -85,10 +85,6 @@ static void recv_with_retry (raw_socket fd, char *buffer, int bytes) assert (received <= bytes); if (received == bytes) break; - // ZMQ_REP READY message is shorter, check the actual socket type - if (received >= 3 && buffer[received - 1] == 'P' - && buffer[received - 2] == 'E' && buffer[received - 3] == 'R') - break; } } @@ -358,11 +354,6 @@ void test_heartbeat_timeout_router () test_heartbeat_timeout (ZMQ_ROUTER); } -void test_heartbeat_timeout_rep () -{ - test_heartbeat_timeout (ZMQ_REP); -} - #define DEFINE_TESTS(first, second, first_define, second_define) \ void test_heartbeat_ttl_##first##_##second () \ { \ @@ -390,7 +381,6 @@ int main (void) UNITY_BEGIN (); RUN_TEST (test_heartbeat_timeout_router); - RUN_TEST (test_heartbeat_timeout_rep); RUN_TEST (test_heartbeat_ttl_dealer_router); RUN_TEST (test_heartbeat_ttl_req_rep);