From 6a66c051798332fbbf0fbffe09ff914746ece41f Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Tue, 16 Feb 2016 13:27:09 +0000 Subject: [PATCH] Problem: curve keys getsockopt uninitialised read Solution: always initialised zmq::options_t class variables arrays to avoid reading uninitialised data when CURVE is not yet configured and a getsockopt ZMQ_CURVE_{SERVER | PUBLIC | SECRET]KEY is issued. Backport from libzmq. --- src/options.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/options.cpp b/src/options.cpp index ea4f74c9..577763bb 100644 --- a/src/options.cpp +++ b/src/options.cpp @@ -68,6 +68,9 @@ zmq::options_t::options_t () : conflate (false), handshake_ivl (30000) { + memset (curve_public_key, 0, CURVE_KEYSIZE); + memset (curve_secret_key, 0, CURVE_KEYSIZE); + memset (curve_server_key, 0, CURVE_KEYSIZE); } int zmq::options_t::setsockopt (int option_, const void *optval_,