From 62e48f837d4f02df08a3445ac65e7bdeefb524fe Mon Sep 17 00:00:00 2001
From: Simon Giesecke <simon.giesecke@btc-ag.com>
Date: Thu, 17 May 2018 17:11:11 +0200
Subject: [PATCH] Problem: assignment within complex condition

Solution: restructured code, inverted condition
---
 src/zmq.cpp | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/zmq.cpp b/src/zmq.cpp
index 1f121ebc..a6cde645 100644
--- a/src/zmq.cpp
+++ b/src/zmq.cpp
@@ -685,7 +685,7 @@ const char *zmq_msg_gets (const zmq_msg_t *msg_, const char *property_)
     }
 }
 
-    // Polling.
+// Polling.
 
 #if defined ZMQ_HAVE_POLLER
 inline int zmq_poller_poll (zmq_pollitem_t *items_, int nitems_, long timeout_)
@@ -1176,18 +1176,20 @@ void *zmq_poller_new (void)
 
 int zmq_poller_destroy (void **poller_p_)
 {
-    void *poller;
-    if (!poller_p_ || !(poller = *poller_p_)
-        || !((zmq::socket_poller_t *) poller)->check_tag ()) {
-        errno = EFAULT;
-        return -1;
+    if (poller_p_) {
+        zmq::socket_poller_t *const poller =
+          static_cast<zmq::socket_poller_t *> (*poller_p_);
+        if (poller && poller->check_tag ()) {
+            delete poller;
+            *poller_p_ = NULL;
+            return 0;
+        }
     }
-
-    delete ((zmq::socket_poller_t *) poller);
-    *poller_p_ = NULL;
-    return 0;
+    errno = EFAULT;
+    return -1;
 }
 
+
 static int check_poller (void *const poller_)
 {
     if (!poller_ || !((zmq::socket_poller_t *) poller_)->check_tag ()) {