3party/libzmq
0
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2024-12-27 15:41:05 +08:00
Code Issues Projects Releases Wiki Activity

Problem: uninitialised error in testutil helper

Browse Source 
Solution: memset struct addrinfo to be sure
This commit is contained in:
Luca Boccassi 2020-05-06 11:51:55 +01:00
parent 5819867cd3
commit 346f8b8b20
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/testutil.cpp
View File

@ -391,14 +391,11 @@ fd_t connect_socket (const char *endpoint_, const int af_, const int protocol_)
} }
struct addrinfo *in, hint; struct addrinfo *in, hint;
memset (&hint, 0, sizeof (struct addrinfo));
hint.ai_flags = AI_NUMERICSERV; hint.ai_flags = AI_NUMERICSERV;
hint.ai_family = af_; hint.ai_family = af_;
hint.ai_socktype = SOCK_STREAM; hint.ai_socktype = SOCK_STREAM;
hint.ai_protocol = protocol_; hint.ai_protocol = protocol_;
hint.ai_addrlen = 0;
hint.ai_canonname = NULL;
hint.ai_addr = NULL;
hint.ai_next = NULL;
TEST_ASSERT_SUCCESS_RAW_ZERO_ERRNO ( TEST_ASSERT_SUCCESS_RAW_ZERO_ERRNO (
getaddrinfo (address, port, &hint, &in)); getaddrinfo (address, port, &hint, &in));
@ -444,14 +441,11 @@ fd_t bind_socket_resolve_port (const char *address_,
int flag = 1; int flag = 1;
#endif #endif
struct addrinfo *in, hint; struct addrinfo *in, hint;
memset (&hint, 0, sizeof (struct addrinfo));
hint.ai_flags = AI_NUMERICSERV; hint.ai_flags = AI_NUMERICSERV;
hint.ai_family = af_; hint.ai_family = af_;
hint.ai_socktype = protocol_ == IPPROTO_UDP ? SOCK_DGRAM : SOCK_STREAM; hint.ai_socktype = protocol_ == IPPROTO_UDP ? SOCK_DGRAM : SOCK_STREAM;
hint.ai_protocol = protocol_; hint.ai_protocol = protocol_;
hint.ai_addrlen = 0;
hint.ai_canonname = NULL;
hint.ai_addr = NULL;
hint.ai_next = NULL;
TEST_ASSERT_SUCCESS_RAW_ERRNO ( TEST_ASSERT_SUCCESS_RAW_ERRNO (
setsockopt (s_pre, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof (int))); setsockopt (s_pre, SOL_SOCKET, SO_REUSEADDR, &flag, sizeof (int)));