3party/libzmq
0
0
Fork 0
mirror of https://github.com/zeromq/libzmq.git synced 2025-03-27 15:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ROUTER's xhas_out() in MANDATORY mode

Browse Source 
Before this commit, xhas_out() was returning true regardless. This
was correct before the ZMQ_ROUTER_MANDATORY flag as introduced.
However, ZMQ_POLLOUT.

With this commit, _if_ ZMQ_ROUTER_MANDATORY is set, xhas_out() will
return false if ALL peer's outgoing pipes are full.

There is an outstanding high-level design question:

If ZMQ_ROUTER_MANDATORY is set, and zmq_poll() waits for ZMQ_POLLOUT
events, zmq_poll() will immediately wake up if only 1 pipe has
room to send, regardless of the peer, creating a busy loop of
zmq_poll() wake-up, zmq_send() (EAGAIN). There is no way for
the application to selectively wait for ZMQ_POLLOUT for specific
peer(s), which seems somehow necessary in ZMQ_ROUTER_MANDATORY.

This discussion will be addressed in a separate issue.

Signed-off-by: Marc Sune <marc@voltanet.io>
Signed-off-by: Fredi Raspall <fredi@voltanet.io>
This commit is contained in:
Marc Sune 2017-07-14 15:35:32 +02:00
parent 44c56a8e09
commit 10694373e3
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/router.cpp
View File

@ -385,10 +385,19 @@ bool zmq::router_t::xhas_in ()
bool zmq::router_t::xhas_out () bool zmq::router_t::xhas_out ()
{ {
// In theory, ROUTER socket is always ready for writing. Whether actual // In theory, ROUTER socket is always ready for writing (except when
// attempt to write succeeds depends on whitch pipe the message is going // MANDATORY is set). Whether actual attempt to write succeeds depends
// to be routed to. // on whitch pipe the message is going to be routed to.
return true;
if(!mandatory)
return true;
bool has_out = false;
outpipes_t::iterator it;
for (it = outpipes.begin (); it != outpipes.end (); ++it)
has_out |= it->second.pipe->check_hwm();
return has_out;
} }
zmq::blob_t zmq::router_t::get_credential () const zmq::blob_t zmq::router_t::get_credential () const