diff --git a/include/json/assertions.h b/include/json/assertions.h index a88ac0a..d5fd661 100644 --- a/include/json/assertions.h +++ b/include/json/assertions.h @@ -16,11 +16,15 @@ #if JSON_USE_EXCEPTION #include #define JSON_ASSERT(condition) \ - if (!(condition)) {throw std::logic_error( "assert json failed" );} // @todo <= add detail about condition in exception -#define JSON_FAIL_MESSAGE(message) do{std::ostringstream oss; oss << message; throw std::logic_error(oss.str());}while(0) + {if (!(condition)) {throw std::logic_error( "assert json failed" );}} // @todo <= add detail about condition in exception +#define JSON_FAIL_MESSAGE(message) \ + { \ + std::ostringstream oss; oss << message; \ + throw std::logic_error(oss.str()); \ + } //#define JSON_FAIL_MESSAGE(message) throw std::logic_error(message) #else // JSON_USE_EXCEPTION -#define JSON_ASSERT(condition) assert(condition); +#define JSON_ASSERT(condition) assert(condition) // The call to assert() will show the failure message in debug builds. In // release bugs we abort, for a core-dump or debugger. diff --git a/src/test_lib_json/CMakeLists.txt b/src/test_lib_json/CMakeLists.txt index df5a924..f925ce0 100644 --- a/src/test_lib_json/CMakeLists.txt +++ b/src/test_lib_json/CMakeLists.txt @@ -1,3 +1,4 @@ +# vim: et ts=4 sts=4 sw=4 tw=0 IF(JSONCPP_LIB_BUILD_SHARED) ADD_DEFINITIONS( -DJSON_DLL ) @@ -22,9 +23,19 @@ ENDIF(JSONCPP_LIB_BUILD_SHARED) # Run unit tests in post-build # (default cmake workflow hides away the test result into a file, resulting in poor dev workflow?!?) IF(JSONCPP_WITH_POST_BUILD_UNITTEST) - ADD_CUSTOM_COMMAND( TARGET jsoncpp_test - POST_BUILD - COMMAND $) + IF(JSONCPP_LIB_BUILD_SHARED) + # First, copy the shared lib, for Microsoft. + # Then, run the test executable. + ADD_CUSTOM_COMMAND( TARGET jsoncpp_test + POST_BUILD + COMMAND ${CMAKE_COMMAND} -E copy_if_different $ $ + COMMAND $) + ELSE(JSONCPP_LIB_BUILD_SHARED) + # Just run the test executable. + ADD_CUSTOM_COMMAND( TARGET jsoncpp_test + POST_BUILD + COMMAND $) + ENDIF(JSONCPP_LIB_BUILD_SHARED) ENDIF(JSONCPP_WITH_POST_BUILD_UNITTEST) SET_TARGET_PROPERTIES(jsoncpp_test PROPERTIES OUTPUT_NAME jsoncpp_test) diff --git a/src/test_lib_json/main.cpp b/src/test_lib_json/main.cpp index 69ecae3..25a334b 100644 --- a/src/test_lib_json/main.cpp +++ b/src/test_lib_json/main.cpp @@ -2203,7 +2203,7 @@ JSONTEST_FIXTURE(IteratorTest, distance) { Json::Value json; json["k1"] = "a"; json["k2"] = "b"; - int dist; + int dist = 0; std::string str; for (Json::ValueIterator it = json.begin(); it != json.end(); ++it) { dist = it - json.begin();