3party/jsoncpp
0
0
Fork 0
mirror of https://github.com/open-source-parsers/jsoncpp.git synced 2024-12-27 11:21:02 +08:00
Code Issues Projects Releases Wiki Activity

stop calling validate() in newReader/Writer()

Browse Source 
By not calling validate(), we can add
non-invasive features which will be simply ignored when user-code
is compiled against an old version. That way, we can often
avoid a minor version-bump.

The user can call validate() himself if he prefers that behavior.
This commit is contained in:
Christopher Dunn 2015-02-11 11:15:32 -06:00
parent acbf4eb2ef
commit 3ebba5cea8
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib_json/json_reader.cpp
View File

@ -1863,9 +1863,6 @@ CharReaderBuilder::~CharReaderBuilder()
{} {}
CharReader* CharReaderBuilder::newCharReader() const CharReader* CharReaderBuilder::newCharReader() const
{ {
if (!validate(NULL)) throw std::runtime_error("invalid settings");
// TODO: Maybe serialize the invalid settings into the exception.
bool collectComments = settings_["collectComments"].asBool(); bool collectComments = settings_["collectComments"].asBool();
OurFeatures features = OurFeatures::all(); OurFeatures features = OurFeatures::all();
features.allowComments_ = settings_["allowComments"].asBool(); features.allowComments_ = settings_["allowComments"].asBool();

3
src/lib_json/json_writer.cpp
View File

@ -968,9 +968,6 @@ StreamWriterBuilder::~StreamWriterBuilder()
{} {}
StreamWriter* StreamWriterBuilder::newStreamWriter() const StreamWriter* StreamWriterBuilder::newStreamWriter() const
{ {
if (!validate(NULL)) throw std::runtime_error("invalid settings");
// TODO: Maybe serialize the invalid settings into the exception.
std::string indentation = settings_["indentation"].asString(); std::string indentation = settings_["indentation"].asString();
std::string cs_str = settings_["commentStyle"].asString(); std::string cs_str = settings_["commentStyle"].asString();
bool eyc = settings_["enableYAMLCompatibility"].asBool(); bool eyc = settings_["enableYAMLCompatibility"].asBool();