fix security hole for string-key-lengths > 2^30

This commit is contained in:
Christopher Dunn 2015-03-02 23:42:12 -06:00
parent 585b267595
commit 2d653bd15d
2 changed files with 1 additions and 2 deletions

View File

@ -1430,6 +1430,7 @@ bool OurReader::readObject(Token& tokenStart) {
return addErrorAndRecover(
"Missing ':' after object member name", colon, tokenObjectEnd);
}
if (name.length() >= (1U<<30)) throw std::runtime_error("keylength >= 2^30");
Value& value = currentValue()[name];
nodes_.push(&value);
bool ok = readValue();

View File

@ -191,8 +191,6 @@ void Value::CommentInfo::setComment(const char* text, size_t len) {
// Notes: policy_ indicates if the string was allocated when
// a string is stored.
//
// TODO: Check for length > 1GB, in Reader.
Value::CZString::CZString(ArrayIndex index) : cstr_(0), index_(index) {}