4301 Commits

Author SHA1 Message Date
Hossein Ghahramanzadeh
d6841c040d Apply requested changes by using std::inserter with move. 2022-02-05 17:43:21 +01:00
Andrew Krasavin
631f4f9947 Fix gtest-help-test failure on OpenBSD 2022-02-05 03:44:54 +03:00
Copybara-Service
14aa11db02 Merge pull request #3724 from jjfvanderpol:main
PiperOrigin-RevId: 426450614
Change-Id: Iccbe56ddd81f4f3935b3d44aa5b835146758ff83
2022-02-04 11:28:32 -08:00
Abseil Team
25ad42aabe GetCurrentOsStackTraceExceptTop (both the method of UnitTestImpl and the wrapper function in gtest.cc) rely on the fact that the inner call is not getting optimized.
This CL annotates them with the appropriate attributes.

PiperOrigin-RevId: 425663217
Change-Id: Ib9ec2a69a7dd98d37640b56d4d7798572da66669
2022-02-01 10:44:59 -08:00
Copybara-Service
4517697675 Merge pull request #3744 from danger89:patch-2
PiperOrigin-RevId: 425519462
Change-Id: I196b22675e471f66929c1cdd0f85a405ebac8484
2022-01-31 20:01:13 -08:00
Hossein Ghahramanzadeh
2eadda6e00 Do constant time matching for exact match filters. 2022-01-31 19:22:37 +01:00
Derek Mauro
28e1da21d8 Finish some missed pieces of the TestCase to TestSuite Migration
PiperOrigin-RevId: 424864779
Change-Id: Iac5cafa3568f5fe41c85c52d28f7d61845f76868
2022-01-28 07:27:11 -08:00
Dino Radakovic
0b7798b2fb Change ReturnArg to use perfect forwarding of arguments (#3733)
PiperOrigin-RevId: 424355706
Change-Id: I618e5574b4b2c56a343905c20d8cc6d2a70cbcd1
2022-01-26 08:40:27 -08:00
Melroy van den Berg
f2d71f0be2
Let me give a change to try it again - updating to latest version 2022-01-25 22:45:24 +01:00
Abseil Team
f45d5865ed Make recreate_environments_when_repeating=false the default.
So that global test environments are by default set up and torn down once,
regardless of the value of the repeat flag.

The point of global environments is to be set up and torn down once, and shared
by all tests in the process. There is no obvious reason why multiple runs of the
same test should be treated distinctly from single runs of different tests.

Having this be false by default means that repeats using a global environment
run faster. It can still be set to true if it's desired that every repeat get a
fresh environment, but this seems less important given the nature of a global
environment. Every test I've seen using a global environment uses it to set up
some expensive external resource, not something that can/should be set up for
each test anew. (Again this is unsurprising, since the environment is a global.)

PiperOrigin-RevId: 424003937
Change-Id: I9e8a825cb8900960dd65b85fe5ffcc0a337e57f3
2022-01-24 23:46:52 -08:00
Copybara-Service
7eae8de0da Merge pull request #3723 from ramkumar-kr:patch-1
PiperOrigin-RevId: 423920083
Change-Id: I5e172813387f841d5a6c56eea155b876a465d208
2022-01-24 15:04:20 -08:00
Copybara-Service
f64cf6b7b8 Merge pull request #3732 from joshiayush:i2174
PiperOrigin-RevId: 423906844
Change-Id: I1c34a3ce8a5c761ef9f1d7ce48bef8826742e97d
2022-01-24 14:08:19 -08:00
Copybara-Service
3d81736c97 Merge pull request #3615 from IYP-Programer-Yeah:fix-per-test-filter-processing
PiperOrigin-RevId: 423326942
Change-Id: I913f31960d7917b176c9f390424630708473837a
2022-01-21 08:18:49 -08:00
Abseil Team
2ddfdf819d Factor out AssertionResult into dedicated gtest-assertion-result header + implementation files to prevent cyclic includes between gtest.h and gtest_pred_impl.h
PiperOrigin-RevId: 422863083
Change-Id: I299018a860152216adc206780c32923c03bedb2a
2022-01-19 11:31:36 -08:00
Abseil Team
100f6fbf5f Consistently apply IWYU pragmas across googletest and googlemock headers
PiperOrigin-RevId: 422559250
Change-Id: I9f630f2186724950e5e9fbd7093d5264e8bf0a71
2022-01-18 08:11:11 -08:00
Copybara-Service
c9643a2e45 Merge pull request #3721 from joshiayush:i3719
PiperOrigin-RevId: 422405356
Change-Id: I8ea22485d9a25dce81a28d0c323a73b36d15e912
2022-01-17 12:59:48 -08:00
Dino Radakovic
4e9fe30884 Fix reference to source file in gmock FAQ
PiperOrigin-RevId: 421915817
Change-Id: I22800e8943f9eb050304c521701d4040b1b7a914
2022-01-14 14:40:35 -08:00
Derek Mauro
4e82924686 Update test Docker image to GCC 11.2, Clang 14 (prerelease),
CMake 3.22.1, and Bazel 4.2.2

PiperOrigin-RevId: 421814198
Change-Id: Ief4e39d7f077089f10afdc8d63cc1e51dc18e97f
2022-01-14 06:52:59 -08:00
Ayush Joshi
ca3ffd90f2 FIX #2174 -- remove DEBUG_POSTFIX
while this is not synced with the pkg-config file, it only breaks things

Fix #2174

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-13 21:24:56 +05:30
Abseil Team
2d07f12b60 Fix run-on sentence
dispatch. It will use the definition from the class the constructor of which

PiperOrigin-RevId: 421291241
Change-Id: If81e3d6d3774edfbbb4baaec8a3cd96566b3b09c
2022-01-12 07:19:51 -08:00
Copybara-Service
aea0874c42 Merge pull request #3725 from bsilver8192:remove-another-disallow-assign
PiperOrigin-RevId: 421044680
Change-Id: If585089811f1b67eab6f339125c27174ee5bc290
2022-01-11 09:01:32 -08:00
Copybara-Service
1d9f7c5fb2 Merge pull request #3713 from PhilipMourdjis:cmake-qnx-link-regex
PiperOrigin-RevId: 420863433
Change-Id: Ie8c43caff6fb2493ecd47bed50de9db87221f46f
2022-01-10 14:56:50 -08:00
Hossein Ghahramanzadeh
29bc520e5b Fix a typo in comments. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4fc151ae69 Use normal for loop instead of accumulate. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
aea981dd54 Improve code readablity. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4adbc9c9b2 Apply requested changes to preserve old behavior. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
d03d23a6e5 Reimplement MatchesFilter with new interfaces. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
3fc1ab6632 Apply requested changes. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f20688737a Get rid of redundant filter matching code 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f5b4efef5f Add comments describing the behavior of filters 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
2377c8d32b Process filter string once instead of per test 2022-01-06 15:46:52 +01:00
Brian
58b71c9ea2 Remove another GTEST_DISALLOW_ASSIGN_ that crept in
They were all removed in #2815, but it looks like this one got added
from a Google export which missed the update. See #2815 for reasons why
removing this is desirable.
2022-01-05 21:33:05 -08:00
Joris van der Pol
91461509de
Set CMake Policy CMP0077 to NEW 2022-01-05 11:07:50 +01:00
Ram Kumar K R
0256210376
Update example to reflect the tests below 2022-01-04 13:36:22 -08:00
Ayush Joshi
1b4cf35958 FIX #3719 -- Fix clang conversion warnings
We should perform an explicit type conversion to `unsigned char` before passing the
`const char` data to `IsValidXmlCharacter()` and `IsNormalizableWhitespace()` functions
in order to avoid compile time conversion warnings

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-01 19:28:21 +05:30
Abseil Team
6b74da4757 Include the param names in the generated description of the MATCHER_P matchers.
PiperOrigin-RevId: 418497526
Change-Id: Ie53c3c0810c10a32cbcb941e3ca1ee8fb1ddd9f9
2021-12-27 08:05:24 -08:00
Abseil Team
d81ae2f0bf Clarify "package" means "Bazel package", and promote testonly=True rather than testing sub-directory.
PiperOrigin-RevId: 417945818
Change-Id: I8686ee0414fb80269528677f291877a231d1c991
2021-12-22 22:50:04 -08:00
Derek Mauro
c58f562fa2 Makes the Python imports consistently use full paths from the repository root,
unifying the behavior between Bazel and CMake

This fixes one of the CI failures on Windows

PiperOrigin-RevId: 417872531
Change-Id: I156989323b7e6d4a4420f4f9691b078829db933d
2021-12-22 13:01:24 -08:00
Derek Mauro
71d4e2f742 Makes TestForDeathTest.CRTDebugDeath only run when _DEBUG is defined
PiperOrigin-RevId: 417678422
Change-Id: I8e42a906459b8fd5a7789a7ed728d12448046c44
2021-12-21 13:16:17 -08:00
Philip Mourdjis
4745746725 link to regex on qnx in cmake 2021-12-21 16:14:03 +00:00
Copybara-Service
9a32aee22d Merge pull request #3684 from ludgerpaehler:patch-1
PiperOrigin-RevId: 417474317
Change-Id: I4c84f59ba272a6bec3f992f7afae36e1c5617fad
2021-12-20 13:59:26 -08:00
Dino Radakovic
97a467571a Release tests for UnitTestOptions::MatchesFilter
PiperOrigin-RevId: 416567004
Change-Id: Ic407e0fcdf8ffd1c012a1b12df2837bdac1dccb4
2021-12-15 08:36:08 -08:00
Copybara-Service
054a986a85 Merge pull request #3694 from joshiayush:main
PiperOrigin-RevId: 415014511
Change-Id: If2e20eb9408a23b5574a2c87f651c2905f14fcac
2021-12-08 08:53:55 -08:00
Abseil Team
4c5650f688 Add NOLINT to address modernize-use-trailing-return-type in TEST_F uses
Example command:

```
clang_tidy '--config={Checks: "modernize-use-trailing-return-type"}' googletest-death-test-test.cc
```

Example error:

```
warning: use a trailing return type for this function [modernize-use-trailing-return-type]
TEST(NotADeathTest, Test) {
^
```
PiperOrigin-RevId: 414836261
Change-Id: I5f758423667559abfbf313190543666bc4ce0e6e
2021-12-07 15:09:13 -08:00
Ayush Joshi
3ea587050d Allow to specify a random seed independently of whether shuffling is requested
This commit fixes issue #3681

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2021-12-04 21:18:18 +05:30
Abseil Team
d61d4d8e64 Support std::reference_wapper as a smart pointer type in gmock
PiperOrigin-RevId: 413963503
Change-Id: I33440780bf087698f4e4325399227405885430b3
2021-12-03 10:14:13 -08:00
Abseil Team
1b2606425c Fix typo in GoogleMock Cookbook.
PiperOrigin-RevId: 413674665
Change-Id: I466f87348390f42434a70f183efdf0557be9dddd
2021-12-02 07:44:32 -08:00
Abseil Team
bb9216085f Work around Android KitKat tzset bug
On KitKat, calling tzset with UTC+nn doesn't initialize all the
timezone state. If the previous timezone was something like
America/Chicago, then changing it to UTC+nn might have no effect.
Setting the timezone to an intermediate value like "UTC" avoids the
problem.

Works around https://github.com/android/ndk/issues/1604.

PiperOrigin-RevId: 413050236
Change-Id: I99b2d3330ae68f1d58cd2ca278d3eaae30bd1e83
2021-11-29 20:53:29 -08:00
Ludger Paehler
b4d4e6e348
Fix typo in the queue test. 2021-11-25 16:53:19 +01:00
Copybara-Service
e2f3978937 Merge pull request #3620 from hzeller:add-simple-ci
PiperOrigin-RevId: 411929458
Change-Id: Id102172091fb708c0c8252da6d3570771fc15dba
2021-11-23 17:23:00 -08:00