3party/googletest
0
0
Fork 0
mirror of https://github.com/google/googletest.git synced 2024-12-28 19:15:24 +08:00
Code Issues Projects Releases Wiki Activity

remove a custom implementation of std::is_reference

Browse Source
This commit is contained in:
Krystian Kuzniarek 2019-08-14 13:33:13 +02:00
parent 90a443f9c2
commit da76d01b98
5 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
googlemock/include/gmock/gmock-actions.h
View File

@ -532,7 +532,7 @@ class ReturnAction {
// in the Impl class. But both definitions must be the same. // in the Impl class. But both definitions must be the same.
typedef typename Function<F>::Result Result; typedef typename Function<F>::Result Result;
GTEST_COMPILE_ASSERT_( GTEST_COMPILE_ASSERT_(
!is_reference<Result>::value, !std::is_reference<Result>::value,
use_ReturnRef_instead_of_Return_to_return_a_reference); use_ReturnRef_instead_of_Return_to_return_a_reference);
static_assert(!std::is_void<Result>::value, static_assert(!std::is_void<Result>::value,
"Can't use Return() on an action expected to return `void`."); "Can't use Return() on an action expected to return `void`.");
@ -561,7 +561,7 @@ class ReturnAction {
Result Perform(const ArgumentTuple&) override { return value_; } Result Perform(const ArgumentTuple&) override { return value_; }
private: private:
GTEST_COMPILE_ASSERT_(!is_reference<Result>::value, GTEST_COMPILE_ASSERT_(!std::is_reference<Result>::value,
Result_cannot_be_a_reference_type); Result_cannot_be_a_reference_type);
// We save the value before casting just in case it is being cast to a // We save the value before casting just in case it is being cast to a
// wrapper type. // wrapper type.
@ -640,7 +640,7 @@ class ReturnRefAction {
// Asserts that the function return type is a reference. This // Asserts that the function return type is a reference. This
// catches the user error of using ReturnRef(x) when Return(x) // catches the user error of using ReturnRef(x) when Return(x)
// should be used, and generates some helpful error message. // should be used, and generates some helpful error message.
GTEST_COMPILE_ASSERT_(internal::is_reference<Result>::value, GTEST_COMPILE_ASSERT_(std::is_reference<Result>::value,
use_Return_instead_of_ReturnRef_to_return_a_value); use_Return_instead_of_ReturnRef_to_return_a_value);
return Action<F>(new Impl<F>(ref_)); return Action<F>(new Impl<F>(ref_));
} }
@ -687,7 +687,7 @@ class ReturnRefOfCopyAction {
// catches the user error of using ReturnRefOfCopy(x) when Return(x) // catches the user error of using ReturnRefOfCopy(x) when Return(x)
// should be used, and generates some helpful error message. // should be used, and generates some helpful error message.
GTEST_COMPILE_ASSERT_( GTEST_COMPILE_ASSERT_(
internal::is_reference<Result>::value, std::is_reference<Result>::value,
use_Return_instead_of_ReturnRefOfCopy_to_return_a_value); use_Return_instead_of_ReturnRefOfCopy_to_return_a_value);
return Action<F>(new Impl<F>(value_)); return Action<F>(new Impl<F>(value_));
} }

2
googlemock/include/gmock/gmock-matchers.h
View File

@ -280,7 +280,7 @@ class SafeMatcherCastImpl {
// Enforce that we are not converting a non-reference type T to a reference // Enforce that we are not converting a non-reference type T to a reference
// type U. // type U.
GTEST_COMPILE_ASSERT_( GTEST_COMPILE_ASSERT_(
internal::is_reference<T>::value || !internal::is_reference<U>::value, std::is_reference<T>::value || !std::is_reference<U>::value,
cannot_convert_non_reference_arg_to_reference); cannot_convert_non_reference_arg_to_reference);
// In case both T and U are arithmetic types, enforce that the // In case both T and U are arithmetic types, enforce that the
// conversion is not lossy. // conversion is not lossy.

2
googlemock/include/gmock/gmock-more-actions.h
View File

@ -105,7 +105,7 @@ ACTION_TEMPLATE(SetArgReferee,
// Ensures that argument #k is a reference. If you get a compiler // Ensures that argument #k is a reference. If you get a compiler
// error on the next line, you are using SetArgReferee<k>(value) in // error on the next line, you are using SetArgReferee<k>(value) in
// a mock function whose k-th (0-based) argument is not a reference. // a mock function whose k-th (0-based) argument is not a reference.
GTEST_COMPILE_ASSERT_(internal::is_reference<argk_type>::value, GTEST_COMPILE_ASSERT_(std::is_reference<argk_type>::value,
SetArgReferee_must_be_used_with_a_reference_argument); SetArgReferee_must_be_used_with_a_reference_argument);
::std::get<k>(args) = value; ::std::get<k>(args) = value;
} }

4
googlemock/include/gmock/internal/gmock-internal-utils.h
View File

@ -355,10 +355,6 @@ GTEST_API_ WithoutMatchers GetWithoutMatchers();
// Type traits. // Type traits.
// is_reference<T>::value is non-zero if T is a reference type.
template <typename T> struct is_reference : public false_type {};
template <typename T> struct is_reference<T&> : public true_type {};
// type_equals<T1, T2>::value is non-zero if T1 and T2 are the same type. // type_equals<T1, T2>::value is non-zero if T1 and T2 are the same type.
template <typename T1, typename T2> struct type_equals : public false_type {}; template <typename T1, typename T2> struct type_equals : public false_type {};
template <typename T> struct type_equals<T, T> : public true_type {}; template <typename T> struct type_equals<T, T> : public true_type {};

6
googlemock/test/gmock-internal-utils_test.cc
View File

@ -512,12 +512,6 @@ TEST(TypeTraitsTest, false_type) {
EXPECT_FALSE(false_type::value); EXPECT_FALSE(false_type::value);
} }
TEST(TypeTraitsTest, is_reference) {
EXPECT_FALSE(is_reference<int>::value);
EXPECT_FALSE(is_reference<char*>::value);
EXPECT_TRUE(is_reference<const int&>::value);
}
TEST(TypeTraitsTest, type_equals) { TEST(TypeTraitsTest, type_equals) {
EXPECT_FALSE((type_equals<int, const int>::value)); EXPECT_FALSE((type_equals<int, const int>::value));
EXPECT_FALSE((type_equals<int, int&>::value)); EXPECT_FALSE((type_equals<int, int&>::value));