3party/googletest
0
0
Fork 0
mirror of https://github.com/google/googletest.git synced 2024-12-27 10:11:03 +08:00
Code Issues Projects Releases Wiki Activity

Googletest export

Browse Source 
Add a note to recommend against using `Property()` for functions that the test author does not own.

PiperOrigin-RevId: 355295183
This commit is contained in:
Abseil Team 2021-02-02 18:11:55 -08:00 committed by Dino Radaković
parent aea7f60bf5
commit b6323d216d
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/gmock_cheat_sheet.md
View File

@ -400,6 +400,12 @@ messages, you can use:
| `Property(property_name, &class::property, m)` | The same as the two-parameter version, but provides a better error message. | `Property(property_name, &class::property, m)` | The same as the two-parameter version, but provides a better error message.
<!-- mdformat on --> <!-- mdformat on -->
**Notes:**
* Don't use `Property()` against member functions that you do not own, because
taking addresses of functions is fragile and generally not part of the
contract of the function.
### Matching the Result of a Function, Functor, or Callback ### Matching the Result of a Function, Functor, or Callback
<!-- mdformat off(no multiline tables) --> <!-- mdformat off(no multiline tables) -->

6
docs/gmock_cook_book.md
View File

@ -1216,9 +1216,11 @@ For example:
<!-- mdformat on --> <!-- mdformat on -->
Note that in `Property(&Foo::baz, ...)`, method `baz()` must take no argument Note that in `Property(&Foo::baz, ...)`, method `baz()` must take no argument
and be declared as `const`. and be declared as `const`. Don't use `Property()` against member functions that
you do not own, because taking addresses of functions is fragile and generally
not part of the contract of the function.
BTW, `Field()` and `Property()` can also match plain pointers to objects. For `Field()` and `Property()` can also match plain pointers to objects. For
instance, instance,
```cpp ```cpp